Google Git
Sign in
bazel / bazel / e00a3255d6d8a40591fe968ec423c299ab52a8c6
commite00a3255d6d8a40591fe968ec423c299ab52a8c6[log] [tgz]
authoradonovan <adonovan@google.com>Wed Feb 05 13:10:40 2020 -0800
committerCopybara-Service <copybara-worker@google.com>Wed Feb 05 13:11:50 2020 -0800
tree06a05b0422dd09f502e39af23d35914b23714ed0
parenta285e47a0c34703d421bf1f03038228682b42d0d [diff]
bazel syntax: break bad dependencies on StarlarkSemantics.FlagIdentifier

Currently the Starlark annotation classes and annotation processor depend on StarlarkSemantics.FlagIdentifier, yet the latter type is coupled to
StarlarkSemantics, which is currently part of :frontend, so this is an upward
dependency (and StarlarkSemantics will eventually move even higher up,
to :evaluator). This logical cycle was broken by having StarlarkSemantics
appear in two java_library rules, which is always a sign of bad design.

This change replaces FlagIdentifier by a simple String, allowing
us to break the dependency.

Also:
- skylarkinterface/ gets its own BUILD file.
- x==FlagIdentifier.NONE is now x.isEmpty().

A later change will move all the FlagIdentifier string constants up into
Bazel proper, where whey belong.

PiperOrigin-RevId: 293434176
40 files changed
tree: 06a05b0422dd09f502e39af23d35914b23714ed0
  1. .bazelci/
  2. examples/
  3. scripts/
  4. site/
  5. src/
  6. third_party/
  7. tools/
  8. .bazelrc
  9. .gitattributes
  10. .gitignore
  11. AUTHORS
  12. BUILD
  13. CHANGELOG.md
  14. CODEOWNERS
  15. combine_distfiles.py
  16. combine_distfiles_to_tar.sh
  17. compile.sh
  18. CONTRIBUTING.md
  19. CONTRIBUTORS
  20. distdir.bzl
  21. ISSUE_TEMPLATE.md
  22. LICENSE
  23. README.md
  24. WORKSPACE
README.md

Bazel

{Fast, Correct} - Choose two

Build and test software of any size, quickly and reliably.

  • Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.

  • One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.

  • Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.

  • Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.

Getting Started

Documentation

Contributing to Bazel

See CONTRIBUTING.md

Build status