commit e2ae73fe16cbedf095b9e6d5687b06ecf765d794
author ajurkowski <ajurkowski@google.com> Wed May 19 13:47:00 2021 -0700
committer Copybara-Service <copybara-worker@google.com> Wed May 19 13:49:24 2021 -0700
tree 2fd3906f4dedfb8e85951eb25010f0369ee0ee1d
parent 39abd618f714c0eda5421e1cd9da538e054174d2

Avoid creating a copy of tree artifacts expansion for discovered inputs.

Take a reference directly to the set within `TreeArtifactValue` instead of
making a copy.

PiperOrigin-RevId: 374720896

src/main/java/com/google/devtools/build/lib/skyframe/ActionExecutionFunction.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/ActionExecutionFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/ActionExecutionFunction.java
index e14623f..076fdd0 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/ActionExecutionFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/ActionExecutionFunction.java
@@ -984,7 +984,7 @@
       }
       if (retrievedMetadata instanceof TreeArtifactValue) {
         TreeArtifactValue treeValue = (TreeArtifactValue) retrievedMetadata;
-        expandedArtifacts.put(input, ImmutableSet.copyOf(treeValue.getChildren()));
+        expandedArtifacts.put(input, treeValue.getChildren());
         for (Map.Entry<Artifact.TreeFileArtifact, FileArtifactValue> child :
             treeValue.getChildValues().entrySet()) {
           inputData.putWithNoDepOwner(child.getKey(), child.getValue());