commit e36b6825dd35668759f2f35bcd9bea5d49777573
author cparsons <cparsons@google.com> Wed Sep 25 11:08:43 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Sep 25 11:10:15 2019 -0700
tree 4da1e6d4421368b034870dad2561b051269a1d7b
parent 93f215f8797fc731b498796d57db7efe6efb4795

Mark PackageFactory's glob.include as 'named'

This is a functional no-op, as @SkylarkSignature (as a legacy bug) allows *every* parameter to be specified by keyword, regardless of this field. However, it is confusingly inconsistent with the @SkylarkCallable declaration of this function

RELNOTES: None.
PiperOrigin-RevId: 271162898

src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java

diff --git a/src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java b/src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java
index b5ef618..c355dc9 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/PackageFactory.java
@@ -511,6 +511,7 @@
             name = "include",
             type = SkylarkList.class,
             generic1 = String.class,
+            named = true,
             doc = "a list of strings specifying patterns of files to include."),
         @Param(
             name = "exclude",