Cancel pending invalidation lookup futures when `AnalysisCacheInvalidator.lookupKeysToInvalidate()` does not complete normally.
When `AnalysisCacheInvalidator.lookupKeysToInvalidate()` times out, encounters an `ExecutionException`, or is interrupted while submitting or waiting for responses, it falls back to invalidating all keys (`Futures.allAsList(futures).get(...)` only cancels the combined `ListFuture` wrapper on timeout/interruption, which does not propagate cancellation to the input futures unless they are explicitly cancelled). Leaving the individual lookup futures uncancelled keeps their `SkycacheChannelStateAdvisor` in-flight request tokens acquired and allows orphaned invalidation RPCs and buffered batch entries to remain active after the invalidation check has already given up.
Before:
```java
try {
List<ListenableFuture<Optional<SkyKey>>> futures =
submitInvalidationLookupsBatched(keysToLookup);
...
keysToInvalidate =
Futures.allAsList(futures).get(INVALIDATION_TIMEOUT_SECONDS, SECONDS).stream()
.flatMap(Optional::stream)
.collect(toImmutableSet());
status = InvalidationLookupMetrics.Status.OK;
} catch (TimeoutException e) {
status = InvalidationLookupMetrics.Status.TIMED_OUT;
return keysToLookup;
} finally {
stopwatch.stop();
...
}
```
After:
```java
List<ListenableFuture<Optional<SkyKey>>> futures = null;
try {
futures = submitInvalidationLookupsBatched(keysToLookup);
...
} finally {
if (futures != null && status != InvalidationLookupMetrics.Status.OK) {
cancelFutures(futures);
}
stopwatch.stop();
...
}
```
Cancelling the submitted `ListenableFuture` instances in `finally` when `status != InvalidationLookupMetrics.Status.OK` (and when batch submission itself times out or is interrupted) propagates cancellation through `Futures.transform` / `Futures.transformAsync` to the underlying `analysisCacheClient.lookup()` futures immediately, releasing their in-flight request tokens.
PiperOrigin-RevId: 1007822773
Change-Id: I4fc0a25d576418fae428f16c0fb313ad643d8bd5
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md