Remove no longer needed `hasLooseHeaders` method.
PiperOrigin-RevId: 387354971
diff --git a/src/main/java/com/google/devtools/build/lib/actions/ActionAnalysisMetadata.java b/src/main/java/com/google/devtools/build/lib/actions/ActionAnalysisMetadata.java
index ef85174..874818d 100644
--- a/src/main/java/com/google/devtools/build/lib/actions/ActionAnalysisMetadata.java
+++ b/src/main/java/com/google/devtools/build/lib/actions/ActionAnalysisMetadata.java
@@ -216,17 +216,6 @@
/** Returns the action type. Must not be {@code null}. */
MiddlemanType getActionType();
- /**
- * Indicates whether this action has loose headers, or if this is an {@link ActionTemplate},
- * whether the expanded action(s) will have loose headers.
- *
- * <p>If this is true, top-down evaluation considers an action changed if any source files in
- * package have changed.
- */
- default boolean hasLooseHeaders() {
- return false;
- }
-
/** Returns a String to String map containing the execution properties of this action. */
ImmutableMap<String, String> getExecProperties();
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java
index 61d442e..3677f00 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileAction.java
@@ -76,7 +76,6 @@
import com.google.devtools.build.lib.profiler.SilentCloseable;
import com.google.devtools.build.lib.rules.cpp.CcCommon.CoptsFilter;
import com.google.devtools.build.lib.rules.cpp.CcToolchainFeatures.FeatureConfiguration;
-import com.google.devtools.build.lib.rules.cpp.CppConfiguration.HeadersCheckingMode;
import com.google.devtools.build.lib.rules.cpp.IncludeScanner.IncludeScanningHeaderData;
import com.google.devtools.build.lib.server.FailureDetails.CppCompile;
import com.google.devtools.build.lib.server.FailureDetails.CppCompile.Code;
@@ -694,7 +693,6 @@
return compileCommandLine.getDotdFile();
}
- @VisibleForTesting
public CcCompilationContext getCcCompilationContext() {
return ccCompilationContext;
}
@@ -1773,23 +1771,6 @@
return message.toString();
}
- @Override
- public boolean hasLooseHeaders() {
- return hasLooseHeaders(ccCompilationContext, featureConfiguration);
- }
-
- // Separated into a helper method so that it can be called from CppCompileActionTemplate.
- static boolean hasLooseHeaders(
- CcCompilationContext ccCompilationContext, FeatureConfiguration featureConfiguration) {
- if (ccCompilationContext.getHeadersCheckingMode() != HeadersCheckingMode.LOOSE) {
- return false;
- }
- // Loose headers may still be included via textual_hdrs even if layering check is enabled.
- return !featureConfiguration.isEnabled(CppRuleClasses.LAYERING_CHECK)
- || !featureConfiguration.isEnabled(CppRuleClasses.PARSE_HEADERS)
- || !ccCompilationContext.getTextualHdrs().isEmpty();
- }
-
public CompileCommandLine getCompileCommandLine() {
return compileCommandLine;
}
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileActionTemplate.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileActionTemplate.java
index e3e088d..24120d5 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileActionTemplate.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileActionTemplate.java
@@ -304,13 +304,6 @@
}
@Override
- public boolean hasLooseHeaders() {
- return CppCompileAction.hasLooseHeaders(
- cppCompileActionBuilder.getCcCompilationContext(),
- cppCompileActionBuilder.getFeatureConfiguration());
- }
-
- @Override
public boolean shouldReportPathPrefixConflict(ActionAnalysisMetadata action) {
return this != action;
}
