commit e96b0b88a5f9aa8cd816e3603b9179f040d79270
author Florian Weikert <fwe@google.com> Fri Sep 25 11:35:11 2015 +0000
committer Han-Wen Nienhuys <hanwen@google.com> Fri Sep 25 14:41:21 2015 +0000
tree 82af330b0cc3d012eeae1d6338277fbb674b2ba1
parent 61b0cced33159c0f0e03e5effbe4f4af1177c07d

Skylark rules can no longer overwrite built-in attributes.

--
MOS_MIGRATED_REVID=103931317

src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
index c7ea692..cce9b97 100644
--- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
@@ -66,6 +66,13 @@
         ")");
   }
 
+  public void testCannotOverrideBuiltInAttribute() throws Exception {
+    checkEvalError(
+        "There is already a built-in attribute 'tags' which cannot be overridden",
+        "def impl(ctx): return",
+        "r = rule(impl, attrs = {'tags': attr.string_list()})");
+  }
+
   public void testImplicitArgsAttribute() throws Exception {
     eval(
         "def _impl(ctx):",