Google Git
Sign in
bazel / bazel / eae93f643ccfe19df24bb1dd837c45056a15c274
commiteae93f643ccfe19df24bb1dd837c45056a15c274[log] [tgz]
authorJohn Millikin <john@john-millikin.com>Mon Nov 11 09:01:04 2019 -0800
committerCopybara-Service <copybara-worker@google.com>Mon Nov 11 09:01:47 2019 -0800
treee3463f24b99d789d899c5bce063cfc681cd94cb4
parent2e63b2a8a9e1dae04d8ccaf641d0e942dd2ad87e [diff]
Support non-ASCII source artifact paths on UNIX platforms.

Fixes https://github.com/bazelbuild/bazel/issues/7255, and mitigates some of the most annoying limitations of https://github.com/bazelbuild/bazel/issues/374.

Summary: On UNIX platforms, Bazel uses `readdir()` via `NativePosixFiles` but opens paths with `java.io.File`. These two libraries use different representations of non-ASCII filesystem paths, which prevents Bazel from reading source artifacts.

There is a workaround, because `java.io.File` can also accept the path as a `URI` with percent-encoded octets. Using this mechanism for paths containing characters outside the ASCII range allows Bazel to happily consume source artifacts with Unicode filenames.

cc @davispuh for https://github.com/bazelbuild/bazel/issues/7255
cc @aehlig for https://github.com/bazelbuild/bazel/issues/4555
cc @alandonovan who, per https://github.com/bazelbuild/bazel/issues/374#issuecomment-523120425, was working on a fix but ran into unknown difficulties.

Closes #10111.

PiperOrigin-RevId: 279747137
5 files changed
tree: e3463f24b99d789d899c5bce063cfc681cd94cb4
  1. .bazelci/
  2. examples/
  3. scripts/
  4. site/
  5. src/
  6. third_party/
  7. tools/
  8. .bazelrc
  9. .gitattributes
  10. .gitignore
  11. AUTHORS
  12. BUILD
  13. CHANGELOG.md
  14. CODEOWNERS
  15. combine_distfiles.py
  16. combine_distfiles_to_tar.sh
  17. compile.sh
  18. CONTRIBUTING.md
  19. CONTRIBUTORS
  20. distdir.bzl
  21. ISSUE_TEMPLATE.md
  22. LICENSE
  23. README.md
  24. WORKSPACE
README.md

Bazel

{Fast, Correct} - Choose two

Build and test software of any size, quickly and reliably.

  • Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.

  • One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.

  • Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.

  • Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.

Getting Started

Documentation

Contributing to Bazel

See CONTRIBUTING.md

Build status