fix obsolete error message about what the cfg parameter can take.
Called out by []
PiperOrigin-RevId: 334157269
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkAttrModule.java b/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkAttrModule.java
index e1d0909..9618721 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkAttrModule.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkAttrModule.java
@@ -250,8 +250,12 @@
}
builder.cfg(new StarlarkAttributeTransitionProvider(starlarkDefinedTransition));
} else if (!trans.equals("target")) {
- // TODO(b/121134880): update error message when starlark build configurations is ready.
- throw Starlark.errorf("cfg must be either 'host' or 'target'.");
+ // We don't actively advertise the hard-coded but exposed transitions like
+ // android_split_transition because users of those transitions should already know about
+ // them.
+ throw Starlark.errorf(
+ "cfg must be either 'host', 'target', 'exec' or a starlark defined transition defined"
+ + " by the exec() or transition() functions.");
}
}
diff --git a/src/test/java/com/google/devtools/build/lib/starlark/StarlarkRuleClassFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/starlark/StarlarkRuleClassFunctionsTest.java
index 199521f..8b104c7 100644
--- a/src/test/java/com/google/devtools/build/lib/starlark/StarlarkRuleClassFunctionsTest.java
+++ b/src/test/java/com/google/devtools/build/lib/starlark/StarlarkRuleClassFunctionsTest.java
@@ -625,7 +625,7 @@
public void incompatibleDataTransition() throws Exception {
EvalException expected =
assertThrows(EvalException.class, () -> ev.eval("attr.label(cfg = 'data')"));
- assertThat(expected).hasMessageThat().contains("cfg must be either 'host' or 'target'");
+ assertThat(expected).hasMessageThat().contains("cfg must be either 'host', 'target'");
}
@Test
