| commit | eedab27017723d818757d6be6f9f258529223c26 | [log] [tgz] |
|---|---|---|
| author | ajurkowski <ajurkowski@google.com> | Thu May 19 15:27:50 2022 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu May 19 15:29:10 2022 -0700 |
| tree | 974d90781a48ee9de2e0af19580df5d7e184000f | |
| parent | 4879106fabdf4af9395743941987d4297d232296 [diff] |
Remove injected metadata before rewriting the `.jdeps` file. `JavaCompileAction` rewrites the `.jdeps` files after running the spawn. In case of an executor which uses the [`MetadataInjector::injectFile`](https://github.com/bazelbuild/bazel/blob/5be114a2e4fb928a98f44327135c1046f361980b/src/main/java/com/google/devtools/build/lib/actions/cache/MetadataInjector.java#L35), the output store would already have the metadata. Consequently, when constructing the `ActionExecutionValue`, we would [pick up the metadata](https://github.com/bazelbuild/bazel/blob/5be114a2e4fb928a98f44327135c1046f361980b/src/main/java/com/google/devtools/build/lib/skyframe/ActionMetadataHandler.java#L275-L278) for the `.jdeps` file as it came from the execution as opposed to after the rewrite. One of the consequences of this is that when we rewrite the file with identical value, the `mtime` for the output would change. Consequently, `FilesystemValueChecker` deems the file as potentially modified and marks the corresponding action as dirty. Remove the output store entry for the `.jdeps` file before rewriting it to make sure we will not pick up a stale value. PiperOrigin-RevId: 449845853
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
