Google Git
Sign in
bazel / bazel / efdd3b270faaaf9bca6439da4fc177e97296c1bd
commitefdd3b270faaaf9bca6439da4fc177e97296c1bd[log] [tgz]
authorJosh Rosen <joshrosen@stripe.com>Fri May 10 02:02:37 2019 -0700
committerCopybara-Service <copybara-worker@google.com>Fri May 10 02:03:48 2019 -0700
treed1d3c83ed2da06531f2313963cb5b1a17b7335aa
parent77b565866fcb67a1d2f88ff7aa03773dd843e90b [diff]
Speed up construction of MANIFEST.MF lines in java_stub_template

This PR significantly improves the performance of constructing the classpath JAR `MANIFEST.MF` file in `java_stub_template`.

If the `CLASSPATH` is huge then significant time is spent wrapping the lines of the manifest to 72 characters. For example, if the classpath contains 400k characters then it takes nearly two minutes to generate the `MANIFEST.MF` file!

To speed this up, I changed the code to use the `fold` utility (instead of a `for` loop which indexes into a giant string). This is _much_ faster, processing a 400k character classpath in ~150ms (my microbenchmark code and results are at https://gist.github.com/joshrosen-stripe/96a467cd7847cef241772064ec902147)

`fold` is part of the POSIX spec so I believe that this solution will be portable.

Closes #8196.

PiperOrigin-RevId: 247575329
1 file changed
tree: d1d3c83ed2da06531f2313963cb5b1a17b7335aa
  1. .bazelci/
  2. examples/
  3. scripts/
  4. site/
  5. src/
  6. third_party/
  7. tools/
  8. .bazelrc
  9. .gitattributes
  10. .gitignore
  11. AUTHORS
  12. BUILD
  13. CHANGELOG.md
  14. CODEOWNERS
  15. combine_distfiles.py
  16. combine_distfiles_to_tar.sh
  17. compile.sh
  18. CONTRIBUTING.md
  19. CONTRIBUTORS
  20. distdir.bzl
  21. ISSUE_TEMPLATE.md
  22. LICENSE
  23. README.md
  24. WORKSPACE
README.md

Bazel

{Fast, Correct} - Choose two

Build and test software of any size, quickly and reliably.

  • Speed up your builds and tests: Bazel only rebuilds what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.

  • One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.

  • Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.

  • Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.

Getting Started

Documentation

Contributing to Bazel

See CONTRIBUTING.md

Build status

Bazel is released in ‘Beta’. See the product roadmap to learn about the path toward a stable 1.0 release.