commit f049cde7e9165570642eaa1c89a8aa6e5ab1894a
author Loo Rong Jie <loorongjie@gmail.com> Fri Jan 26 06:29:32 2018 -0800
committer Copybara-Service <copybara-piper@google.com> Fri Jan 26 06:30:55 2018 -0800
tree 970c0cd5a1a6139df5048a127fe2e7e34571f870
parent be2d8f261d2a2d045f45e98d3d89e22961206b6e

Remove dead ConvertPathList

Closes #4494.

PiperOrigin-RevId: 183380779

src/main/cpp/blaze_util_platform.h

diff --git a/src/main/cpp/blaze_util_platform.h b/src/main/cpp/blaze_util_platform.h
index 87a0d9a..80b95e1 100644
--- a/src/main/cpp/blaze_util_platform.h
+++ b/src/main/cpp/blaze_util_platform.h
@@ -124,12 +124,6 @@
 // is Windows path.
 std::string ConvertPath(const std::string& path);
 
-// Convert a path list from Bazel internal form to underlying OS form.
-// On Unixes this is an identity operation.
-// On Windows, Bazel internal form is cygwin path list, and underlying OS form
-// is Windows path list.
-std::string ConvertPathList(const std::string& path_list);
-
 // Converts `path` to a string that's safe to pass as path in a JVM flag.
 // See https://github.com/bazelbuild/bazel/issues/2576
 std::string PathAsJvmFlag(const std::string& path);

src/main/cpp/blaze_util_posix.cc

diff --git a/src/main/cpp/blaze_util_posix.cc b/src/main/cpp/blaze_util_posix.cc
index db0beca..967fde6 100644
--- a/src/main/cpp/blaze_util_posix.cc
+++ b/src/main/cpp/blaze_util_posix.cc
@@ -184,8 +184,6 @@
 
 std::string ConvertPath(const std::string &path) { return path; }
 
-std::string ConvertPathList(const std::string& path_list) { return path_list; }
-
 std::string PathAsJvmFlag(const std::string& path) { return path; }
 
 const char kListSeparator = ':';

src/main/cpp/blaze_util_windows.cc

diff --git a/src/main/cpp/blaze_util_windows.cc b/src/main/cpp/blaze_util_windows.cc
index e18e3db..56e510b 100644
--- a/src/main/cpp/blaze_util_windows.cc
+++ b/src/main/cpp/blaze_util_windows.cc
@@ -727,11 +727,6 @@
                     .get());
 }
 
-// Convert a Unix path list to Windows path list
-string ConvertPathList(const string& path_list) {
-  return path_list;
-}
-
 bool SymlinkDirectories(const string &posix_target, const string &posix_name) {
   wstring name;
   wstring target;

src/main/cpp/option_processor.cc

diff --git a/src/main/cpp/option_processor.cc b/src/main/cpp/option_processor.cc
index 4a6e579..89fcf2b 100644
--- a/src/main/cpp/option_processor.cc
+++ b/src/main/cpp/option_processor.cc
@@ -480,7 +480,7 @@
   if (pos == string::npos) return;
   string name = env_str->substr(0, pos);
   if (name == "PATH") {
-    env_str->assign("PATH=" + ConvertPathList(env_str->substr(pos + 1)));
+    env_str->assign("PATH=" + env_str->substr(pos + 1));
   } else if (name == "TMP") {
     // A valid Windows path "c:/foo" is also a valid Unix path list of
     // ["c", "/foo"] so must use ConvertPath here. See GitHub issue #1684.