commit f188dc23bff5edbe4c7b8f43cc66a8f1d07ba07b
author Dmitry Lomov <dslomov@google.com> Tue Jul 19 09:00:55 2016 +0000
committer Dmitry Lomov <dslomov@google.com> Tue Jul 19 18:11:29 2016 +0000
tree 741196bcbcd627be7f4e38a94aff1dd6445004b7
parent 25e5995fc418a6430c822f71ac0e0418dfc1f34a

Prohibit duplicate addition of aspect to an attribute and improve diagnostics.

--
MOS_MIGRATED_REVID=127808009

src/main/java/com/google/devtools/build/lib/rules/SkylarkAttr.java

diff --git a/src/main/java/com/google/devtools/build/lib/rules/SkylarkAttr.java b/src/main/java/com/google/devtools/build/lib/rules/SkylarkAttr.java
index 848cdcc..7256393 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/SkylarkAttr.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/SkylarkAttr.java
@@ -1247,7 +1247,7 @@
           throw new EvalException(definitionLocation,
               "All aspects applied to rule dependencies must be top-level values");
         }
-        attributeBuilder.aspect(skylarkAspect);
+        attributeBuilder.aspect(skylarkAspect, definitionLocation);
       }
       exported = true;
     }