commit f2049548b0727326b84d7e26e09129346149ffba
author Jakob Buchgraber <buchgr@google.com> Mon Aug 27 01:58:41 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Mon Aug 27 02:00:08 2018 -0700
tree b6b404e03c99738ced383ac54e897933e3241591
parent 3c5e7c78489ecc21c778abe75cb0cdcbb1eec12b

hide warning on macOS if no JDK is installed

On macOS Bazel calls /usr/libexec/java_home to detect the
system jdk (if any). This tool prints a warning if no system
jdk is installed:

> Unable to find any JVMs matching version "1.7+".
> No Java runtime present, try --request to install.

This patch hides this warning as Bazel ships with an embedded
JDK and does not require a system JDK installed. Additionally,
pump the version requirement to 1.8+ as this is the oldest JDK
version that Bazel can build for.

Closes #5992.

PiperOrigin-RevId: 210333991

src/main/cpp/blaze_util_darwin.cc

diff --git a/src/main/cpp/blaze_util_darwin.cc b/src/main/cpp/blaze_util_darwin.cc
index c925e2e..456e851 100644
--- a/src/main/cpp/blaze_util_darwin.cc
+++ b/src/main/cpp/blaze_util_darwin.cc
@@ -165,7 +165,8 @@
     return java_home;
   }
 
-  FILE *output = popen("/usr/libexec/java_home -v 1.7+", "r");
+  // java_home will print a warning if no JDK could be found
+  FILE *output = popen("/usr/libexec/java_home -v 1.8+ 2> /dev/null", "r");
   if (output == NULL) {
     return "";
   }