| commit | f47fd83ad044bb786883662380e4cf1f53c3cc63 | [log] [tgz] |
|---|---|---|
| author | Klaus Aehlig <aehlig@google.com> | Fri Jul 01 13:58:09 2016 +0000 |
| committer | Lukacs Berki <lberki@google.com> | Mon Jul 04 07:17:47 2016 +0000 |
| tree | 81b41d7c1fb8c614910d73009820834e45a75b3f | |
| parent | cc0180041dd1ef801b35ba28c1d34f19ffe22c95 [diff] |
buildenv.sh: clean up each tmpdir once
...instead of cleaning up the last one once for each tmpdir.
Commit 63e8d6321 changed the command registered atexit from
an explict "rm -rf '${DIR}'" to a call to a cleanup_tempdir
function, with the function containing the remove command.
As, however, the function name is not unique (in fact, it is
a constant), that function will get overridden at each invocation
of the tempdir function. The fact that the function is registered
several times with atexit doesn't help, as it will always remove
the last created temporary directory. Fix this, by creating function
names that encode the directory to be removed in the name. Fixes #1466.
--
Change-Id: I833aef8ee5423412f058e74c8c9e2f4bb53a0cba
Reviewed-on: https://bazel-review.googlesource.com/#/c/3955
MOS_MIGRATED_REVID=126406196
{Fast, Correct} - Choose two
Bazel is a build tool that builds code quickly and reliably. It is used to build the majority of Google‘s software, and thus it has been designed to handle build problems present in Google’s development environment, including:
A massive, shared code repository, in which all software is built from source. Bazel has been built for speed, using both caching and parallelism to achieve this. Bazel is critical to Google's ability to continue to scale its software development practices as the company grows.
An emphasis on automated testing and releases. Bazel has been built for correctness and reproducibility, meaning that a build performed on a continuous build machine or in a release pipeline will generate bitwise-identical outputs to those generated on a developer's machine.
Language and platform diversity. Bazel's architecture is general enough to support many different programming languages within Google, and can be used to build both client and server software targeting multiple architectures from the same underlying codebase.
Find more background about Bazel in our FAQ.