| commit | f54de41c15f1b7a9b0a902d31f1cce9cf7722cd4 | [log] [tgz] |
|---|---|---|
| author | buchgr <buchgr@google.com> | Wed Apr 24 02:02:28 2019 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Apr 24 02:03:54 2019 -0700 |
| tree | 1f872e06f3f1cbba087527ea896ffcdee15173d4 | |
| parent | b9f0802dfdb310517ef89577da3a9fd599047b33 [diff] |
Fix flakiness of ByteStreamUploaderTest#failedUploadsShouldNotDeduplicate The ByteStreamUploader has logic to internally deduplicate uploads. The test first triggers an upload that fails followed by an identical upload that succeeds. It asserts that the failed upload is not cached so that the subsequent upload is actually performed. For a given file the logic for state transition of "being uploaded" to "uploaded/failed" is done in a listener of the upload future. This listener is executed *after* the future completes (i.e. after get()/isDone() returns true) and thus there would be a race between the second upload starting and the above mentioned state transition being executed. If the race was lost it would look to the second upload as if the first hadn't completed yet. The fix is to introduce a future that only completes after the internal state tracking has been done. RELNOTES: None PiperOrigin-RevId: 245006516
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel only rebuilds what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
Bazel is released in ‘Beta’. See the product roadmap to learn about the path toward a stable 1.0 release.