commit f6316bf122ff09753c3bfb7e48faae855731091f
author brandjon <brandjon@google.com> Wed Aug 02 16:42:56 2017 +0200
committer Dmitry Lomov <dslomov@google.com> Thu Aug 03 12:08:39 2017 +0200
tree 483ba119a146eea8444fd7144335a334944c4f58
parent 98dbe037d7b6f2e815af1036373717e28d950698

Cleanup javadoc around Mutability / SkylarkMutable

Also throw IllegalArgumentException instead of AssertionError.

A follow-up CL will look to eliminate the SkylarkMutable#checkMutable(Location, Environment) override in favor of checkMutable(Location, Mutability). This will make it easier to manipulate Skylark values in specialized contexts aside from normal evaluation.

RELNOTES: None
PiperOrigin-RevId: 163978262

src/main/java/com/google/devtools/build/lib/syntax/Environment.java

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/Environment.java b/src/main/java/com/google/devtools/build/lib/syntax/Environment.java
index 4bec1c6..0ae54ff 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/Environment.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/Environment.java
@@ -238,7 +238,7 @@
      */
     public void put(Environment env, String varname, Object value)
         throws MutabilityException {
-      Mutability.checkMutable(this, env);
+      Mutability.checkMutable(this, env.mutability());
       bindings.put(varname, value);
     }
 
@@ -247,7 +247,7 @@
      * be part of the public interface.
      */
     void remove(Environment env, String varname) throws MutabilityException {
-      Mutability.checkMutable(this, env);
+      Mutability.checkMutable(this, env.mutability());
       bindings.remove(varname);
     }