commit f6350625c07fa8d9b5ec85439e44150ad7ac8b23
author laurentlb <laurentlb@google.com> Wed Sep 19 10:15:34 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Wed Sep 19 10:17:19 2018 -0700
tree 01cb916518cfab1037737f09e31fc731f2515685
parent baf7c1ff1a903d209c30989a21d18f9cbe8a9093

Cleaner separatation between Module and Universe variables.

- In the global frame, rename "parent" into "universe" to clarify what it is.
- Function `moduleLookup` now does the right thing. It doesn't check the universe anymore.

This means that we now forbid (with --incompatible_static_name_resolution) this:
  a = len("abc")
  len = 2

#5827

RELNOTES: None.
PiperOrigin-RevId: 213647873

src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java b/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
index 810aaa2..3dae2bc 100644
--- a/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
+++ b/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
@@ -1839,7 +1839,16 @@
 
   @Test
   public void testShadowBuiltin() throws Exception {
-    // TODO(laurentlb): Forbid this.
+    new SkylarkTest("--incompatible_static_name_resolution=true")
+        .testIfErrorContains(
+            "global variable 'len' is referenced before assignment",
+            "x = len('abc')",
+            "len = 2",
+            "y = x + len");
+  }
+
+  @Test
+  public void testLegacyShadowBuiltin() throws Exception {
     new SkylarkTest("--incompatible_static_name_resolution=false")
         .setUp("x = len('abc')", "len = 2", "y = x + len")
         .testLookup("y", 5);