commit f77ced70a0cf6fef78ade47aac57a3ba1ed8daa7
author twigg <twigg@google.com> Tue Sep 01 16:44:53 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Sep 01 16:45:50 2020 -0700
tree 99e7db691fd262241819b6bdbcd31bad82e0a53d
parent 96898592c13228b6788ca6f289e291e709c60a2a

Cache the invocation of TestTrimmingTransition.applyTransition.

This implementation uses the pre-existing BuildOptionsCache class inside TestTrimmingTransition to resolve the performance issue with --trim_test_configuration on longwide. (Previous attempts used a SkyFunction, a custom cache at ConfigurationResolve, or a custom cache at TestTrimmingTransition.)

PiperOrigin-RevId: 329607319

src/main/java/com/google/devtools/build/lib/analysis/BUILD

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/BUILD b/src/main/java/com/google/devtools/build/lib/analysis/BUILD
index 1a26394..f367071 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/BUILD
+++ b/src/main/java/com/google/devtools/build/lib/analysis/BUILD
@@ -2270,6 +2270,7 @@
     srcs = ["test/TestTrimmingTransitionFactory.java"],
     deps = [
         ":config/build_options",
+        ":config/build_options_cache",
         ":config/fragment_options",
         ":config/transitions/no_transition",
         ":config/transitions/patch_transition",