commit f86ad5fe6b8b93ef8689e2eafff3674ce8b15142
author Dmitry Lomov <dslomov@google.com> Wed Apr 06 10:01:15 2016 +0000
committer Lukacs Berki <lberki@google.com> Thu Apr 07 11:44:15 2016 +0000
tree 55de4904f208af6e02e42664449b420f9cf68a89
parent 525fa71b0d6f096e9bfb180f688a4418c4974eb4

Remove Aspect field from AspectKey.

--
MOS_MIGRATED_REVID=119141878

src/main/java/com/google/devtools/build/lib/skyframe/AspectValue.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/AspectValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/AspectValue.java
index 83a8a71..effd33f 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/AspectValue.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/AspectValue.java
@@ -51,7 +51,8 @@
     private final Label label;
     private final BuildConfiguration aspectConfiguration;
     private final BuildConfiguration baseConfiguration;
-    private final Aspect aspect;
+    private final AspectClass aspectClass;
+    private final AspectParameters parameters;
 
     protected AspectKey(
         Label label,
@@ -62,7 +63,8 @@
       this.label = label;
       this.aspectConfiguration = aspectConfiguration;
       this.baseConfiguration = baseConfiguration;
-      this.aspect = new Aspect(aspectClass, parameters);
+      this.aspectClass = aspectClass;
+      this.parameters = parameters;
     }
 
     @Override
@@ -77,17 +79,17 @@
     }
 
     public AspectClass getAspectClass() {
-      return aspect.getAspectClass();
+      return aspectClass;
     }
 
     @Nullable
     public AspectParameters getParameters() {
-      return aspect.getParameters();
+      return parameters;
     }
 
     @Override
     public String getDescription() {
-      return String.format("%s of %s", aspect.getAspectClass().getName(), getLabel());
+      return String.format("%s of %s", aspectClass.getName(), getLabel());
     }
 
     /**
@@ -128,7 +130,12 @@
 
     @Override
     public int hashCode() {
-      return Objects.hashCode(label, aspectConfiguration, baseConfiguration, aspect);
+      return Objects.hashCode(
+          label,
+          aspectConfiguration,
+          baseConfiguration,
+          aspectClass,
+          parameters);
     }
 
     @Override
@@ -145,20 +152,21 @@
       return Objects.equal(label, that.label)
           && Objects.equal(aspectConfiguration, that.aspectConfiguration)
           && Objects.equal(baseConfiguration, that.baseConfiguration)
-          && Objects.equal(aspect, that.aspect);
+          && Objects.equal(aspectClass, that.aspectClass)
+          && Objects.equal(parameters, that.parameters);
     }
 
     @Override
     public String toString() {
       return label
           + "#"
-          + aspect.getAspectClass().getName()
+          + aspectClass.getName()
           + " "
           + (aspectConfiguration == null ? "null" : aspectConfiguration.checksum())
           + " "
           + (baseConfiguration == null ? "null" : baseConfiguration.checksum())
           + " "
-          + aspect.getParameters();
+          + parameters;
     }
   }