commit f9c82e0282ffc0d16b53520c5072b0b15e0a582e
author djasper <djasper@google.com> Mon Mar 04 11:02:10 2019 -0800
committer Copybara-Service <copybara-worker@google.com> Mon Mar 04 11:03:42 2019 -0800
tree e41f6f7ae25a87e0cbe5fdec85c9ebfc84556f0c
parent 1b869120184558fa5c5168f74b8d56c934af3f71

Create less garbage for the common case of not having any aspects.

RELNOTES: None.
PiperOrigin-RevId: 236686052

src/main/java/com/google/devtools/build/lib/analysis/DependencyResolver.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/DependencyResolver.java b/src/main/java/com/google/devtools/build/lib/analysis/DependencyResolver.java
index 8d1df1f..cbf9fc9 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/DependencyResolver.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/DependencyResolver.java
@@ -631,9 +631,9 @@
    * Filter the set of aspects that are to be propagated according to the set of advertised
    * providers of the dependency.
    */
-  private AspectCollection filterPropagatingAspects(Iterable<Aspect> aspects, Target toTarget)
+  private AspectCollection filterPropagatingAspects(ImmutableList<Aspect> aspects, Target toTarget)
       throws InconsistentAspectOrderException {
-    if (!(toTarget instanceof Rule)) {
+    if (!(toTarget instanceof Rule) || aspects.isEmpty()) {
       return AspectCollection.EMPTY;
     }