| commit | fa654b4878974e591d7e0bea3fa233c6b120395b | [log] [tgz] |
|---|---|---|
| author | laurentlb <laurentlb@google.com> | Tue May 28 10:52:31 2019 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue May 28 10:53:41 2019 -0700 |
| tree | f22f7e577b43a199c50cbd24d9d853a1e6801bcf | |
| parent | 71aad07c3ea2c22086ce6416ce3fc9d8cfb94031 [diff] |
Flip the flag --incompatible_no_kwargs_in_build_files Fixes https://github.com/bazelbuild/bazel/issues/8021 RELNOTES: --incompatible_no_kwargs_in_build_files is enabled by default PiperOrigin-RevId: 250317931
diff --git a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java b/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java index 2a64d89..143904c 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java +++ b/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java
@@ -494,7 +494,7 @@ @Option( name = "incompatible_no_kwargs_in_build_files", - defaultValue = "false", + defaultValue = "true", documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS, effectTags = {OptionEffectTag.BUILD_FILE_SEMANTICS}, metadataTags = {
diff --git a/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java b/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java index 55b2234..eb6b549 100644 --- a/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java +++ b/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java
@@ -246,7 +246,7 @@ .incompatibleExpandDirectories(true) .incompatibleNewActionsApi(true) .incompatibleNoAttrLicense(true) - .incompatibleNoKwargsInBuildFiles(false) + .incompatibleNoKwargsInBuildFiles(true) .incompatibleNoOutputAttrDefault(true) .incompatibleNoSupportToolsInActionInputs(false) .incompatibleNoTargetOutputGroup(false)