commit fa9b01efdb1b444fc1a7f3f850c836dd84c74fce
author nharmata <nharmata@google.com> Mon Nov 27 08:16:38 2017 -0800
committer Copybara-Service <copybara-piper@google.com> Mon Nov 27 08:18:35 2017 -0800
tree b3d0a005c51abe4cd848560a1c2204da8b570b71
parent 0dd27ab4506baced80d0cd6d135934e363598437

Fix bug in SkyQuery's 'rbuildfiles' implementation where we were incorrectly using FileValue, rather than FileStateValue, nodes as the roots of the rdep traversal.

This is incorrect e.g. when a .bzl file is a target of a symlink that is load'd from a BUILD file.

RELNOTES: None
PiperOrigin-RevId: 177018264

src/main/java/com/google/devtools/build/lib/query2/ParallelSkyQueryUtils.java

diff --git a/src/main/java/com/google/devtools/build/lib/query2/ParallelSkyQueryUtils.java b/src/main/java/com/google/devtools/build/lib/query2/ParallelSkyQueryUtils.java
index 1948cb0..57485d9 100644
--- a/src/main/java/com/google/devtools/build/lib/query2/ParallelSkyQueryUtils.java
+++ b/src/main/java/com/google/devtools/build/lib/query2/ParallelSkyQueryUtils.java
@@ -87,7 +87,7 @@
     Uniquifier<SkyKey> keyUniquifier = env.createSkyKeyUniquifier();
     RBuildFilesVisitor visitor =
         new RBuildFilesVisitor(env, keyUniquifier, callback);
-    visitor.visitAndWaitForCompletion(env.getSkyKeysForFileFragments(fileIdentifiers));
+    visitor.visitAndWaitForCompletion(env.getFileStateKeysForFileFragments(fileIdentifiers));
   }
 
   /** A helper class that computes 'rbuildfiles(<blah>)' via BFS. */