commit faf7841c632256b9408042edc4946642507eb634
author Laurent Le Brun <laurentlb@google.com> Tue Jul 28 16:13:00 2015 +0000
committer Lukacs Berki <lberki@google.com> Wed Jul 29 16:00:01 2015 +0000
tree 84ffb3c494b52ba5a1a93220cc0f6b87803a8827
parent fa15d3983b4616516c350bb633335d2f27b9a674

Skylark documentation fixes

--
MOS_MIGRATED_REVID=99283744

src/main/java/com/google/devtools/build/lib/rules/SkylarkAttr.java

diff --git a/src/main/java/com/google/devtools/build/lib/rules/SkylarkAttr.java b/src/main/java/com/google/devtools/build/lib/rules/SkylarkAttr.java
index f465af1..fc85bb1 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/SkylarkAttr.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/SkylarkAttr.java
@@ -55,7 +55,7 @@
   onlyLoadingPhase = true,
   doc =
       "Module for creating new attributes. "
-          + "They are only for use with the <code>rule</code> function."
+          + "They are only for use with the <a href=\"#modules._top_level.rule\">rule</a> function."
 )
 public final class SkylarkAttr {
 
@@ -75,11 +75,11 @@
       "configuration of the attribute. " + "For example, use DATA_CFG or HOST_CFG.";
 
   private static final String DEFAULT_ARG = "default";
-  private static final String DEFAULT_DOC = "sets the default value of the attribute.";
+  private static final String DEFAULT_DOC = "the default value of the attribute.";
 
   private static final String EXECUTABLE_ARG = "executable";
   private static final String EXECUTABLE_DOC =
-      "set to True if the labels have to be executable. This means the label must refer to an "
+      "True if the labels have to be executable. This means the label must refer to an "
           + "executable file, or to a rule that outputs an executable file. Access the labels "
           + "with <code>ctx.executable.&lt;attribute_name&gt;</code>.";
 
@@ -87,11 +87,10 @@
   private static final String FLAGS_DOC = "deprecated, will be removed";
 
   private static final String MANDATORY_ARG = "mandatory";
-  private static final String MANDATORY_DOC =
-      "set to True if users have to explicitely specify the value";
+  private static final String MANDATORY_DOC = "True if the value must be explicitly specified";
 
   private static final String NON_EMPTY_ARG = "non_empty";
-  private static final String NON_EMPTY_DOC = "set to True if the attribute must not be empty";
+  private static final String NON_EMPTY_DOC = "True if the attribute must not be empty";
 
   private static final String PROVIDERS_ARG = "providers";
 
@@ -99,7 +98,7 @@
 
   private static final String VALUES_ARG = "values";
   private static final String VALUES_DOC =
-      "specify the list of allowed values for the attribute. An error is raised if any other "
+      "the list of allowed values for the attribute. An error is raised if any other "
           + "value is given.";
 
   private static boolean containsNonNoneKey(Map<String, Object> arguments, String key) {