| commit | fcf9dd50e27a1f77e1c30dfedaabc6118319e5e1 | [log] [tgz] |
|---|---|---|
| author | adgar <adgar@google.com> | Tue Mar 09 09:04:47 2021 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Mar 09 09:06:00 2021 -0800 |
| tree | 4e64db8704727b607aed6ce03c1266e4a6f6a4f5 | |
| parent | a1c8a44de593ca4690f77d0ddfbc6912c5f2dc61 [diff] |
Ensure NamedSetOfFiles BEP event appears before event referencing the file_set. Previously, when a `NestedSet<Artifact>` is referenced by multiple BuildEvents (perhaps transitively) there is a race in `BuildEventStreamer`, which receives all BuildEvents in an `@AllowConcurrentEvents` EventBus handler. If the BuildEvents are posted by different threads, the first will acquire the name for the `NamedSetOfFiles` and prepare the protobuf message from the NestedSet. In the meantime, the second thread will see the NestedSet's name was already acquired and may proceed to write its BuildEvent referencing the `named_set`. This leads to a violation of the expected ordering. Note that the ordering expectation here cannot be guaranteed by parent-child event relationships, as a given `NamedSetOfFiles` cannot 'know' all of the events that will reference it in advance. This is why `NamedSetOfFiles` events are children of `Progress` events. RELNOTES: Users consuming BEP may assume that a `named_set_of_files` event will appear before any event referencing that `named_set` by ID. This allows consumers to process the files for such events (eg. `TargetCompleted`) immediately. PiperOrigin-RevId: 361822335
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
