commit fdfa9884b686727351b5d90e3eeb76f897af818a
author Vladimir Moskva <vladmos@google.com> Fri Nov 18 16:24:20 2016 +0000
committer Dmitry Lomov <dslomov@google.com> Mon Nov 21 19:35:26 2016 +0000
tree 7a2c5c8617319efd6aeafde01f8ce4a8075d1c75
parent b4c4bce600e64997c971099723c9692b9c65c0af

Implement structural equality for structs

RELNOTES: Structs in Skylark are tested for structural equality instead of reference equality.

--
MOS_MIGRATED_REVID=139583726

src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
index 3f2118d..7bc8bcb 100644
--- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
@@ -792,6 +792,26 @@
   }
 
   @Test
+  public void testStructEquality() throws Exception {
+    assertTrue((Boolean) eval("struct(a = 1, b = 2) == struct(b = 2, a = 1)"));
+    assertFalse((Boolean) eval("struct(a = 1) == struct(a = 1, b = 2)"));
+    assertFalse((Boolean) eval("struct(a = 1, b = 2) == struct(a = 1)"));
+    // Compare a recursive object to itself to make sure reference equality is checked
+    assertTrue((Boolean) eval("s = (struct(a = 1, b = [])); s.b.append(s); s == s"));
+    assertFalse((Boolean) eval("struct(a = 1, b = 2) == struct(a = 1, b = 3)"));
+    assertFalse((Boolean) eval("struct(a = 1) == [1]"));
+    assertFalse((Boolean) eval("[1] == struct(a = 1)"));
+    assertTrue((Boolean) eval("struct() == struct()"));
+    assertFalse((Boolean) eval("struct() == struct(a = 1)"));
+
+    eval("foo = provider(); bar = provider()");
+    assertFalse((Boolean) eval("struct(a = 1) == foo(a = 1)"));
+    assertFalse((Boolean) eval("foo(a = 1) == struct(a = 1)"));
+    assertFalse((Boolean) eval("foo(a = 1) == bar(a = 1)"));
+    assertTrue((Boolean) eval("foo(a = 1) == foo(a = 1)"));
+  }
+
+  @Test
   public void testStructAccessingFieldsFromSkylark() throws Exception {
     eval("x = struct(a = 1, b = 2)", "x1 = x.a", "x2 = x.b");
     assertThat(lookup("x1")).isEqualTo(1);