| commit | fe544aabfd735dcf8a0906258bd33bc9443a679f | [log] [tgz] |
|---|---|---|
| author | Googler <noreply@google.com> | Tue Dec 03 14:05:06 2019 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Dec 03 14:06:24 2019 -0800 |
| tree | f004fc2afe9b187ed200ac61e861eae6a191e546 | |
| parent | 6720ff31ba45b6225993cf7a0ccf50ad2001f0e9 [diff] |
bazel syntax: simplify StarlarkThread call stack
This change slightly simplifies the stack maintained by StarlarkThread,
and signposts the next steps.
StarlarkThread.Continuation
- rename it to CallFrame
- turn it from linked list into an ArrayList
- clarify but retain its current mostly off-by-one semantics for now
- replace FuncallExpression by just Location
- rename {enter,exit}Scope to push/pop and simplify
- simplify debugger operations in terms of call stack depth
Also:
- rename StarlarkFunction.getDefinitionGlobals -> getModule
- move dummy LexicalFrame for builtins to StarlarkThread.
- move calls to thread.push outside the try block, so we
so don't unintentionally suppress crashes.
Originally reviewed as CL 283349613 but split out.
PiperOrigin-RevId: 283617971
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
