commit ffb65c8a82004eafb9cf9c7b1df6c8eba8cbb441
author jcater <jcater@google.com> Fri Mar 29 07:52:16 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Mar 29 07:53:48 2019 -0700
tree c3d8e0883b46686d04721b5ec99d310e5f826392
parent d52ec8536d8448f2f84557d6816fe5e7e5e9f9bf

Update all attributes which use the host transition to use the host transition
factory.

This will help ensure that calls to TransitionFactory.isHost will always be
correct.

Part of #7814.

PiperOrigin-RevId: 240977747

src/test/java/com/google/devtools/build/lib/packages/AttributeTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/packages/AttributeTest.java b/src/test/java/com/google/devtools/build/lib/packages/AttributeTest.java
index 2211e573..b0320d2 100644
--- a/src/test/java/com/google/devtools/build/lib/packages/AttributeTest.java
+++ b/src/test/java/com/google/devtools/build/lib/packages/AttributeTest.java
@@ -98,10 +98,12 @@
 
   @Test
   public void testDoublePropertySet() {
-    Attribute.Builder<String> builder = attr("x", STRING).mandatory()
-        .cfg(HostTransition.INSTANCE)
-        .undocumented("")
-        .value("y");
+    Attribute.Builder<String> builder =
+        attr("x", STRING)
+            .mandatory()
+            .cfg(HostTransition.createFactory())
+            .undocumented("")
+            .value("y");
     try {
       builder.mandatory();
       fail();
@@ -109,7 +111,7 @@
       // expected
     }
     try {
-      builder.cfg(HostTransition.INSTANCE);
+      builder.cfg(HostTransition.createFactory());
       fail();
     } catch (IllegalStateException expected) {
       // expected
@@ -298,7 +300,8 @@
 
   @Test
   public void testHostTransition() throws Exception {
-    Attribute attr = attr("foo", LABEL).cfg(HostTransition.INSTANCE).allowedFileTypes().build();
+    Attribute attr =
+        attr("foo", LABEL).cfg(HostTransition.createFactory()).allowedFileTypes().build();
     assertThat(attr.hasHostConfigurationTransition()).isTrue();
     assertThat(attr.hasSplitConfigurationTransition()).isFalse();
   }