Call `resetDiscoveredInputs()` on `unused_inputs_list` actions to free the flattened set of used inputs.

The flat `NestedSet` of used inputs is memory-inefficient because the original `NestedSet` structure is lost. Note that this change does not save memory on builds with `--notrack_incremental_state` or `--nokeep_state_after_build` because those already call `resetDiscoveredInputs()`.

In the new implementation:

* New method `Action#prunedInputs` communicates whether the action detected unused inputs.
* `resetDiscoveredInputs()` is called after execution to return the action to a pre-input-discovery state.

Other changes:

* The map of inputs in `EnhancedStarlarkAction#afterExecute` is initialized lazily to reduce garbage when there are no unused inputs.
* `ActionCacheAwareAction` is no longer necessary because `prunedInputs()` tells `ActionCacheChecker` to store all inputs' exec paths in the action cache.
* `ActionExecutionFunction` calls `prunedInputs()` to determine whether to request action inputs up front or wait until input discovery[*]. Actions that pruned inputs can get an action cache hit without requesting unused inputs.
* `addDiscoveredInputs()` uses `ActionInputMapHelper` to handle aggregation artifacts, which can now be "discovered" (when we avoid requesting the inputs up front). This is cleaner anyway.

The only behavior change is that `aquery --noinclude_pruned_inputs` still reports unused inputs, even after a build. This seems like an acceptable compromise for the memory savings.

[*]The initial execution of the action always requests the full set of inputs up front in order to take advantage of `ArtifactNestedSetKey` dependency structure. Discovered inputs are always requested directly, not via `ArtifactNestedSetKey` (although I don't know of a fundamental reason why).

PiperOrigin-RevId: 858177876
Change-Id: I72a952e70c7afe8341185304434f1424c827ca05
12 files changed
tree: 4229f61bd6d1ebf2d1f2dffb77f72cbce43ffbd2
  1. .bazelci/
  2. .devcontainer/
  3. .gemini/
  4. .github/
  5. docs/
  6. examples/
  7. scripts/
  8. site/
  9. src/
  10. third_party/
  11. tools/
  12. .bazelrc
  13. .bazelversion
  14. .gitattributes
  15. .gitignore
  16. AUTHORS
  17. bazel_downloader.cfg
  18. BUILD
  19. CHANGELOG.md
  20. CODE_OF_CONDUCT.md
  21. CODEOWNERS
  22. combine_distfiles.py
  23. combine_distfiles_to_tar.sh
  24. compile.sh
  25. CONTRIBUTING.md
  26. CONTRIBUTORS
  27. distdir.bzl
  28. extensions.bzl
  29. LICENSE
  30. maven_install.json
  31. MODULE.bazel
  32. MODULE.bazel.lock
  33. pyproject.toml
  34. README.md
  35. repositories.bzl
  36. requirements.txt
  37. SECURITY.md
README.md

Bazel

{Fast, Correct} - Choose two

Build and test software of any size, quickly and reliably.

  • Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.

  • One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.

  • Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.

  • Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.

Getting Started

Documentation

Reporting a Vulnerability

To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.

Contributing to Bazel

See CONTRIBUTING.md

Build status