| commit | e74d941892dcd7c3914934923b7a737d816b15a1 | [log] [tgz] |
|---|---|---|
| author | Googler <lberki@google.com> | Mon May 12 10:28:54 2025 -0700 |
| committer | carmenchui@google.com <carmenchui@google.com> | Thu May 15 15:20:22 2025 +0000 |
| tree | e546d752e3d3bbeafa250fe2bb2c1921a458aa08 | |
| parent | dac1074ec5120d5a22ea4dd444ebeec0d19e5f5b [diff] |
Memoize Skyframe lookups in SkyframeInputMetadataProvider. With action rewinding, Skyframe can "lose" SkyValues at any given time. The code is carefully laid out such that when action rewinding can happen, the *first* metadata request for a given input only ever happens through .getInputMetadataChecked() and this worked because ActionFileSystem memoized the lookups. SkyframeInputMetadataProvider did not do so, thus if an action was rewound after a given direct reverse dependency did the first lookup for one of its outputs but before a subsequent one for the same output, it ended up throwing a MissingDepExecException, which in turn got wrapped into an IllegalStateException by .getInputMetadata(). RELNOTES: None. PiperOrigin-RevId: 757819478 Change-Id: Icb7d34052011a3a860b5f9524d8e8c7b3be412b7
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
