[9.4.0] Don't release the repo contents cache lock that wasn't acquired (#31518) (#31674) ### Description `BazelRepositoryModule.afterCommand` only releases the shared lock of the local repo contents cache if the process holds it (`LocalRepoContentsCache#holdsSharedLock`), rather than whenever the cache is enabled. ### Motivation If `beforeCommand` rejected the cache path, e.g. because the output base lies inside it, it failed before acquiring the lock, and the release in `afterCommand` then crashed the server with an internal error (exit code 37) instead of reporting the rejection. Reported in https://github.com/bazelbuild/bazel/pull/31452#issuecomment-5971506616. Work towards #31456 ### Build API Changes No ### Release Notes RELNOTES: None Closes #31518 COPYBARA_INTEGRATE_REVIEW=https://github.com/bazelbuild/bazel/pull/31518 from fmeum:repo-contents-cache-lock-release 930b47a41d1cd32e7dee6c99ebd3db48c2bf335a PiperOrigin-RevId: 995832431 Change-Id: I9807199432d7d243b6e6bb0affda025ccec47f1c Commit https://github.com/bazelbuild/bazel/commit/b3dbbc117475f91cc4dbb255a72aa8f648cc02d8 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im> Co-authored-by: Ian (Hee) Cha <heec@google.com>
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
