| commit | 7f55cb768ae22352ac6599086e7cf6525a9565a5 | [log] [tgz] |
|---|---|---|
| author | jhorvitz <jhorvitz@google.com> | Thu Dec 16 18:52:24 2021 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Dec 16 18:53:48 2021 -0800 |
| tree | 9bbe91a979813abd8300ccf1ca467fa0d28c32ce | |
| parent | 1a42174021935c955e8c2474db86c6fa785b867a [diff] |
Let `SkyKey` alone declare its value's shareability. There are currently three methods for declaring shareability: * `SkyFunctionName#getShareabilityOfValue` * `SkyKey#getShareabilityOfValue` * `SkyValue#dataIsShareable` The former two are just "hints" - a return of `SOMETIMES` still requires checking the value. However, there is no enforcement of consistency - for example, we can have a particular `SkyFunctionName#getShareabilityOfValue` return `NEVER`, but that function may compute a value whose `SkyValue#dataIsShareable` returns `true`. This currently happens in practice. My original plan was to check consistency in `SerializationCheckingGraph`, but it turns out that it's not too difficult to just make `SkyKey` the sole proprietor of shareability. This is strictly better than giving the responsibility to `SkyValue` because a remote storage fetch for a value need not be attempted if the key is not shareable (this is what the "hint" in `SkyKey` intended to achieve). Replace `ShareabilityOfValue` with a simple boolean since the return of `SkyKey#valueIsShareable` is now definite. PiperOrigin-RevId: 416937942
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
