[8.4.1] Speculative fix for repo contents cache race (#26950)

The error message observed in #26713 is consistent with
`FileChannel#open` failing because the given path doesn't exist. This
could happen if one Bazel process observed that
`!entryDir.isDirectory()`, which is true if the path doesn't exist, and
proceeded to delete the path while another process had just created the
directory and is now opening the channel. Since the entry dir is never
expected to be an existing non-directory unless the cache has been
corrupted, this logic can be removed.

Another possible source of `IOException` during normal operation is on
an interrupt (such as the user hitting Ctrl+C). Instead, follow Skyframe
best practices by surfacing this as an `InterruptedException` instead of
a `FileLockInterruptionException`.

Also document that concurrent use on the same path is not supported (it
results in an `OverlappingFileLockException` if the lock is already
held, regardless of whether that is in shared or exclusive mode) and why
the current usages are safe.

Fixes #26713

Closes #26914.

PiperOrigin-RevId: 805338728
Change-Id: Ie808ebe6113b935180b93c21679d5398aa168802

Commit
https://github.com/bazelbuild/bazel/commit/ca1cbfece457915871cc1398a667422410b4c3fc

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
4 files changed
tree: b033c4254775014a800206257dbee3362d73626b
  1. .bazelci/
  2. .github/
  3. examples/
  4. scripts/
  5. site/
  6. src/
  7. third_party/
  8. tools/
  9. .bazelrc
  10. .bazelversion
  11. .gitattributes
  12. .gitignore
  13. AUTHORS
  14. bazel_downloader.cfg
  15. BUILD
  16. CHANGELOG.md
  17. CODE_OF_CONDUCT.md
  18. CODEOWNERS
  19. combine_distfiles.py
  20. combine_distfiles_to_tar.sh
  21. compile.sh
  22. CONTRIBUTING.md
  23. CONTRIBUTORS
  24. distdir.bzl
  25. extensions.bzl
  26. LICENSE
  27. maven_install.json
  28. MODULE.bazel
  29. MODULE.bazel.lock
  30. README.md
  31. repositories.bzl
  32. requirements.txt
  33. SECURITY.md
  34. workspace_deps.bzl
README.md

Bazel

{Fast, Correct} - Choose two

Build and test software of any size, quickly and reliably.

  • Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.

  • One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.

  • Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.

  • Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.

Getting Started

Documentation

Reporting a Vulnerability

To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.

Contributing to Bazel

See CONTRIBUTING.md

Build status