BCR presubmit: check task list is not empty (#1930)
Addressing
https://github.com/bazelbuild/bazel-central-registry/pull/1656#discussion_r1533558361
diff --git a/buildkite/bazel-central-registry/bcr_presubmit.py b/buildkite/bazel-central-registry/bcr_presubmit.py
index 3861181..7cc766d 100755
--- a/buildkite/bazel-central-registry/bcr_presubmit.py
+++ b/buildkite/bazel-central-registry/bcr_presubmit.py
@@ -482,12 +482,19 @@
bazelci.eprint("No target module versions detected in this branch!")
pipeline_steps = []
for module_name, module_version in modules:
+ previous_size = len(pipeline_steps)
+
configs = get_task_config(module_name, module_version)
add_presubmit_jobs(module_name, module_version, configs.get("tasks", {}), pipeline_steps)
configs = get_test_module_task_config(module_name, module_version)
add_presubmit_jobs(module_name, module_version, configs.get("tasks", {}), pipeline_steps, is_test_module=True)
+
+ if len(pipeline_steps) == previous_size:
+ error("No pipeline steps generated for %s@%s. Please check the configuration." % (module_name, module_version))
+
if should_wait_bcr_maintainer_review(modules) and pipeline_steps:
pipeline_steps = [{"block": "Wait on BCR maintainer review", "blocked_state": "running"}] + pipeline_steps
+
upload_jobs_to_pipeline(pipeline_steps)
elif args.subparsers_name == "runner":
repo_location = create_simple_repo(args.module_name, args.module_version)
