Change function name capitalization to match llvm style and fix clang-tidy finding. PiperOrigin-RevId: 820238684 Change-Id: I30248395fff6855c9c2e9e780af1ff7f2d81ffca
diff --git a/nullability/inference/collect_evidence_test.cc b/nullability/inference/collect_evidence_test.cc index 0f10b16..cfb8e76 100644 --- a/nullability/inference/collect_evidence_test.cc +++ b/nullability/inference/collect_evidence_test.cc
@@ -489,7 +489,7 @@ class CollectEvidenceFromDefinitionTest : public testing::TestWithParam<CollectionMode> { protected: - CollectionMode GetMode() const { return GetParam(); } + CollectionMode getMode() const { return GetParam(); } }; INSTANTIATE_TEST_SUITE_P( @@ -517,7 +517,7 @@ // 12345678901234567890123456 // 0 1 2 - auto Evidence = collectFromTargetFuncDefinition(Code, GetMode()); + auto Evidence = collectFromTargetFuncDefinition(Code, getMode()); ASSERT_THAT(Evidence, ElementsAre(evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE))); EXPECT_EQ("input.cc:1:23", Evidence.front().location()); @@ -529,7 +529,7 @@ // 123456789012345678901234567890123456789012 // 0 1 2 3 4 - auto Evidence = collectFromTargetFuncDefinition(Code, GetMode()); + auto Evidence = collectFromTargetFuncDefinition(Code, getMode()); ASSERT_THAT(Evidence, ElementsAre(evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE))); EXPECT_EQ("input.cc:2:39", Evidence.front().location()); @@ -539,14 +539,14 @@ static constexpr llvm::StringRef Src = R"cc( void target() {} )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, OneParamUnused) { static constexpr llvm::StringRef Src = R"cc( void target(int *P) {} )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, OneParamUsedWithoutRestriction) { @@ -555,7 +555,7 @@ void target(int *P) { takesUnknown(P); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Not(Contains(evidence(_, _, functionNamed("target"))))); } @@ -568,7 +568,7 @@ } } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE))); } @@ -584,7 +584,7 @@ B->y(); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE), evidence(paramSlot(1), Evidence::UNCHECKED_DEREFERENCE))); @@ -603,7 +603,7 @@ P->y(); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE), evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE), @@ -616,7 +616,7 @@ *P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, DereferenceBeforeAssignment) { @@ -628,7 +628,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), Contains(evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE))); } @@ -640,7 +640,7 @@ *P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Not(Contains(evidence(_, Evidence::UNCHECKED_DEREFERENCE)))); } @@ -656,7 +656,7 @@ *P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Not(Contains(evidence(_, Evidence::UNCHECKED_DEREFERENCE, functionNamed("target"))))); } @@ -670,7 +670,7 @@ } } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE))); } @@ -687,7 +687,7 @@ } } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE), evidence(paramSlot(1), Evidence::UNCHECKED_DEREFERENCE), @@ -707,7 +707,7 @@ int A = *P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE))); } @@ -721,7 +721,7 @@ } } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE))); } @@ -740,7 +740,7 @@ } } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE), evidence(Slot(0), Evidence::ASSIGNED_FROM_UNKNOWN, @@ -765,7 +765,7 @@ *A; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE), evidence(Slot(0), Evidence::ASSIGNED_FROM_NONNULL, @@ -785,7 +785,7 @@ } } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(1), Evidence::UNCHECKED_DEREFERENCE))); } @@ -799,7 +799,7 @@ int A = *P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, UnreachableCode) { @@ -819,7 +819,7 @@ int A = *P3; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE))); } @@ -837,7 +837,7 @@ // Pointers to members are not supported pointer types, so no evidence is // collected. If they become a supported pointer type, this test should start // failing. - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, PointerToMemberMethod) { @@ -854,7 +854,7 @@ // Pointers to members are not supported pointer types, so no evidence is // collected. If they become a supported pointer type, this test should start // failing. - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, PointerToMemberMethodArgs) { @@ -873,7 +873,7 @@ // test should start failing. // TODO(b/309625642) We should still collect evidence for the use of `Q` as an // argument for param `I`. - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, CheckMacro) { @@ -903,7 +903,7 @@ )cc"; EXPECT_THAT( collectFromTargetFuncDefinition((CheckMacroDefinitions + BaseSrc).str(), - GetMode()), + getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ABORT_IF_NULL), evidence(paramSlot(1), Evidence::ABORT_IF_NULL), evidence(paramSlot(2), Evidence::ABORT_IF_NULL), @@ -925,7 +925,7 @@ )cc"; EXPECT_THAT( collectFromTargetFuncDefinition((CheckMacroDefinitions + BaseSrc).str(), - GetMode()), + getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ABORT_IF_NULL), evidence(paramSlot(1), Evidence::ABORT_IF_NULL), evidence(paramSlot(2), Evidence::ABORT_IF_NULL))); @@ -945,7 +945,7 @@ )cc"; EXPECT_THAT(collectFromDefinitionMatching( functionDecl(hasName("Target")), - (CheckMacroDefinitions + BaseSrc).str(), GetMode()), + (CheckMacroDefinitions + BaseSrc).str(), getMode()), IsSupersetOf({(evidence(Slot(0), Evidence::ASSIGNED_FROM_NONNULL, fieldNamed("Target::Shared")), evidence(paramSlot(0), Evidence::ABORT_IF_NULL, @@ -976,7 +976,7 @@ )cc"; EXPECT_THAT( collectFromTargetFuncDefinition((CheckMacroDefinitions + BaseSrc).str(), - GetMode()), + getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ABORT_IF_NULL), evidence(paramSlot(1), Evidence::ABORT_IF_NULL), evidence(paramSlot(2), Evidence::ABORT_IF_NULL), @@ -999,7 +999,7 @@ )cc"; EXPECT_THAT( collectFromTargetFuncDefinition((CheckMacroDefinitions + BaseSrc).str(), - GetMode()), + getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ABORT_IF_NULL), evidence(paramSlot(1), Evidence::ABORT_IF_NULL), evidence(paramSlot(3), Evidence::ABORT_IF_NULL))); @@ -1010,7 +1010,7 @@ void callee(int *Q); void target(Nullable<int *> P) { callee(P); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Contains(evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, functionNamed("callee")))); } @@ -1020,7 +1020,7 @@ void callee(int *Q); void target(Nonnull<int *> P) { callee(P); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Contains(evidence(paramSlot(0), Evidence::NONNULL_ARGUMENT, functionNamed("callee")))); } @@ -1030,7 +1030,7 @@ void callee(int *Q); void target(int *P) { callee(P); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Contains(evidence(paramSlot(0), Evidence::UNKNOWN_ARGUMENT, functionNamed("callee")))); } @@ -1044,7 +1044,7 @@ } } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Contains(evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, functionNamed("callee")))); } @@ -1056,7 +1056,7 @@ if (P) callee(P); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Contains(evidence(paramSlot(0), Evidence::NONNULL_ARGUMENT, functionNamed("callee")))); } @@ -1071,7 +1071,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, functionNamed("callee")), evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, @@ -1085,7 +1085,7 @@ void callee(int Q); void target(int P) { callee(P); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, LValueReferenceArgsPassed) { @@ -1098,7 +1098,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::NULLABLE_REFERENCE_ARGUMENT, functionNamed("constCallee")), @@ -1128,7 +1128,7 @@ universalRef(std::move(q)); // Nonnull } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( // RValue references don't have the same invariance as lvalue // references, because accesses through the reference and @@ -1149,7 +1149,7 @@ return callee(P, Q, R); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(SmartPointerCollectEvidenceFromDefinitionTest, ArgsAndParams) { @@ -1165,7 +1165,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), AllOf(IsSupersetOf( {evidence(paramSlot(1), Evidence::ASSIGNED_TO_NONNULL, functionNamed("target")), @@ -1197,14 +1197,14 @@ hasDefaultExpressionOfVariable(); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, NullableReturn) { static constexpr llvm::StringRef Src = R"cc( int* target() { return nullptr; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::NULLABLE_RETURN))); } @@ -1218,7 +1218,7 @@ // compiles, as the lack of return in a path is only a warning. } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::NONNULL_RETURN))); } @@ -1229,7 +1229,7 @@ return P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::NONNULL_RETURN))); } @@ -1238,7 +1238,7 @@ static constexpr llvm::StringRef Src = R"cc( int* target(int* P) { return P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::UNKNOWN_RETURN))); } @@ -1253,7 +1253,7 @@ // compiles, as the lack of return in a path is only a warning. } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::NULLABLE_RETURN))); } @@ -1266,7 +1266,7 @@ return P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::NULLABLE_RETURN), evidence(SLOT_RETURN_TYPE, Evidence::NULLABLE_RETURN), @@ -1282,7 +1282,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::NULLABLE_REFERENCE_RETURN), evidence(SLOT_RETURN_TYPE, Evidence::NONNULL_REFERENCE_RETURN), @@ -1299,7 +1299,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::NULLABLE_REFERENCE_RETURN), evidence(SLOT_RETURN_TYPE, @@ -1313,7 +1313,7 @@ return A; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL))); } @@ -1325,7 +1325,7 @@ )cc"; EXPECT_THAT( collectFromTargetFuncDefinition( - Src, GetMode(), + Src, getMode(), {.Nonnull = std::make_shared<SortedFingerprintVector>( std::vector<SlotFingerprint>{ fingerprint("c:@F@target#*I#", 0)})}), @@ -1350,7 +1350,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL, functionNamed("target")))); } @@ -1363,7 +1363,7 @@ }; )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(SLOT_RETURN_TYPE, Evidence::NULLABLE_RETURN, functionNamed("target")))); } @@ -1382,7 +1382,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::NULLABLE_RETURN), evidence(SLOT_RETURN_TYPE, Evidence::NONNULL_RETURN), @@ -1402,7 +1402,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL), // evidence for the move constructor, which we don't care much about. @@ -1415,7 +1415,7 @@ void target() { *makePtr(); } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), Contains(evidence(SLOT_RETURN_TYPE, Evidence::UNCHECKED_DEREFERENCE, functionNamed("makePtr")))); } @@ -1430,7 +1430,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), Contains(evidence(SLOT_RETURN_TYPE, Evidence::UNCHECKED_DEREFERENCE, functionNamed("makePtr")))); } @@ -1445,7 +1445,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), Not(Contains(evidence(SLOT_RETURN_TYPE, Evidence::UNCHECKED_DEREFERENCE, functionNamed("makePtr"))))); } @@ -1460,7 +1460,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), Contains(evidence(SLOT_RETURN_TYPE, Evidence::UNCHECKED_DEREFERENCE, functionNamed("makePtr")))); } @@ -1475,7 +1475,7 @@ void target() { makePtr()->member(); } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), Contains(evidence(SLOT_RETURN_TYPE, Evidence::UNCHECKED_DEREFERENCE, functionNamed("makePtr")))); } @@ -1486,14 +1486,14 @@ Nonnull<int*> makeNonnullPtr(); void target() { *makeNonnullPtr(); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, FunctionPointerCall) { static constexpr llvm::StringRef Src = R"cc( void target(void (*F)()) { F(); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE))); } @@ -1519,7 +1519,7 @@ // Ideally, we would see the Nonnull from `P`'s template parameter and collect // ASSIGNED_TO_NONNULL evidence for `I`, but the sugar doesn't carry through // the BindingDecl's `auto` type. - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, ConstAccessorDereferencedAfterCheck) { @@ -1535,7 +1535,7 @@ } } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, @@ -1552,7 +1552,7 @@ } } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, @@ -1571,7 +1571,7 @@ } } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(SLOT_RETURN_TYPE, Evidence::UNCHECKED_DEREFERENCE, functionNamed("accessor")))); @@ -1589,7 +1589,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), Contains(evidence(SLOT_RETURN_TYPE, Evidence::UNCHECKED_DEREFERENCE, functionNamed("operator()")))); } @@ -1601,7 +1601,7 @@ }; void target() { S{} + nullptr; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Contains(evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, functionNamed("operator+")))); } @@ -1612,7 +1612,7 @@ bool operator+(const S&, int*); void target() { S{} + nullptr; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Contains(evidence(paramSlot(1), Evidence::NULLABLE_ARGUMENT, functionNamed("operator+")))); } @@ -1623,7 +1623,7 @@ void target() { callee(nullptr, nullptr); } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, functionNamed("callee")))); } @@ -1636,7 +1636,7 @@ void target() { S{}(nullptr, nullptr); } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, functionNamed("operator()")))); } @@ -1649,7 +1649,7 @@ void target(int* P) { S AnS(P, nullptr); } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL, functionNamed("target")), evidence(paramSlot(1), Evidence::NULLABLE_ARGUMENT, @@ -1665,7 +1665,7 @@ void target(int* P) { std::make_unique<S>(P, nullptr); } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL, functionNamed("target")), evidence(paramSlot(1), Evidence::NULLABLE_ARGUMENT, @@ -1681,7 +1681,7 @@ Target(int *I) : TakeNonnull(I) {} }; )cc"; - EXPECT_THAT(collectFromDefinitionNamed("Target", Src, GetMode()), + EXPECT_THAT(collectFromDefinitionNamed("Target", Src, getMode()), Contains(evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL, functionNamed("Target")))); } @@ -1697,7 +1697,7 @@ EXPECT_THAT( collectFromDefinitionMatching( - functionDecl(hasName("Target"), parameterCountIs(0)), Src, GetMode()), + functionDecl(hasName("Target"), parameterCountIs(0)), Src, getMode()), Contains(evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, functionNamed("Target")))); } @@ -1710,7 +1710,7 @@ void target(int* P, int* Q) { S AnS(P, Q); } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL, functionNamed("target")))); } @@ -1725,7 +1725,7 @@ void target(int* P, int* Q) { std::make_unique<S>(P, Q); } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL, functionNamed("target")))); } @@ -1743,7 +1743,7 @@ }; void target(int* P) { S AnS(ConvertibleToIntPtr{P}); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::ASSIGNED_TO_NONNULL, functionNamed("operator int *")), @@ -1771,7 +1771,7 @@ // evidence. However, we collect the evidence from the make_unique // instantiation and will do inference from that. EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::UNKNOWN_ARGUMENT, functionNamed("ConvertibleToIntPtr")))); } @@ -1795,7 +1795,7 @@ void target(Bar b) { std::make_unique<Foo>(b); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, @@ -1807,7 +1807,7 @@ }; )cc"; EXPECT_THAT( - collectFromDefinitionNamed("Target", Src, GetMode()), + collectFromDefinitionNamed("Target", Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL, functionNamed("Target")))); } @@ -1820,7 +1820,7 @@ }; )cc"; EXPECT_THAT(collectFromDefinitionMatching( - cxxConstructorDecl(isDefaultConstructor()), Src, GetMode()), + cxxConstructorDecl(isDefaultConstructor()), Src, getMode()), UnorderedElementsAre(evidence( Slot(0), Evidence::NULLPTR_DEFAULT_MEMBER_INITIALIZER, fieldNamed("Target::I")))); @@ -1836,7 +1836,7 @@ )cc"; EXPECT_THAT( collectFromDefinitionMatching(cxxConstructorDecl(isDefaultConstructor()), - Src, GetMode()), + Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, fieldNamed("Target::I")))); } @@ -1852,7 +1852,7 @@ }; )cc"; EXPECT_THAT( - collectFromDefinitionNamed("Target", Src, GetMode()), + collectFromDefinitionNamed("Target", Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL, functionNamed("Target")))); } @@ -1873,7 +1873,7 @@ )cc"; EXPECT_THAT(collectFromDefinitionMatching( cxxConstructorDecl(isDefaultConstructor(), hasName("Target")), - Src, GetMode()), + Src, getMode()), UnorderedElementsAre(evidence( Slot(0), Evidence::NULLPTR_DEFAULT_MEMBER_INITIALIZER, fieldNamed("Target@Sa::I")))); @@ -1887,7 +1887,7 @@ }; )cc"; EXPECT_THAT( - collectFromDefinitionNamed("Target", Src, GetMode()), + collectFromDefinitionNamed("Target", Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, fieldNamed("Target::I")))); } @@ -1905,7 +1905,7 @@ )cc"; EXPECT_THAT( - collectFromDefinitionNamed("Target", Src, GetMode()), + collectFromDefinitionNamed("Target", Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, fieldNamed("UnionType::I")))); } @@ -1918,7 +1918,7 @@ Nonnull<int*> I; }; )cc"; - EXPECT_THAT(collectFromDefinitionNamed("Target", Src, GetMode()), + EXPECT_THAT(collectFromDefinitionNamed("Target", Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::ASSIGNED_TO_NONNULL, functionNamed("getIntPtr")), @@ -1940,7 +1940,7 @@ Target T; )cc"; EXPECT_THAT(collectFromDefinitionMatching( - cxxConstructorDecl(isDefaultConstructor()), Src, GetMode()), + cxxConstructorDecl(isDefaultConstructor()), Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::ASSIGNED_TO_NONNULL, functionNamed("getIntPtr")), @@ -1961,7 +1961,7 @@ EXPECT_THAT( collectFromDefinitionMatching( cxxConstructorDecl(unless(isImplicit()), hasName("Target")), Src, - GetMode()), + getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL, functionNamed("Target")), @@ -1982,7 +1982,7 @@ EXPECT_THAT( collectFromDefinitionMatching( cxxConstructorDecl(unless(isImplicit()), hasName("Target")), Src, - GetMode()), + getMode()), UnorderedElementsAre( evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, fieldNamed("Target::I")), @@ -2004,7 +2004,7 @@ )cc"; EXPECT_THAT(collectFromDefinitionMatching( cxxConstructorDecl(isDefaultConstructor(), hasName("Target")), - Src, GetMode()), + Src, getMode()), UnorderedElementsAre(evidence( Slot(0), Evidence::NULLPTR_DEFAULT_MEMBER_INITIALIZER, fieldNamed("Target::I")))); @@ -2024,7 +2024,7 @@ )cc"; EXPECT_THAT(collectFromDefinitionMatching( cxxConstructorDecl(isDefaultConstructor(), hasName("Target")), - Src, GetMode()), + Src, getMode()), // By the end of the constructor body, the field is still only // default-initialized, which for smart pointers means it is null. UnorderedElementsAre( @@ -2044,7 +2044,7 @@ EXPECT_THAT( collectFromDefinitionMatching( cxxConstructorDecl(unless(isImplicit()), hasName("Target")), Src, - GetMode()), + getMode()), // Evidence collected from constructor body, which assigns a Nonnull // value, but no evidence collected from *implicit* member initializer // which default constructs to null. @@ -2071,7 +2071,7 @@ EXPECT_THAT( collectFromDefinitionMatching( cxxConstructorDecl(unless(isImplicit()), hasName("Target")), Src, - GetMode()), + getMode()), // By the end of the constructor body, the field is still potentially // default-initialized, which for smart pointers means it may be null. // We also collect from the Nonnull value assignment in the body, though @@ -2101,7 +2101,7 @@ EXPECT_THAT( collectFromDefinitionMatching( cxxConstructorDecl(unless(isImplicit()), hasName("Target")), Src, - GetMode()), + getMode()), // By the end of the constructor body, the field is no longer default // initialized to null, but is assigned from an unknown. UnorderedElementsAre(evidence(Slot(0), Evidence::ASSIGNED_FROM_UNKNOWN, @@ -2127,7 +2127,7 @@ )cc"; EXPECT_THAT(collectFromDefinitionMatching( cxxConstructorDecl(unless(isImplicit()), hasName("Target")), - Src, GetMode()), + Src, getMode()), IsEmpty()); } @@ -2147,7 +2147,7 @@ )cc"; EXPECT_THAT(collectFromDefinitionMatching( cxxConstructorDecl(unless(isImplicit()), hasName("Target")), - Src, GetMode()), + Src, getMode()), IsEmpty()); } @@ -2172,7 +2172,7 @@ EXPECT_THAT( collectFromDefinitionMatching( cxxMethodDecl(hasName("SetUp"), ofClass(hasName("Target"))), Src, - GetMode()), + getMode()), AllOf(Contains(evidence(Slot(0), Evidence::LEFT_NOT_NULLABLE_BY_LATE_INITIALIZER, fieldNamed("Target::FieldInitializedInSetUp"))), @@ -2204,7 +2204,7 @@ )cc"; EXPECT_THAT(collectFromDefinitionMatching( cxxMethodDecl(hasName("SetUp"), ofClass(hasName("Target"))), - Src, GetMode()), + Src, getMode()), Contains(evidence( Slot(0), Evidence::LEFT_NOT_NULLABLE_BY_LATE_INITIALIZER, fieldNamed("Target::FieldInitializedInSetUp")))); @@ -2217,7 +2217,7 @@ void target(int* P) { callee(P); } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL, functionNamed("target")))); } @@ -2229,7 +2229,7 @@ void target(int* P, int* Q) { callee(P, Q); } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL_REFERENCE, functionNamed("target")), @@ -2249,7 +2249,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL, functionNamed("target")))); } @@ -2261,7 +2261,7 @@ Callee(P); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL, functionNamed("target")), @@ -2280,7 +2280,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL, functionNamed("target")), @@ -2300,7 +2300,7 @@ void target(int* P) { MyStruct().Callee(P); } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL, functionNamed("target")), evidence(Slot(0), Evidence::UNCHECKED_DEREFERENCE, @@ -2315,7 +2315,7 @@ void target(int* P) { (&callee)(P); } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL, functionNamed("target")))); } @@ -2328,7 +2328,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL, functionNamed("target")))); } @@ -2340,7 +2340,7 @@ Callee(P); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL, functionNamed("target")), @@ -2355,7 +2355,7 @@ void target() { callee(makeIntPtr()); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(SLOT_RETURN_TYPE, Evidence::ASSIGNED_TO_NONNULL, functionNamed("makeIntPtr")))); @@ -2368,7 +2368,7 @@ void target(void (*Callee)(Nonnull<int*> I)) { Callee(makeIntPtr()); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::ASSIGNED_TO_NONNULL, functionNamed("makeIntPtr")), @@ -2382,7 +2382,7 @@ void target(int* P) { callee(P); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Not(Contains(evidence(_, _, functionNamed("target"))))); } @@ -2392,7 +2392,7 @@ void target(int* P) { callee(P); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_TO_MUTABLE_NULLABLE, functionNamed("target")))); @@ -2409,7 +2409,7 @@ callee(P); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( // The object taken by reference (P) needs to be nullable, not // necessarily the source of its value (producer). @@ -2426,7 +2426,7 @@ void target() { callee(producer()); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence( SLOT_RETURN_TYPE, Evidence::ASSIGNED_TO_MUTABLE_NULLABLE, functionNamed("producer")))); @@ -2438,7 +2438,7 @@ void target(int* P) { callee(&P); } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), AllOf(UnorderedElementsAre(evidence(paramSlot(0), Evidence::NONNULL_ARGUMENT, functionNamed("callee"))), @@ -2457,7 +2457,7 @@ A = R; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL), evidence(paramSlot(1), Evidence::ASSIGNED_TO_NONNULL), @@ -2472,7 +2472,7 @@ A = B ? R : S; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); // TODO(b/293609145) When value nullability for conditional operators is // carried through for glvalues, this should collect the following: // UnorderedElementsAre(evidence(paramSlot(1), Evidence::ASSIGNED_TO_NONNULL), @@ -2502,7 +2502,7 @@ Nonnull<std::unique_ptr<int>> nonnull = std::move(T); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL), evidence(paramSlot(2), Evidence::ASSIGNED_TO_NONNULL), @@ -2526,7 +2526,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL_REFERENCE), // `A = Q;` copies Q into P; it doesn't make a reference to Q, @@ -2545,7 +2545,7 @@ Q = R; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(1), Evidence::ASSIGNED_FROM_UNKNOWN), evidence(Slot(0), Evidence::ASSIGNED_FROM_UNKNOWN, @@ -2562,7 +2562,7 @@ A = Q; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_TO_MUTABLE_NULLABLE) // `A = Q;` copies Q into P; it doesn't make a reference to Q, @@ -2578,7 +2578,7 @@ Nullable<std::unique_ptr<int>>& A = P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_TO_MUTABLE_NULLABLE, functionNamed("target")))); @@ -2590,7 +2590,7 @@ Nullable<int*>& A = P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence( paramSlot(0), Evidence::ASSIGNED_TO_MUTABLE_NULLABLE))); } @@ -2607,7 +2607,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_TO_MUTABLE_NULLABLE), evidence(paramSlot(1), Evidence::ASSIGNED_TO_MUTABLE_NULLABLE))); @@ -2619,7 +2619,7 @@ P = nullptr; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_FROM_NULLABLE))); } @@ -2631,7 +2631,7 @@ P = A; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_FROM_NULLABLE), evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, @@ -2642,7 +2642,7 @@ static constexpr llvm::StringRef Src = R"cc( void target(int* P) { P = 0; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_FROM_NULLABLE))); } @@ -2652,7 +2652,7 @@ Nullable<int*> getNullable(); void target(int* P) { P = getNullable(); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ASSIGNED_FROM_NULLABLE, functionNamed("target")))); @@ -2665,7 +2665,7 @@ P = A; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_FROM_NULLABLE))); } @@ -2678,7 +2678,7 @@ void target(S AnS) { AnS.getPtrRef() = nullptr; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(SLOT_RETURN_TYPE, Evidence::ASSIGNED_FROM_NULLABLE, functionNamed("getPtrRef")))); @@ -2691,7 +2691,7 @@ *&P = nullptr; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_FROM_NULLABLE))); } @@ -2709,7 +2709,7 @@ P = nullptr; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, AssignedFromNonnull) { @@ -2719,7 +2719,7 @@ P = &A; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_FROM_NONNULL))); } @@ -2730,7 +2730,7 @@ P = Q; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_FROM_UNKNOWN))); } @@ -2751,7 +2751,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), // From the constructor call constructing an S; no evidence from // assignments or initializations. UnorderedElementsAre(evidence(paramSlot(0), Evidence::UNKNOWN_ARGUMENT, @@ -2768,7 +2768,7 @@ // Could in theory collect evidence for both A and B as nullable, but we don't // track null state through the conditional operator, so we don't collect // evidence for either. - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, Arithmetic) { @@ -2786,7 +2786,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ARITHMETIC), evidence(paramSlot(1), Evidence::ARITHMETIC), evidence(paramSlot(2), Evidence::ARITHMETIC), @@ -2827,7 +2827,7 @@ )cc"; EXPECT_THAT( collectFromTargetFuncDefinition((CheckMacroDefinitions + BaseSrc).str(), - GetMode()), + getMode()), IsSupersetOf( {evidence(Slot(0), Evidence::UNCHECKED_DEREFERENCE, fieldNamed("S::Deref")), @@ -2878,7 +2878,7 @@ )cc"; EXPECT_THAT( collectFromTargetFuncDefinition((CheckMacroDefinitions + BaseSrc).str(), - GetMode()), + getMode()), IsSupersetOf( {evidence(Slot(0), Evidence::UNCHECKED_DEREFERENCE, staticFieldNamed("MyStruct::Deref")), @@ -2928,7 +2928,7 @@ )cc"; EXPECT_THAT( collectFromTargetFuncDefinition((CheckMacroDefinitions + BaseSrc).str(), - GetMode()), + getMode()), IsSupersetOf({evidence(Slot(0), Evidence::UNCHECKED_DEREFERENCE, globalVarNamed("Deref")), evidence(Slot(0), Evidence::ASSIGNED_TO_NONNULL, @@ -2956,7 +2956,7 @@ int* Target = static_cast<int*>(getNullableFromNonnull(getPtr())); )cc"; - EXPECT_THAT(collectFromDefinitionNamed("Target", Src, GetMode()), + EXPECT_THAT(collectFromDefinitionNamed("Target", Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::ASSIGNED_TO_NONNULL, functionNamed("getPtr")), @@ -2969,7 +2969,7 @@ int* foo(); Nonnull<int*> Target = foo(); )cc"; - EXPECT_THAT(collectFromDefinitionNamed("Target", Src, GetMode()), + EXPECT_THAT(collectFromDefinitionNamed("Target", Src, getMode()), UnorderedElementsAre(evidence(SLOT_RETURN_TYPE, Evidence::ASSIGNED_TO_NONNULL, functionNamed("foo")))); @@ -2982,7 +2982,7 @@ std::unique_ptr<int> Target; )cc"; EXPECT_THAT( - collectFromDefinitionNamed("Target", Src, GetMode()), + collectFromDefinitionNamed("Target", Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, globalVarNamed("Target")))); } @@ -2993,7 +2993,7 @@ std::unique_ptr<int> Target = nullptr; )cc"; EXPECT_THAT( - collectFromDefinitionNamed("Target", Src, GetMode()), + collectFromDefinitionNamed("Target", Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, globalVarNamed("Target")))); } @@ -3011,7 +3011,7 @@ S Target(&GInt, AssignedToNonnull); )cc"; EXPECT_THAT( - collectFromDefinitionNamed("Target", Src, GetMode()), + collectFromDefinitionNamed("Target", Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::NONNULL_ARGUMENT, functionNamed("S")), evidence(Slot(0), Evidence::ASSIGNED_TO_NONNULL, @@ -3031,7 +3031,7 @@ std::unique_ptr<S> Target = std::make_unique<S>(&GInt, AssignedToNonnull); )cc"; EXPECT_THAT( - collectFromDefinitionNamed("Target", Src, GetMode()), + collectFromDefinitionNamed("Target", Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::ASSIGNED_FROM_NONNULL, globalVarNamed("Target")), evidence(paramSlot(0), Evidence::NONNULL_ARGUMENT, @@ -3055,7 +3055,7 @@ std::unique_ptr<S> Target = std::make_unique<S>(&GInt, AssignedToNonnull); )cc"; EXPECT_THAT( - collectFromDefinitionNamed("Target", Src, GetMode()), + collectFromDefinitionNamed("Target", Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::ASSIGNED_FROM_NONNULL, globalVarNamed("Target")), evidence(Slot(0), Evidence::ASSIGNED_FROM_NONNULL, @@ -3071,7 +3071,7 @@ }; )cc"; EXPECT_THAT( - collectFromDefinitionNamed("Target", Src, GetMode()), + collectFromDefinitionNamed("Target", Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, staticFieldNamed("MyStruct::Target")))); } @@ -3086,7 +3086,7 @@ int* MyStruct::Target = nullptr; )cc"; EXPECT_THAT( - collectFromDefinitionMatching(varDecl(hasInit()), Src, GetMode()), + collectFromDefinitionMatching(varDecl(hasInit()), Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, staticFieldNamed("MyStruct::Target")))); } @@ -3098,7 +3098,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, localVarNamed("P")))); } @@ -3118,7 +3118,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT), evidence(paramSlot(0), Evidence::UNKNOWN_ARGUMENT), evidence(paramSlot(0), Evidence::NONNULL_ARGUMENT))); @@ -3132,7 +3132,7 @@ *P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Not(Contains(evidence(_, _, functionNamed("target"))))); } @@ -3144,7 +3144,7 @@ *P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Not(Contains(evidence(_, _, functionNamed("target"))))); } @@ -3157,7 +3157,7 @@ *P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Contains(evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE, functionNamed("target")))); } @@ -3172,7 +3172,7 @@ **P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Not(Contains(evidence(_, _, functionNamed("target"))))); } @@ -3185,7 +3185,7 @@ *P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Contains(evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE, functionNamed("target")))); } @@ -3200,7 +3200,7 @@ *P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Not(Contains(evidence(_, _, functionNamed("target"))))); } @@ -3215,7 +3215,7 @@ } } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Contains(evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE, functionNamed("target")))); } @@ -3231,7 +3231,7 @@ // dereference safe, so we do not collect evidence for P. } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Not(Contains(evidence(_, _, functionNamed("target"))))); } @@ -3242,7 +3242,7 @@ )cc"; EXPECT_THAT( - collectFromDefinitionNamed("operator()", Src, GetMode()), + collectFromDefinitionNamed("operator()", Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::UNCHECKED_DEREFERENCE, globalVarNamed("P")))); } @@ -3257,7 +3257,7 @@ )cc"; EXPECT_THAT( - collectFromDefinitionNamed("operator()", Src, GetMode()), + collectFromDefinitionNamed("operator()", Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::UNCHECKED_DEREFERENCE, localVarNamed("P", "foo")))); } @@ -3272,7 +3272,7 @@ )cc"; EXPECT_THAT( - collectFromDefinitionNamed("operator()", Src, GetMode()), + collectFromDefinitionNamed("operator()", Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::UNCHECKED_DEREFERENCE, localVarNamed("P", "foo")))); } @@ -3289,7 +3289,7 @@ } )cc"; - EXPECT_THAT(collectFromDefinitionNamed("operator()", Src, GetMode()), + EXPECT_THAT(collectFromDefinitionNamed("operator()", Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE, functionNamed("foo")), @@ -3326,7 +3326,7 @@ } )cc"; - EXPECT_THAT(collectFromDefinitionNamed("operator()", Src, GetMode()), + EXPECT_THAT(collectFromDefinitionNamed("operator()", Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE, functionNamed("foo")), @@ -3357,7 +3357,7 @@ )cc"; EXPECT_THAT( - collectFromDefinitionNamed("operator()", Src, GetMode()), + collectFromDefinitionNamed("operator()", Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::UNCHECKED_DEREFERENCE, fieldNamed("A::P")), evidence(Slot(0), Evidence::UNCHECKED_DEREFERENCE, @@ -3375,7 +3375,7 @@ } )cc"; - EXPECT_THAT(collectFromDefinitionNamed("operator()", Src, GetMode()), + EXPECT_THAT(collectFromDefinitionNamed("operator()", Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::UNCHECKED_DEREFERENCE, functionNamed("bar")), @@ -3399,7 +3399,7 @@ } }; )cc"; - EXPECT_THAT(collectFromDefinitionNamed("operator()", Src, GetMode()), + EXPECT_THAT(collectFromDefinitionNamed("operator()", Src, getMode()), UnorderedElementsAre( evidence(Slot(0), Evidence::UNCHECKED_DEREFERENCE, fieldNamed("S::F")), @@ -3425,7 +3425,7 @@ } }; )cc"; - EXPECT_THAT(collectFromDefinitionNamed("operator()", Src, GetMode()), + EXPECT_THAT(collectFromDefinitionNamed("operator()", Src, getMode()), UnorderedElementsAre( evidence(Slot(0), Evidence::UNCHECKED_DEREFERENCE, fieldNamed("S::F")), @@ -3453,7 +3453,7 @@ collectFromDefinitionMatching( cxxMethodDecl(hasName("operator()"), hasAncestor(lambdaExpr(hasAncestor(lambdaExpr())))), - Src, GetMode()), + Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::UNCHECKED_DEREFERENCE, localVarNamed("A", "foo")), evidence(Slot(0), Evidence::UNCHECKED_DEREFERENCE, @@ -3469,7 +3469,7 @@ )cc"; EXPECT_THAT( - collectFromDefinitionNamed("operator()", Src, GetMode()), + collectFromDefinitionNamed("operator()", Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::UNCHECKED_DEREFERENCE, localVarNamed("Q", "operator()")))); } @@ -3482,7 +3482,7 @@ )cc"; EXPECT_THAT( - collectFromDefinitionMatching(varDecl(hasName("Q")), Src, GetMode()), + collectFromDefinitionMatching(varDecl(hasName("Q")), Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, localVarNamed("Q", "operator()")))); } @@ -3495,7 +3495,7 @@ }; )cc"; - EXPECT_THAT(collectFromDefinitionNamed("operator()", Src, GetMode()), + EXPECT_THAT(collectFromDefinitionNamed("operator()", Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::NULLABLE_RETURN, functionNamed("operator()")), @@ -3542,9 +3542,9 @@ evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, fieldNamed("MyStruct::B"))); - EXPECT_THAT(collectFromTargetFuncDefinition(BracesAggInit, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(BracesAggInit, getMode()), ExpectedEvidenceMatcher); - EXPECT_THAT(collectFromTargetFuncDefinition(ParensAggInit, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(ParensAggInit, getMode()), ExpectedEvidenceMatcher); } @@ -3570,7 +3570,7 @@ )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, fieldNamed("Base::BaseB")), evidence(paramSlot(1), Evidence::ASSIGNED_TO_NONNULL, @@ -3596,7 +3596,7 @@ void target(int* Int) { S AnS(ConvertibleToIntPtr{Int}); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::ASSIGNED_TO_NONNULL, functionNamed("operator int *")), @@ -3624,7 +3624,7 @@ // evidence. However, we collect the evidence from the make_unique // instantiation and will do inference from that. EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::UNKNOWN_ARGUMENT, functionNamed("ConvertibleToIntPtr")))); } @@ -3644,7 +3644,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, fieldNamed("MyStruct::P")), @@ -3662,7 +3662,7 @@ static constexpr llvm::StringRef Src = R"cc( void target() { int A[3] = {}; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, @@ -3673,7 +3673,7 @@ void foo(int*); void target(Nullable<std::unique_ptr<int>> P) { foo(P.get()); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), Contains(evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, functionNamed("foo")))); } @@ -3688,7 +3688,7 @@ void target() { foo({get()}); } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), IsEmpty()); + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), IsEmpty()); } TEST_P(CollectEvidenceFromDefinitionTest, ArraySubscript) { @@ -3696,7 +3696,7 @@ void target(int* P) { P[0]; } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ARRAY_SUBSCRIPT))); } @@ -3708,7 +3708,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ARRAY_SUBSCRIPT))); } @@ -3733,11 +3733,11 @@ } )cc"; EXPECT_THAT( - collectFromDefinitionNamed("Derived::foo", Src, GetMode()), + collectFromDefinitionNamed("Derived::foo", Src, getMode()), UnorderedElementsAre(evidence(SLOT_RETURN_TYPE, Evidence::NONNULL_RETURN, functionNamed("Derived@F@foo")))); - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(SLOT_RETURN_TYPE, Evidence::UNCHECKED_DEREFERENCE, functionNamed("Derived@F@foo")))); @@ -3753,7 +3753,7 @@ int* foo() override { return nullptr; } }; )cc"; - EXPECT_THAT(collectFromDefinitionNamed("Derived::foo", Src, GetMode()), + EXPECT_THAT(collectFromDefinitionNamed("Derived::foo", Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::NULLABLE_RETURN, functionNamed("Derived@F@foo")), @@ -3783,7 +3783,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::NONNULL_ARGUMENT, functionNamed("Derived@F@foo")), @@ -3792,7 +3792,7 @@ functionNamed("Base@F@foo")))); EXPECT_THAT( - collectFromDefinitionNamed("Derived::foo", Src, GetMode()), + collectFromDefinitionNamed("Derived::foo", Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE, functionNamed("Derived@F@foo")), @@ -3819,11 +3819,11 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, functionNamed("Derived@F@foo")))); - EXPECT_THAT(collectFromDefinitionNamed("Derived::foo", Src, GetMode()), + EXPECT_THAT(collectFromDefinitionNamed("Derived::foo", Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::ASSIGNED_FROM_NULLABLE, functionNamed("Derived@F@foo")))); @@ -3848,7 +3848,7 @@ } )cc"; EXPECT_THAT( - collectFromDefinitionNamed("Base::foo", Src, GetMode()), + collectFromDefinitionNamed("Base::foo", Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::NONNULL_RETURN, functionNamed("Base@F@foo")), @@ -3857,7 +3857,7 @@ functionNamed("Derived@F@foo")))); EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::UNCHECKED_DEREFERENCE, functionNamed("Base@F@foo")), @@ -3879,7 +3879,7 @@ }; )cc"; EXPECT_THAT( - collectFromDefinitionNamed("Base::foo", Src, GetMode()), + collectFromDefinitionNamed("Base::foo", Src, getMode()), UnorderedElementsAre(evidence(SLOT_RETURN_TYPE, Evidence::NULLABLE_RETURN, functionNamed("Base@F@foo")))); @@ -3907,11 +3907,11 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::NONNULL_ARGUMENT, functionNamed("Base@F@foo")))); - EXPECT_THAT(collectFromDefinitionNamed("Base::foo", Src, GetMode()), + EXPECT_THAT(collectFromDefinitionNamed("Base::foo", Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE, functionNamed("Base@F@foo")))); @@ -3933,7 +3933,7 @@ } )cc"; EXPECT_THAT( - collectFromTargetFuncDefinition(Src, GetMode()), + collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, functionNamed("Base@F@foo")), @@ -3942,7 +3942,7 @@ functionNamed("Derived@F@foo")))); EXPECT_THAT( - collectFromDefinitionNamed("Base::foo", Src, GetMode()), + collectFromDefinitionNamed("Base::foo", Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_FROM_NULLABLE, functionNamed("Base@F@foo")), @@ -3967,7 +3967,7 @@ )cc"; EXPECT_THAT( - collectFromDefinitionNamed("DerivedDerived::foo", Src, GetMode()), + collectFromDefinitionNamed("DerivedDerived::foo", Src, getMode()), UnorderedElementsAre( evidence(SLOT_RETURN_TYPE, Evidence::NULLABLE_RETURN, functionNamed("DerivedDerived@F@foo")), @@ -3995,7 +3995,7 @@ )cc"; EXPECT_THAT( - collectFromDefinitionNamed("Base::foo", Src, GetMode()), + collectFromDefinitionNamed("Base::foo", Src, getMode()), UnorderedElementsAre( evidencePropagatedFrom(functionNamed("Base@F@foo"), paramSlot(0), Evidence::ASSIGNED_FROM_NULLABLE, @@ -4021,7 +4021,7 @@ } )cc"; EXPECT_THAT( - collectFromDefinitionNamed("usage", Src, GetMode()), + collectFromDefinitionNamed("usage", Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, functionNamed("tmpl<#I>")), evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, @@ -4034,21 +4034,21 @@ EXPECT_THAT( collectFromDefinitionMatching( functionDecl(hasTemplateArgument(0, refersToType(asString("int")))), - Src, GetMode()), + Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE, functionNamed("tmpl<#I>")))); EXPECT_THAT( collectFromDefinitionMatching( functionDecl(hasTemplateArgument(0, refersToType(booleanType()))), - Src, GetMode()), + Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE, functionNamed("tmpl<#b>")))); EXPECT_THAT( collectFromDefinitionMatching(functionDecl(hasTemplateArgument( 0, refersToType(asString("char *")))), - Src, GetMode()), + Src, getMode()), UnorderedElementsAre(evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE, functionNamed("tmpl<#*C>")))); @@ -4071,7 +4071,7 @@ void usage() { tmpl<int*>(nullptr, nullptr); } )cc"; EXPECT_THAT( - collectFromDefinitionNamed("usage", Src, GetMode()), + collectFromDefinitionNamed("usage", Src, getMode()), // Evidence is emitted for the explicit specialization, not the template. UnorderedElementsAre(evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, functionNamed("tmpl<#*I>")), @@ -4080,7 +4080,7 @@ EXPECT_THAT( collectFromDefinitionMatching( functionDecl(hasTemplateArgument(0, refersToType(asString("int *")))), - Src, GetMode()), + Src, getMode()), // Evidence is emitted for the explicit specialization, not the template. UnorderedElementsAre( evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE, @@ -4101,7 +4101,7 @@ )cc"; EXPECT_THAT( collectFromDefinitionMatching(functionDecl(isTemplateInstantiation()), - Src, GetMode()), + Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, localVarNamed("A", "tmpl<#I>")), evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, @@ -4129,7 +4129,7 @@ CCharPtr.method(nullptr); } )cc"; - EXPECT_THAT(collectFromDefinitionNamed("usage", Src, GetMode()), + EXPECT_THAT(collectFromDefinitionNamed("usage", Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, AllOf(functionNamed("method"), @@ -4147,7 +4147,7 @@ EXPECT_THAT(collectFromDefinitionMatching( functionDecl(isTemplateInstantiation(), hasParameter(0, hasType(asString("int *")))), - Src, GetMode()), + Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE, AllOf(functionNamed("method"), @@ -4181,7 +4181,7 @@ CBoolPtr.method(nullptr); } )cc"; - EXPECT_THAT(collectFromDefinitionNamed("usage", Src, GetMode()), + EXPECT_THAT(collectFromDefinitionNamed("usage", Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, AllOf(functionNamed("method"), @@ -4203,7 +4203,7 @@ EXPECT_THAT(collectFromDefinitionMatching( functionDecl(isTemplateInstantiation(), hasParameter(0, hasType(asString("int *")))), - Src, GetMode()), + Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::UNCHECKED_DEREFERENCE, AllOf(functionNamed("method"), @@ -4240,7 +4240,7 @@ CInt.Field = nullptr; } )cc"; - EXPECT_THAT(collectFromDefinitionNamed("usage", Src, GetMode()), + EXPECT_THAT(collectFromDefinitionNamed("usage", Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, AllOf(functionNamed("method"), @@ -4275,7 +4275,7 @@ CIntBool.Field = nullptr; } )cc"; - EXPECT_THAT(collectFromDefinitionNamed("usage", Src, GetMode()), + EXPECT_THAT(collectFromDefinitionNamed("usage", Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::NULLABLE_ARGUMENT, AllOf(functionNamed("method"), @@ -4294,7 +4294,7 @@ )cc"; EXPECT_THAT( collectFromDefinitionMatching(varDecl(isTemplateInstantiation()), Src, - GetMode()), + getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, globalVarNamed("Global>#I")))); } @@ -4315,7 +4315,7 @@ )cc"; EXPECT_THAT( collectFromDefinitionMatching( - varDecl(isVarTemplateCompleteSpecializationDecl()), Src, GetMode()), + varDecl(isVarTemplateCompleteSpecializationDecl()), Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, globalVarNamed("Global>#I")))); } @@ -4333,7 +4333,7 @@ )cc"; EXPECT_THAT( collectFromDefinitionMatching( - varDecl(isVarTemplateCompleteSpecializationDecl()), Src, GetMode()), + varDecl(isVarTemplateCompleteSpecializationDecl()), Src, getMode()), UnorderedElementsAre(evidence(Slot(0), Evidence::ASSIGNED_FROM_NULLABLE, globalVarNamed("Global>#I#b")))); } @@ -4369,14 +4369,14 @@ // results contain the evidence needed to produce our expected inferences and // do not contain the evidence only found from propagating inferences from the // first round. - auto FirstRoundResults = collectFromTargetFuncDefinition(Src, GetMode()); + auto FirstRoundResults = collectFromTargetFuncDefinition(Src, getMode()); ASSERT_THAT(FirstRoundResults, IsSupersetOf(ExpectedBothRoundResults)); for (const auto& E : ExpectedSecondRoundResults) { ASSERT_THAT(FirstRoundResults, Not(Contains(E))); } EXPECT_THAT(collectFromTargetFuncDefinition( - Src, GetMode(), + Src, getMode(), {.Nullable = std::make_shared<SortedFingerprintVector>( std::vector<SlotFingerprint>{ fingerprint(TargetUsr, paramSlot(0))}), @@ -4430,7 +4430,7 @@ // Assert first round results because they don't rely on previous inference // propagation at all and in this case are test setup and preconditions. - auto FirstRoundResults = collectFromTargetFuncDefinition(Src, GetMode()); + auto FirstRoundResults = collectFromTargetFuncDefinition(Src, getMode()); ASSERT_THAT(FirstRoundResults, IsSupersetOf(ExpectedNewResultsPerRound.at(0))); for (const auto& E : ExpectedNewResultsPerRound.at(1)) { @@ -4438,7 +4438,7 @@ } auto SecondRoundResults = collectFromTargetFuncDefinition( - Src, GetMode(), + Src, getMode(), {.Nonnull = std::make_shared<SortedFingerprintVector>( std::vector<SlotFingerprint>{ fingerprint(TargetUsr, paramSlot(0))})}); @@ -4450,7 +4450,7 @@ } auto ThirdRoundResults = collectFromTargetFuncDefinition( - Src, GetMode(), + Src, getMode(), {.Nonnull = std::make_shared<SortedFingerprintVector>( std::vector<SlotFingerprint>{ fingerprint(TargetUsr, paramSlot(0)), @@ -4464,7 +4464,7 @@ } auto FourthRoundResults = collectFromTargetFuncDefinition( - Src, GetMode(), + Src, getMode(), {.Nonnull = std::make_shared<SortedFingerprintVector>( std::vector<SlotFingerprint>{ fingerprint(TargetUsr, paramSlot(0)), @@ -4494,7 +4494,7 @@ // This test confirms that we use that information when collecting from // target's definition. EXPECT_THAT(collectFromTargetFuncDefinition( - Src, GetMode(), + Src, getMode(), {.Nonnull = std::make_shared<SortedFingerprintVector>( std::vector<SlotFingerprint>{ fingerprint(TakesToBeNonnullUsr, paramSlot(0))})}), @@ -4509,7 +4509,7 @@ return P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL))); } @@ -4521,7 +4521,7 @@ int* local_top_level_pointer = P; } )cc"; - EXPECT_THAT(collectFromTargetFuncDefinition(Src, GetMode()), + EXPECT_THAT(collectFromTargetFuncDefinition(Src, getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL))); } @@ -4536,7 +4536,7 @@ } )cc"; EXPECT_THAT(collectFromTargetFuncDefinition( - (CheckMacroDefinitions + BaseSrc).str(), GetMode()), + (CheckMacroDefinitions + BaseSrc).str(), getMode()), UnorderedElementsAre( evidence(paramSlot(0), Evidence::ASSIGNED_TO_NONNULL), evidence(paramSlot(0), Evidence::ABORT_IF_NULL))); @@ -4566,7 +4566,7 @@ auto& Decl = *selectFirst<VarTemplateSpecializationDecl>( "d", match(varDecl(isTemplateInstantiation()).bind("d"), AST.context())); - switch (GetMode()) { + switch (getMode()) { case CollectionMode::kTestWithSummaries: EXPECT_THAT_EXPECTED( summarizeDefinition(Decl, UsrCache, Pragmas), @@ -4616,7 +4616,7 @@ auto& Decl = *selectFirst<VarTemplateSpecializationDecl>( "d", match(varDecl(isTemplateInstantiation()).bind("d"), AST.context())); - switch (GetMode()) { + switch (getMode()) { case CollectionMode::kTestWithSummaries: EXPECT_THAT_EXPECTED( summarizeDefinition(Decl, UsrCache, Pragmas), @@ -4655,7 +4655,7 @@ return std::make_unique<dataflow::WatchedLiteralsSolver>( /*MaxSATIterations=*/100); }; - switch (GetMode()) { + switch (getMode()) { case CollectionMode::kTestWithSummaries: { auto [Err, Results] = collectFromDefinitionViaSummaryWithErrors( AST, Decl, Pragmas,