Google Git
Sign in
bazel / crubit / 8b475a4b28a3dc31b83f23470d95fe60718d26c7
commit8b475a4b28a3dc31b83f23470d95fe60718d26c7[log] [tgz]
authorLukasz Anforowicz <lukasza@google.com>Tue Nov 29 09:33:02 2022 -0800
committerCopybara-Service <copybara-worker@google.com>Tue Nov 29 09:33:32 2022 -0800
tree1c1805eda93915b76694ebec4ffb5917be5b563a
parent841386cc4ee97b85dd426921768f5811ca8d2d40 [diff]
Fix handling of `std::cmp::Ordering` and `Option<i8>` in `format_ty...`.

Before this CL the "Cross-crate dependencies are not supported yet
(b/258261328)" error had no test coverage.  Adding this test coverage is
the primary motivation for this CL.  This CL is triggered by the
realization that cross-crate test coverage can be provided by testing
types from the `std` crate (earlier I thought that testing these
scenarios will require modifying `test::run_compiler` to support
depending on other crates).

Adding tests for `std::cmp::Ordering` helped flush out an additional
bug: `format_ty_for_rs` incorrectly assumed that `ty.to_string()`
returns a single identifier and panicked when it returned
"std::cmp::Ordering".  Fixing this bug encouraged introduction of
initial, minimal support for modules/namespaces and reusing
`NamespaceQualifier` from `rs_bindings_from_cc`.

The CL also opportunistucally adds test coverage for _generic_
types from other crates - by testing `Option<i8>`.

PiperOrigin-RevId: 491660080
2 files changed
tree: 1c1805eda93915b76694ebec4ffb5917be5b563a
  1. .bazelci/
  2. bazel/
  3. cc_bindings_from_rs/
  4. cc_import/
  5. cc_template/
  6. common/
  7. docs/
  8. lifetime_analysis/
  9. lifetime_annotations/
  10. migrator/
  11. nullability_verification/
  12. rs_bindings_from_cc/
  13. .bazelrc
  14. .gitignore
  15. BUILD
  16. Cargo.Bazel.lock
  17. CODE_OF_CONDUCT
  18. CONTRIBUTING
  19. LICENSE
  20. README.md
  21. WORKSPACE
README.md

Crubit: C++/Rust Bidirectional Interop Tool

Build status

Extremely experimental interop tooling for C++ and Rust.

Please don‘t use, this is an experiment and we don’t yet know where will it take us. There will be breaking changes without warning. Unfortunately, we can't take contributions at this point.

Building Crubit

$ apt install clang lld bazel
$ git clone git@github.com:google/crubit.git
$ cd crubit
$ bazel build --linkopt=-fuse-ld=/usr/bin/ld.lld //rs_bindings_from_cc:rs_bindings_from_cc_impl

Using a prebuilt LLVM tree

$ git clone https://github.com/llvm/llvm-project
$ cd llvm-project
$ CC=clang CXX=clang++ cmake -S llvm -B build -DLLVM_ENABLE_PROJECTS='clang' -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install
$ cmake --build build -j
$ # wait...
$ cmake --install build
$ cd ../crubit
$ LLVM_INSTALL_PATH=../llvm-project/install bazel build //rs_bindings_from_cc:rs_bindings_from_cc_impl