commit | ac3f19bac7bf00120ce1feb95370dffbbf83225f | [log] [tgz] |
---|---|---|
author | Googler <msta@google.com> | Tue Jun 11 16:34:23 2024 -0700 |
committer | Copybara-Service <copybara-worker@google.com> | Tue Jun 11 16:35:03 2024 -0700 |
tree | b89253031587e4cb4eddcb6b9e6b5bbd9885c2d9 | |
parent | 1cf35f02db465731e11c015f84d30ace164d1ac0 [diff] |
Remove support for args from action_type_config. BEGIN_PUBLIC Remove support for args from action_type_config. Args in individual action type configs result in redundant configuration, where both the cc_args and the cc_action_type_config control which actions they're enabled for. Instead of: ``` cc_args(name = "compile_args", action_types = [":c_compile", ":cpp_compile]) cc_action_type_config(name = "c_compile_config", actions = [":c_compile"], args = [":compile_args"]) cc_action_type_config(name = "cpp_compile_config", actions = [":cpp_compile"], args = [":compile_args"]) cc_toolchain(action_type_configs = [":c_compile_config", ":cpp_compile_config"]) ``` We should force users to write the following: ``` cc_args(name = "compile_args", action_types = [":c_compile", ":cpp_compile]) cc_action_type_config(name = "c_compile_config", actions = [":c_compile"]) cc_action_type_config(name = "cpp_compile_config", actions = [":cpp_compile"]) cc_toolchain(action_type_configs = [":c_compile_config", ":cpp_compile_config"], args = [":compile_args"]) ``` END_PUBLIC PiperOrigin-RevId: 642432029 Change-Id: I1aa7c1752f4d915d8c84c17a06314ae9ad2c69f0
This repository contains a Starlark implementation of C++ rules in Bazel.
The rules are being incrementally converted from their native implementations in the Bazel source tree.
For the list of C++ rules, see the Bazel documentation.
There is no need to use rules from this repository just yet. If you want to use rules_cc
anyway, add the following to your WORKSPACE
file:
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_cc", urls = ["https://github.com/bazelbuild/rules_cc/archive/refs/tags/<VERSION>.tar.gz"], sha256 = "...", )
Then, in your BUILD
files, import and use the rules:
load("@rules_cc//cc:defs.bzl", "cc_library") cc_library( ... )
This repo contains an auto-detecting toolchain that expects to find tools installed on your host machine. This is non-hermetic, and may have varying behaviors depending on the versions of tools found.
There are third-party contributed hermetic toolchains you may want to investigate:
If you'd like to use the cc toolchain defined in this repo, add this to your WORKSPACE after you include rules_cc:
load("@rules_cc//cc:repositories.bzl", "rules_cc_dependencies", "rules_cc_toolchains") rules_cc_dependencies() rules_cc_toolchains()
This repository also contains migration tools that can be used to migrate your project for Bazel incompatible changes.
Script that migrates legacy crosstool fields into features (incompatible flag, tracking issue).
TLDR:
bazel run @rules_cc//tools/migration:legacy_fields_migrator -- \ --input=my_toolchain/CROSSTOOL \ --inline
Bazel and rules_cc
are the work of many contributors. We appreciate your help!
To contribute, please read the contribution guidelines: CONTRIBUTING.md.
Note that the rules_cc
use the GitHub issue tracker for bug reports and feature requests only. For asking questions see:
rules_cc
mailing list#cc
on slack.bazel.build