| commit | f9cdb366276ad1f0698addf3451fac0551fa4413 | [log] [tgz] |
|---|---|---|
| author | hlopko <hlopko@google.com> | Thu Jan 17 00:07:12 2019 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Jan 17 00:07:27 2019 -0800 |
| tree | b8118aa0a4c8bc6477d3f9785b11d28bc1e6250a | |
| parent | 0fd5bb9b752e8b9c191530cf6047524d68b9f9ad [diff] |
Always put linker_flags from linking_mode_flags.DYNAMIC to nodeps-dynamic-library
This cl fixes a bug in the migrator where it didn't pass mentioned flags to c++-nodeps-dynamic-library unconditionally (it only passed them as with feature { feature: 'dynamic_linking_mode' }, which is incorrect, the feature doesn't not apply to nodeps-dynamic-library, only to transitive linking actions.
https://github.com/bazelbuild/bazel/issues/6861
https://github.com/bazelbuild/bazel/issues/5883
RELNOTES: None.
PiperOrigin-RevId: 229692958
This repository contains Starlark implementation of C++ rules in Bazel.
The rules are being incrementally converted from their native implementations in the Bazel source tree.
For the list of C++ rules, see the Bazel documentation.
There is no need to use rules from this repository just yet. If you want to use rules_cc anyway, add the following to your WORKSPACE file:
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
name = "rules_cc",
urls = ["https://github.com/bazelbuild/rules_cc/archive/TODO"],
sha256 = "TODO",
)
Then, in your BUILD files, import and use the rules:
load("@rules_cc//cc:rules.bzl", "cc_library")
cc_library(
...
)
This repository also contains migration tools that can be used to migrate your project for Bazel incompatible changes.
Script that migrates legacy crosstool fields into features (incompatible flag, tracking issue).
TLDR:
bazel run @rules_cc//tools/migration:legacy_fields_migrator -- \ --input=my_toolchain/CROSSTOOL \ --inline