Address review comments (part 2)
diff --git a/java/extensions.bzl b/java/extensions.bzl index fc04283..5ec4036 100644 --- a/java/extensions.bzl +++ b/java/extensions.bzl
@@ -13,11 +13,11 @@ # limitations under the License. """Module extensions for rules_java.""" -load("//java:repositories.bzl", "java_tools_javac11_repos", "local_jdk_repo", "remote_jdk11_repos", "remote_jdk15_repos", "remote_jdk16_repos", "remote_jdk17_repos") +load("//java:repositories.bzl", "java_tools_repos", "local_jdk_repo", "remote_jdk11_repos", "remote_jdk15_repos", "remote_jdk16_repos", "remote_jdk17_repos") def _toolchains_impl(ctx): local_jdk_repo() - java_tools_javac11_repos() + java_tools_repos() remote_jdk11_repos() remote_jdk15_repos() remote_jdk16_repos()
diff --git a/java/repositories.bzl b/java/repositories.bzl index 5f40242..c2eef07 100644 --- a/java/repositories.bzl +++ b/java/repositories.bzl
@@ -27,7 +27,7 @@ load("//toolchains:local_java_repository.bzl", "local_java_repository") load("//toolchains:remote_java_repository.bzl", "remote_java_repository") -def java_tools_javac11_repos(): +def java_tools_repos(): http_archive( name = "remote_java_tools", sha256 = "b763ee80e5754e593fd6d5be6d7343f905bc8b73d661d36d842b024ca11b6793", @@ -372,7 +372,7 @@ remote_jdk17_repos() # TODO: load this will break compatibility with Bazel 4.2.1 - # java_tools_javac11_repos() + # java_tools_repos() def rules_java_toolchains(name = "toolchains"): """An utility method to load all Java toolchains.
diff --git a/toolchains/BUILD b/toolchains/BUILD index 65afb7b..b793746 100644 --- a/toolchains/BUILD +++ b/toolchains/BUILD
@@ -313,9 +313,3 @@ runtime_version = "remotejdk_17", visibility = ["//visibility:public"], ) - -java_runtime_version_alias( - name = "jdk_8", - runtime_version = "8", - visibility = ["//visibility:public"], -)