Clean up references to the `min_bazel_8` tag No longer needed after https://github.com/bazelbuild/rules_java/commit/b63c8a11c3a84dc4dcf3405cbb390a5d178b5be1 (ignore-relnotes) PiperOrigin-RevId: 994907052 Change-Id: Id4858027032c71974e18b7109b64fdb9980856fe
diff --git a/test/java/bazel/common/java_common_tests.bzl b/test/java/bazel/common/java_common_tests.bzl index 80fdf44..9702f73 100644 --- a/test/java/bazel/common/java_common_tests.bzl +++ b/test/java/bazel/common/java_common_tests.bzl
@@ -20,8 +20,6 @@ name = name, impl = _test_java_common_pack_sources_with_external_resource_impl, target = name + "/custom", - # Bazel 7 names external repos differently - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_java_common_pack_sources_with_external_resource_impl(env, target):
diff --git a/test/java/bazel/rules/java_binary_tests.bzl b/test/java/bazel/rules/java_binary_tests.bzl index a36a911..39bd787 100644 --- a/test/java/bazel/rules/java_binary_tests.bzl +++ b/test/java/bazel/rules/java_binary_tests.bzl
@@ -67,7 +67,6 @@ name = name, impl = _test_java_binary_excludes_build_data_impl, target = name + "/bin", - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_java_binary_excludes_build_data_impl(env, target): @@ -103,7 +102,6 @@ impl = _test_java_binary_stamping_enabled_build_data_excluded_fails_impl, target = name + "/bin", expect_failure = True, - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_java_binary_stamping_enabled_build_data_excluded_fails_impl(env, target): @@ -131,8 +129,6 @@ name = name, impl = _test_java_binary_javacopts_make_variable_expansion_impl, target = name + "/bin", - # Broken by Starlarkification in the embedded rules in Bazel 7 - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_java_binary_javacopts_make_variable_expansion_impl(env, target):
diff --git a/test/java/bazel/rules/java_import_tests.bzl b/test/java/bazel/rules/java_import_tests.bzl index 8ea3ff2..e368b14 100644 --- a/test/java/bazel/rules/java_import_tests.bzl +++ b/test/java/bazel/rules/java_import_tests.bzl
@@ -21,8 +21,6 @@ name = name, impl = _test_import_deps_checker_checking_mode_impl, target = name + "/import-jar", - # The rules_java Starlark implementation is used from Bazel 8 on. - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_import_deps_checker_checking_mode_impl(env, target):
diff --git a/test/java/bazel/rules/java_library_tests.bzl b/test/java/bazel/rules/java_library_tests.bzl index 770fbe6..fd20980 100644 --- a/test/java/bazel/rules/java_library_tests.bzl +++ b/test/java/bazel/rules/java_library_tests.bzl
@@ -26,8 +26,6 @@ name = name, impl = _test_java_library_javacopts_make_variable_expansion_impl, target = name + "/lib", - # Broken by Starlarkification in the embedded rules in Bazel 7 - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_java_library_javacopts_make_variable_expansion_impl(env, target):
diff --git a/test/java/bazel/rules/java_plugin_tests.bzl b/test/java/bazel/rules/java_plugin_tests.bzl index 4df4bcc..9015ebf 100644 --- a/test/java/bazel/rules/java_plugin_tests.bzl +++ b/test/java/bazel/rules/java_plugin_tests.bzl
@@ -25,8 +25,6 @@ name = name, impl = _test_java_plugin_javacopts_make_variable_expansion_impl, target = name + "/plug", - # Broken by Starlarkification in the embedded rules in Bazel 7 - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_java_plugin_javacopts_make_variable_expansion_impl(env, target):
diff --git a/test/java/bazel/rules/java_test_tests.bzl b/test/java/bazel/rules/java_test_tests.bzl index f01d6dc..5955a92 100644 --- a/test/java/bazel/rules/java_test_tests.bzl +++ b/test/java/bazel/rules/java_test_tests.bzl
@@ -22,7 +22,6 @@ name = name, impl = _test_deduced_test_class_impl, target = name + "/foo", - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_deduced_test_class_impl(env, target): @@ -71,7 +70,6 @@ name = name, impl = _test_test_classes_impl, target = name + "/foo", - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_test_classes_impl(env, target): @@ -108,7 +106,6 @@ impl = _test_both_test_class_and_test_classes_fails_impl, target = name + "/foo", expect_failure = True, - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_both_test_class_and_test_classes_fails_impl(env, target):
diff --git a/test/java/common/java_common_tests.bzl b/test/java/common/java_common_tests.bzl index 0a3b257..e9942ab 100644 --- a/test/java/common/java_common_tests.bzl +++ b/test/java/common/java_common_tests.bzl
@@ -782,8 +782,6 @@ impl = _test_compile_strict_deps_enum_impl, target = name + "/custom", expect_failure = True, - # This is a crash in earlier Bazel versions (i.e. native rules) - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_compile_strict_deps_enum_impl(env, target):
diff --git a/test/java/common/java_info_tests.bzl b/test/java/common/java_info_tests.bzl index daea048..8f4c2c1 100644 --- a/test/java/common/java_info_tests.bzl +++ b/test/java/common/java_info_tests.bzl
@@ -1130,8 +1130,6 @@ name = name, impl = _transitive_native_libraries_test_impl, target = target_name, - # LibraryToLink.library_indentifier only available from Bazel 8 - attr_values = {"tags": ["min_bazel_8"]}, ) def _transitive_native_libraries_test_impl(env, target): @@ -1191,8 +1189,6 @@ name = name, impl = _native_libraries_propagation_test_impl, target = target_name, - # LibraryToLink.library_identifier only available from Bazel 8 - attr_values = {"tags": ["min_bazel_8"]}, ) def _native_libraries_propagation_test_impl(env, target):
diff --git a/test/java/common/rules/common_launcher_java_binary_tests.bzl b/test/java/common/rules/common_launcher_java_binary_tests.bzl index ec403a0..0a83d9c 100644 --- a/test/java/common/rules/common_launcher_java_binary_tests.bzl +++ b/test/java/common/rules/common_launcher_java_binary_tests.bzl
@@ -58,7 +58,6 @@ analysis_test( name = name, - attr_values = {"tags": ["min_bazel_8"]}, # the deploy jar was created by a separate rule in Bazel 7 config_settings = { "//command_line_option:extra_toolchains": [Label(name + "/toolchain")], }, @@ -94,7 +93,6 @@ analysis_test( name = name, - attr_values = {"tags": ["min_bazel_8"]}, # the deploy jar was created by a separate rule in Bazel 7 config_settings = { "//command_line_option:collect_code_coverage": True, }, @@ -302,8 +300,6 @@ analysis_test( name = name, - # The Starlark rules are only used with Bazel 8 onwards. - attr_values = {"tags": ["min_bazel_8"]}, attrs = { "_windows_constraints": attr.label_list(default = ["@platforms//os:windows"]), "_cc_toolchain": attr.label(default = Label("@bazel_tools//tools/cpp:current_cc_toolchain")), @@ -479,7 +475,6 @@ analysis_test( name = name, - attr_values = {"tags": ["min_bazel_8"]}, # the deploy jar was created by a separate rule in Bazel 7 impl = _test_java_binary_runtime_deps_transitivity_impl, targets = { "b1": name + "/b1",
diff --git a/test/java/common/rules/deploy_archive_builder_tests.bzl b/test/java/common/rules/deploy_archive_builder_tests.bzl index 727790f..57d3035 100644 --- a/test/java/common/rules/deploy_archive_builder_tests.bzl +++ b/test/java/common/rules/deploy_archive_builder_tests.bzl
@@ -25,8 +25,6 @@ config_settings = { "//command_line_option:extra_toolchains": [Label(name + "/toolchain")], }, - # Starlark rules are only used with Bazel 8 onwards. - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_custom_singlejar_impl(env, target):
diff --git a/test/java/common/rules/java_binary_tests.bzl b/test/java/common/rules/java_binary_tests.bzl index 8b688e1..6ee32ba 100644 --- a/test/java/common/rules/java_binary_tests.bzl +++ b/test/java/common/rules/java_binary_tests.bzl
@@ -47,8 +47,6 @@ config_settings = { "//command_line_option:stamp": False, }, - # deploy jars are in a separate rule in Bazel 7, Bazel 6 generated build-info differently - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_stamp_conversion_does_not_override_int_impl(env, target):
diff --git a/test/java/common/rules/java_import_tests.bzl b/test/java/common/rules/java_import_tests.bzl index c74bd3d..ead39e4 100644 --- a/test/java/common/rules/java_import_tests.bzl +++ b/test/java/common/rules/java_import_tests.bzl
@@ -209,8 +209,6 @@ "with_deps": name + "/import-jar", "without_deps": name + "/depjar", }, - # The rules_java Starlark implementation is used from Bazel 8 on. - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_compile_jdeps_propagated_for_deps_impl(env, targets): @@ -350,8 +348,6 @@ name = name, impl = _test_srcjar_added_to_validation_output_group_impl, target = name + "/libraryjar_with_srcjar", - # Starlark rules are only used with Bazel 8 onwards. - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_srcjar_added_to_validation_output_group_impl(env, target): @@ -920,8 +916,6 @@ name = name, impl = _test_transitive_proguard_specs_are_exported_impl, target = target_name, - # Before Bazel 8, native rules use the native ProguardSpecProvider - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_transitive_proguard_specs_are_exported_impl(env, target):
diff --git a/test/java/common/rules/java_plugin_tests.bzl b/test/java/common/rules/java_plugin_tests.bzl index 71c2d15..b6e4861 100644 --- a/test/java/common/rules/java_plugin_tests.bzl +++ b/test/java/common/rules/java_plugin_tests.bzl
@@ -194,8 +194,6 @@ name = name, impl = _test_java_plugin_exports_transitive_proguard_specs_impl, target = name + "/top", - # Before Bazel 8, native rules use the native ProguardSpecProvider - attr_values = {"tags": ["min_bazel_8"]}, provider_subject_factories = [struct( type = ProguardSpecInfo, name = "ProguardInfo",
diff --git a/test/java/common/rules/java_single_jar_tests.bzl b/test/java/common/rules/java_single_jar_tests.bzl index c2237e7..87c9246 100644 --- a/test/java/common/rules/java_single_jar_tests.bzl +++ b/test/java/common/rules/java_single_jar_tests.bzl
@@ -318,7 +318,6 @@ _analysis_test( name = name, - attr_values = {"tags": ["min_bazel_8"]}, # the deploy jar was created by a separate rule in Bazel 7 impl = _test_java_binary_deploy_env_with_java_single_jar_impl, target = name + "_bin", )
diff --git a/test/java/toolchains/java_toolchain_tests.bzl b/test/java/toolchains/java_toolchain_tests.bzl index 099b5e4..af4e69c 100644 --- a/test/java/toolchains/java_toolchain_tests.bzl +++ b/test/java/toolchains/java_toolchain_tests.bzl
@@ -111,8 +111,6 @@ config_settings = { "//command_line_option:extra_toolchains": [Label(name + "/toolchain")], }, - # This crashes in earlier Bazel versions where native rules handled deploy jars differently. - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_singlejar_get_command_line_impl(env, target): @@ -697,7 +695,6 @@ name = name, impl = _test_default_javac_opts_depset_impl, target = name + "/alias", - attr_values = {"tags": ["min_bazel_8"]}, config_settings = { "//command_line_option:extra_toolchains": [Label(name + "/toolchain")], }, @@ -727,7 +724,6 @@ config_settings = { "//command_line_option:extra_toolchains": [Label(name + "/toolchain")], }, - attr_values = {"tags": ["min_bazel_8"]}, ) def _test_default_javac_opts_impl(env, target):