Upgrade rules_nodejs to 0.36.2 Closes https://github.com/bazelbuild/rules_typescript/pull/469 PiperOrigin-RevId: 267359612
diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml index 86727d1..adf1614 100644 --- a/.bazelci/presubmit.yml +++ b/.bazelci/presubmit.yml
@@ -44,5 +44,6 @@ test_flags: - "--action_env=PATH" - "--test_env=PATH" + - "--incompatible_windows_native_test_wrapper" test_targets: - "..."
diff --git a/package.bzl b/package.bzl index b751dcb..792940d 100644 --- a/package.bzl +++ b/package.bzl
@@ -30,12 +30,8 @@ _maybe( http_archive, name = "build_bazel_rules_nodejs", - patch_args = ["-p1"], - # Patch in this PR to get the DeclarationInfo provider. - # Can remove this once it's released - patches = ["@build_bazel_rules_typescript//:rules_nodejs_pr1052.patch"], - sha256 = "6d4edbf28ff6720aedf5f97f9b9a7679401bf7fca9d14a0fff80f644a99992b4", - urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.32.2/rules_nodejs-0.32.2.tar.gz"], + sha256 = "da72ea53fa1cb8ab5ef7781ba06b97259b7d579a431ce480476266bc81bdf21d", + urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.36.2/rules_nodejs-0.36.2.tar.gz"], ) # For protocol buffers
diff --git a/rules_nodejs_pr1052.patch b/rules_nodejs_pr1052.patch deleted file mode 100644 index e50541e..0000000 --- a/rules_nodejs_pr1052.patch +++ /dev/null
@@ -1,34 +0,0 @@ -diff --git a/declaration_provider.bzl b/declaration_provider.bzl -new file mode 100644 -index 0000000..b2f89af ---- /dev/null -+++ b/declaration_provider.bzl -@@ -0,0 +1,28 @@ -+"""This module contains a provider for TypeScript typings files (.d.ts)""" -+ -+def provide_declarations(**kwargs): -+ """Factory function for creating checked declarations with externs. -+ -+ Do not directly construct DeclarationInfo() -+ """ -+ -+ # TODO: add some checking actions to ensure the declarations are well-formed -+ return DeclarationInfo(**kwargs) -+ -+DeclarationInfo = provider( -+ doc = """The DeclarationInfo provider allows JS rules to communicate typing information. -+TypeScript's .d.ts files are used as the interop format for describing types. -+ -+Do not create DeclarationInfo instances directly, instead use the provide_declarations factory function. -+ -+TODO(alexeagle): The ts_library#deps attribute should require that this provider is attached. -+ -+Note: historically this was a subset of the string-typed "typescript" provider. -+""", -+ # TODO: if we ever enable --declarationMap we will have .d.ts.map files too -+ fields = { -+ "declarations": "A depset of .d.ts files produced by this rule", -+ "transitive_declarations": """A depset of .d.ts files produced by this rule and all its transitive dependencies. -+This prevents needing an aspect in rules that consume the typings, which improves performance.""", -+ }, -+)