commit 190d13e322d0d00398f307227752362b59b0556a
author kaipi <kaipi@google.com> Tue Feb 26 13:51:42 2019 -0500
committer Jonathan Dierksen <dierksen@google.com> Wed Feb 27 13:51:54 2019 -0500
tree ba5815b3d4a79f28673672ed61256134546b6561
parent 34fd32382f144ceec4760883a3a226f3c1d7996d

Update dependency check tests.

- Reenable tests that were previously disabled during Starlark API migration.
- Disable other tests that are implementation details of rules_apple.

PiperOrigin-RevId: 235751496

src/TulsiGeneratorIntegrationTests/AspectTests.swift

diff --git a/src/TulsiGeneratorIntegrationTests/AspectTests.swift b/src/TulsiGeneratorIntegrationTests/AspectTests.swift
index 151a785..d2deb1c 100644
--- a/src/TulsiGeneratorIntegrationTests/AspectTests.swift
+++ b/src/TulsiGeneratorIntegrationTests/AspectTests.swift
@@ -55,7 +55,6 @@
     let checker = InfoChecker(ruleEntryMap: ruleEntryMap)
 
     checker.assertThat("//tulsi_test:Application")
-        .dependsOn("//tulsi_test:Application.apple_binary")
         .hasListAttribute(.compiler_defines,
                           containing: ["A_COMMANDLINE_DEFINE",
                                        "A_COMMANDLINE_DEFINE_WITH_VALUE=1",
@@ -64,8 +63,9 @@
                                                   "path": "tulsi_test/Application/Launch.storyboard",
                                                   "src": true] as NSDictionary)
 
-    checker.assertThat("//tulsi_test:Application.apple_binary")
-        .dependsOn("//tulsi_test:ApplicationLibrary")
+    // TODO(kaipi): Reenable once the application rules use the Starlark Linking API.
+    // checker.assertThat("//tulsi_test:Application")
+    //     .dependsOn("//tulsi_test:ApplicationLibrary")
 
     checker.assertThat("//tulsi_test:ApplicationLibrary")
         .dependsOn("//tulsi_test:Library")
@@ -116,11 +116,9 @@
         .dependsOn("//tulsi_test:Application")
         .dependsOn("//tulsi_test:XCTest_test_bundle")
 
-    // TODO(kaipi): Reenable these tests once rules_apple finishes the Starlark Linking API
-    // migration for tests.
     checker.assertThat("//tulsi_test:XCTest_test_bundle")
         .dependsOn("//tulsi_test:Application")
-        // .dependsOn("//tulsi_test:TestLibrary")
+        .dependsOn("//tulsi_test:TestLibrary")
   }
 
   func testExceptionThrown() {
@@ -350,12 +348,10 @@
         .dependsOn("//tulsi_test:ObjCFramework")
         .dependsOn("//tulsi_test:SrcGenerator")
 
-    // TODO(kaipi): Reenable these tests once rules_apple finishes the Starlark Linking API
-    // migration for tests.
     checker.assertThat("//tulsi_test:XCTest_test_bundle")
         .dependsOn("//tulsi_test:Application")
-        // .dependsOn("//tulsi_test:Library")
-        // .dependsOn("//tulsi_test:TestLibrary")
+        .dependsOn("//tulsi_test:Library")
+        .dependsOn("//tulsi_test:TestLibrary")
 
     checker.assertThat("//tulsi_test:Library")
         .hasSources(["tulsi_test/LibrarySources/srcs/src1.m",
@@ -377,12 +373,10 @@
 
     let checker = InfoChecker(ruleEntryMap: ruleEntryMap)
 
-    checker.assertThat("//tulsi_test:Application")
-      .dependsOn("//tulsi_test:Application.apple_binary")
-
-    checker.assertThat("//tulsi_test:Application.apple_binary")
-      .dependsOn("//tulsi_test:ApplicationLibrary")
-      .dependsOn("//tulsi_test:ApplicationResources")
+    // TODO(kaipi): Reenable once the application rules use the Starlark Linking API.
+    // checker.assertThat("//tulsi_test:Application")
+    //   .dependsOn("//tulsi_test:ApplicationLibrary")
+    //   .dependsOn("//tulsi_test:ApplicationResources")
 
     checker.assertThat("//tulsi_test:ApplicationLibrary")
       .hasSources(["tulsi_test/Library/srcs/main.m"])
@@ -408,11 +402,9 @@
 
     let checker = InfoChecker(ruleEntryMap: ruleEntryMap)
 
-    checker.assertThat("//tulsi_test:Application")
-        .dependsOn("//tulsi_test:Application.apple_binary")
-
-    checker.assertThat("//tulsi_test:Application.apple_binary")
-        .dependsOn("//tulsi_test:ApplicationLibrary")
+    // TODO(kaipi): Reenable once the application rules use the Starlark Linking API.
+    // checker.assertThat("//tulsi_test:Application")
+    //     .dependsOn("//tulsi_test:ApplicationLibrary")
 
     checker.assertThat("//tulsi_test:ApplicationLibrary")
         .dependsOn("//tulsi_test:SwiftLibrary")