commit 51346d81ad81b0edbdcf316da5cabdcf39adcad9
author Googler <noreply@google.com> Tue Nov 13 18:05:25 2018 +0000
committer Ivan Hernandez <ivanhernandez@google.com> Thu Nov 15 22:13:57 2018 +0000
tree 69005e9b555295da288d98d6ec695b882c4f9ed0
parent 79ce1b3d8ea08fcb5690e442e76be350f30e0e0e

Replace iteration over depsets with an explicit .to_list() call.

The old pattern did an implicit iteration over a depset which will be forbidden in the future since it is potentially expensive. The new to_list() call is still expensive but it will be more visible.

PiperOrigin-RevId: 221285932

src/TulsiGenerator/Bazel/tulsi/tulsi_aspects.bzl

diff --git a/src/TulsiGenerator/Bazel/tulsi/tulsi_aspects.bzl b/src/TulsiGenerator/Bazel/tulsi/tulsi_aspects.bzl
index 8d65870..9aea119 100644
--- a/src/TulsiGenerator/Bazel/tulsi/tulsi_aspects.bzl
+++ b/src/TulsiGenerator/Bazel/tulsi/tulsi_aspects.bzl
@@ -1057,7 +1057,7 @@
     info = _struct_omitting_none(
         artifact = artifact,
         archive_root = archive_root,
-        generated_sources = [(x.path, x.short_path) for x in generated_files],
+        generated_sources = [(x.path, x.short_path) for x in generated_files.to_list()],
         bundle_name = bundle_name,
         embedded_bundles = embedded_bundles.to_list(),
         has_dsym = has_dsym,