Mute skylark linter error in tulsi_aspects.bzl .
pylint suggests that we implicitly compare our kwargs, but this
comparison is best as it is for clarity.
--
PiperOrigin-RevId: 171708874
MOS_MIGRATED_REVID=171708874
diff --git a/src/TulsiGenerator/Bazel/tulsi/tulsi_aspects.bzl b/src/TulsiGenerator/Bazel/tulsi/tulsi_aspects.bzl
index 1c3f8e2..74f66fe 100644
--- a/src/TulsiGenerator/Bazel/tulsi/tulsi_aspects.bzl
+++ b/src/TulsiGenerator/Bazel/tulsi/tulsi_aspects.bzl
@@ -86,6 +86,8 @@
"""Creates a dict from the args, dropping keys with None or [] values."""
return {name: kwargs[name]
for name in kwargs
+ # Skylark doesn't support "is"; comparison is explicit for correctness.
+ # pylint: disable=g-equals-none,g-explicit-bool-comparison
if kwargs[name] != None and kwargs[name] != []
}
@@ -547,7 +549,7 @@
# Collect the dependencies of this rule, dropping any .jar files (which may be
# created as artifacts of java/j2objc rules).
dep_labels = _collect_dependency_labels(rule, _TULSI_COMPILE_DEPS)
- compile_deps = [str(l) for l in dep_labels if not l.name.endswith('.jar')]
+ compile_deps = [str(d) for d in dep_labels if not d.name.endswith('.jar')]
binary_rule = _get_opt_attr(rule_attr, 'binary')
if binary_rule and type(binary_rule) == 'list':
