Remove the TULSI_PATCHLESS_DSYMS feature flag.
This feature has been rolled out without reports of a regression,
compared to binary patching. We should clean up the flags.
PiperOrigin-RevId: 184319993
diff --git a/src/TulsiGenerator/BazelBuildSettingsFeatures.swift b/src/TulsiGenerator/BazelBuildSettingsFeatures.swift
index 95520b0..b1810be 100644
--- a/src/TulsiGenerator/BazelBuildSettingsFeatures.swift
+++ b/src/TulsiGenerator/BazelBuildSettingsFeatures.swift
@@ -17,6 +17,4 @@
"TULSI_DEBUG_PREFIX_MAP",
// Export dSYMs to allow us to establish source maps that can handle multiple potential paths.
"TULSI_ALL_DSYM",
- // TODO(b/71515804): Remove if no issues are found in replacing post_processor with this.
- "TULSI_PATCHLESS_DSYMS",
]
diff --git a/src/TulsiGenerator/Scripts/bazel_build.py b/src/TulsiGenerator/Scripts/bazel_build.py
index dbad420..6e80390 100755
--- a/src/TulsiGenerator/Scripts/bazel_build.py
+++ b/src/TulsiGenerator/Scripts/bazel_build.py
@@ -509,8 +509,6 @@
os.environ.get('TULSI_MUST_USE_DSYM', 'NO') == 'YES')
self.use_debug_prefix_map = os.environ.get('TULSI_DEBUG_PREFIX_MAP',
'NO') == 'YES'
- self.use_patchless_dsyms = os.environ.get('TULSI_PATCHLESS_DSYMS',
- 'NO') == 'YES'
self.extra_remap_path = os.environ.get('TULSI_EXTRA_REMAP_PATH', '')
# Target architecture. Must be defined for correct setting of
@@ -702,7 +700,7 @@
for path in dsym_paths:
# Starting with Xcode 9.x, a plist based solution exists for dSYM
# bundles that works with Swift as well as (Obj-)C(++).
- if self.xcode_version_major >= 900 and self.use_patchless_dsyms:
+ if self.xcode_version_major >= 900:
timer = Timer('Adding remappings as plists to dSYM',
'plist_dsym').Start()
exit_code = self._PlistdSYMPaths(path)
@@ -711,10 +709,6 @@
_PrintXcodeError('Remapping dSYMs process returned %i, please '
'report a Tulsi bug and attach a full Xcode '
'build log.' % exit_code)
- _PrintXcodeWarning('After filing the bug, change '
- 'TULSI_PATCHLESS_DSYMS in your Xcode '
- 'project\'s User-Defined Build Settings from '
- 'YES to NO.')
return exit_code
else:
timer = Timer('Patching DSYM source file paths',
