commit a1ad74235192d897f3126a08b3bb1052a2f318a4
author davg <davg@google.com> Mon Jun 18 17:45:56 2018 -0400
committer kelvinchan-google <kelvinchan@google.com> Wed Jun 20 23:57:58 2018 -0400
tree 7895520538ef6560ea7f8ec35a5983e12d41ed6c
parent f9d6e51968351f0351b8749a83cc32812419b89f

Improve integration test error messages

PiperOrigin-RevId: 201062307

src/TulsiGeneratorIntegrationTests/BazelIntegrationTestCase.swift

diff --git a/src/TulsiGeneratorIntegrationTests/BazelIntegrationTestCase.swift b/src/TulsiGeneratorIntegrationTests/BazelIntegrationTestCase.swift
index d43627e..0868b7f 100644
--- a/src/TulsiGeneratorIntegrationTests/BazelIntegrationTestCase.swift
+++ b/src/TulsiGeneratorIntegrationTests/BazelIntegrationTestCase.swift
@@ -363,7 +363,7 @@
     var observer: NSObjectProtocol? = nil
 
     init() {
-      super.init(bundle: nil)
+      super.init(bundle: Bundle(for: TulsiXcodeProjectGenerator.self))
     }
 
     deinit {
@@ -389,26 +389,14 @@
       }
     }
 
-    override func warning(_ key: String,
-                          comment: String,
-                          details: String?,
-                          context: String?,
-                          values: CVarArg...) {
-      LogMessage.postWarning("\(key) - \(values)")
-    }
-
-    override func error(_ key: String,
-                        comment: String,
-                        details: String?,
-                        context: String?,
-                        values: CVarArg...) {
-      LogMessage.postError("> Critical error logged: \(key) - \(values)")
-    }
-
     fileprivate func handleMessage(_ item: LogMessage) {
       switch item.level {
         case .Error:
-          print("> Critical error logged: \(item.message)\nDetails:\n\(String(describing: item.details))")
+          if let details = item.details {
+            print("> Critical error logged: \(item.message)\nDetails:\n\(details)")
+          } else {
+            print("> Critical error logged: \(item.message)")
+          }
         case .Warning:
           print("> W: \(item.message)")
         case .Info: