| commit | 02c56438fa447df9e3fcc680d6ad53c6cbd52981 | [log] [tgz] |
|---|---|---|
| author | jmmv <jmmv@google.com> | Wed Sep 18 14:02:22 2019 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Sep 18 14:03:11 2019 -0700 |
| tree | d682e18b9371c63c1e869574ea4cf7a0fde1c350 | |
| parent | 604d3a1d1ab869182b84ccfe976f8b7b5e6d1a51 [diff] |
Try to bring some more clarity into DynamicSpawnStrategyTest. The tests derived from strategyWaitsForBothSpawnsToFinish were really difficult to understand due to the booleans passed to this function and the various state checks based on them. I haven't been able to eliminate the booleans without a lot of code duplication, but moving the logic to verify their impact on execution to a per-test lambda makes things slightly easier to reason about. As part of the reverse-engineering of what this is supposed to do, this sprinkles comments throughout the tests based on my understanding so far. And while here (which is the smaller thing that started this CL), eliminate the booleans from the strategyPropagatesException helper function. These changes fix some pre-existing flakiness in this test related to bad interrupt handling. RELNOTES: None. PiperOrigin-RevId: 269885062
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel only rebuilds what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
Bazel is released in ‘Beta’. See the product roadmap to learn about the path toward a stable 1.0 release.