commit 0be3eaed4dbd9e89d2717844876813664f9c405a
author Googler <shreyax@google.com> Mon Jul 25 15:09:55 2022 -0700
committer fweikert <fwe@google.com> Tue Aug 02 15:52:25 2022 +0200
tree ca45455807c80f1fb228486123f2051412bb7c69
parent 4cd266aa1dfa53d8c8de44f7895edcfd46f74725

Requires delayed release

PiperOrigin-RevId: 463187444
Change-Id: Ia1c9b761bfb43f4e15ebf0d45477f0b56c8698ac

src/main/java/com/google/devtools/build/lib/skyframe/RecursivePackageProviderBackedTargetPatternResolver.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/RecursivePackageProviderBackedTargetPatternResolver.java b/src/main/java/com/google/devtools/build/lib/skyframe/RecursivePackageProviderBackedTargetPatternResolver.java
index f65ed6a..9693f5e 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/RecursivePackageProviderBackedTargetPatternResolver.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/RecursivePackageProviderBackedTargetPatternResolver.java
@@ -143,14 +143,6 @@
         rulesOnly ? FilteringPolicies.and(FilteringPolicies.RULES_ONLY, policy) : policy;
     try {
       Package pkg = getPackage(packageIdentifier);
-      if (pkg.containsErrors()) {
-        eventHandler.handle(
-            Event.error(
-                "package contains errors: "
-                    + pkg.getNameFragment()
-                    + ": "
-                    + pkg.getFailureDetail().getMessage()));
-      }
       return TargetPatternResolverUtil.resolvePackageTargets(pkg, actualPolicy);
     } catch (NoSuchThingException e) {
       String message =
@@ -172,14 +164,6 @@
       ImmutableMap.Builder<PackageIdentifier, Collection<Target>> result = ImmutableMap.builder();
       for (PackageIdentifier pkgId : pkgIds) {
         Package pkg = pkgs.get(pkgId);
-        if (pkg.containsErrors()) {
-          eventHandler.handle(
-              Event.error(
-                  "package contains errors: "
-                      + pkg.getNameFragment()
-                      + ": "
-                      + pkg.getFailureDetail().getMessage()));
-        }
         result.put(pkgId, TargetPatternResolverUtil.resolvePackageTargets(pkg, policy));
       }
       return result.buildOrThrow();