commit 1eedafde341ae310f93ca8ed290405616cf865da
author twerth <twerth@google.com> Wed Mar 04 05:32:02 2020 -0800
committer Copybara-Service <copybara-worker@google.com> Wed Mar 04 05:33:23 2020 -0800
tree 231d5262403b58cc8a888f2800c02780efe569ed
parent e679ce265c1096836fa77e2cdc394c4e9b62f934

Use LinkedBlockingQueue instead of LinkedBlockingDeque.

This reduces contention, especially noticeable with
--record_full_profiler_data.

There is too much contention, but this is a significant improvement with a
simple change.

RELNOTES: None
PiperOrigin-RevId: 298828735

src/main/java/com/google/devtools/build/lib/profiler/Profiler.java

diff --git a/src/main/java/com/google/devtools/build/lib/profiler/Profiler.java b/src/main/java/com/google/devtools/build/lib/profiler/Profiler.java
index 85c8a74..cb4d9bd 100644
--- a/src/main/java/com/google/devtools/build/lib/profiler/Profiler.java
+++ b/src/main/java/com/google/devtools/build/lib/profiler/Profiler.java
@@ -43,7 +43,7 @@
 import java.util.Map;
 import java.util.UUID;
 import java.util.concurrent.BlockingQueue;
-import java.util.concurrent.LinkedBlockingDeque;
+import java.util.concurrent.LinkedBlockingQueue;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.atomic.AtomicReference;
@@ -867,7 +867,7 @@
     protected IOException savedException;
 
     FileWriter() {
-      this.queue = new LinkedBlockingDeque<>();
+      this.queue = new LinkedBlockingQueue<>();
       this.thread = new Thread(this, "profile-writer-thread");
     }