| // Copyright 2021 The Bazel Authors. All rights reserved. | |
| // | |
| // Licensed under the Apache License, Version 2.0 (the "License"); | |
| // you may not use this file except in compliance with the License. | |
| // You may obtain a copy of the License at | |
| // | |
| // http://www.apache.org/licenses/LICENSE-2.0 | |
| // Unless required by applicable law or agreed to in writing, software | |
| // distributed under the License is distributed on an "AS IS" BASIS, | |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| // See the License for the specific language governing permissions and | |
| // limitations under the License. | |
| package com.google.devtools.build.lib.remote; | |
| import static com.google.common.base.Preconditions.checkNotNull; | |
| import static com.google.common.collect.ImmutableList.toImmutableList; | |
| import static com.google.common.collect.ImmutableMap.toImmutableMap; | |
| import static com.google.common.truth.Truth.assertThat; | |
| import static com.google.common.truth.extensions.proto.ProtoTruth.assertThat; | |
| import static com.google.common.util.concurrent.MoreExecutors.directExecutor; | |
| import static com.google.devtools.build.lib.actions.ExecutionRequirements.REMOTE_EXECUTION_INLINE_OUTPUTS; | |
| import static com.google.devtools.build.lib.remote.util.DigestUtil.toBinaryDigest; | |
| import static com.google.devtools.build.lib.remote.util.Utils.getFromFuture; | |
| import static com.google.devtools.build.lib.vfs.FileSystemUtils.readContent; | |
| import static java.nio.charset.StandardCharsets.UTF_8; | |
| import static org.junit.Assert.assertThrows; | |
| import static org.mockito.ArgumentMatchers.any; | |
| import static org.mockito.Mockito.doAnswer; | |
| import static org.mockito.Mockito.doReturn; | |
| import static org.mockito.Mockito.mock; | |
| import static org.mockito.Mockito.spy; | |
| import static org.mockito.Mockito.times; | |
| import static org.mockito.Mockito.verify; | |
| import static org.mockito.Mockito.when; | |
| import build.bazel.remote.execution.v2.ActionResult; | |
| import build.bazel.remote.execution.v2.CacheCapabilities; | |
| import build.bazel.remote.execution.v2.Digest; | |
| import build.bazel.remote.execution.v2.Directory; | |
| import build.bazel.remote.execution.v2.DirectoryNode; | |
| import build.bazel.remote.execution.v2.FileNode; | |
| import build.bazel.remote.execution.v2.NodeProperties; | |
| import build.bazel.remote.execution.v2.NodeProperty; | |
| import build.bazel.remote.execution.v2.OutputDirectory; | |
| import build.bazel.remote.execution.v2.OutputFile; | |
| import build.bazel.remote.execution.v2.OutputSymlink; | |
| import build.bazel.remote.execution.v2.Platform; | |
| import build.bazel.remote.execution.v2.RequestMetadata; | |
| import build.bazel.remote.execution.v2.SymlinkAbsolutePathStrategy; | |
| import build.bazel.remote.execution.v2.SymlinkNode; | |
| import build.bazel.remote.execution.v2.Tree; | |
| import com.google.common.base.Throwables; | |
| import com.google.common.collect.ImmutableClassToInstanceMap; | |
| import com.google.common.collect.ImmutableList; | |
| import com.google.common.collect.ImmutableMap; | |
| import com.google.common.collect.ImmutableSet; | |
| import com.google.common.eventbus.EventBus; | |
| import com.google.common.util.concurrent.Futures; | |
| import com.google.common.util.concurrent.SettableFuture; | |
| import com.google.devtools.build.lib.actions.ActionInput; | |
| import com.google.devtools.build.lib.actions.ActionInputHelper; | |
| import com.google.devtools.build.lib.actions.ActionInputMap; | |
| import com.google.devtools.build.lib.actions.ActionOutputDirectoryHelper; | |
| import com.google.devtools.build.lib.actions.ActionUploadFinishedEvent; | |
| import com.google.devtools.build.lib.actions.ActionUploadStartedEvent; | |
| import com.google.devtools.build.lib.actions.Artifact; | |
| import com.google.devtools.build.lib.actions.ArtifactRoot; | |
| import com.google.devtools.build.lib.actions.ArtifactRoot.RootType; | |
| import com.google.devtools.build.lib.actions.ExecutionRequirements; | |
| import com.google.devtools.build.lib.actions.PathMapper; | |
| import com.google.devtools.build.lib.actions.ResourceSet; | |
| import com.google.devtools.build.lib.actions.RunfilesTree; | |
| import com.google.devtools.build.lib.actions.SimpleSpawn; | |
| import com.google.devtools.build.lib.actions.Spawn; | |
| import com.google.devtools.build.lib.actions.SpawnResult; | |
| import com.google.devtools.build.lib.actions.SpawnResult.Status; | |
| import com.google.devtools.build.lib.actions.StaticInputMetadataProvider; | |
| import com.google.devtools.build.lib.actions.util.ActionsTestUtil; | |
| import com.google.devtools.build.lib.analysis.config.BuildConfigurationValue.RunfileSymlinksMode; | |
| import com.google.devtools.build.lib.clock.JavaClock; | |
| import com.google.devtools.build.lib.collect.nestedset.NestedSet; | |
| import com.google.devtools.build.lib.collect.nestedset.NestedSetBuilder; | |
| import com.google.devtools.build.lib.collect.nestedset.Order; | |
| import com.google.devtools.build.lib.events.Event; | |
| import com.google.devtools.build.lib.events.EventKind; | |
| import com.google.devtools.build.lib.events.Reporter; | |
| import com.google.devtools.build.lib.events.StoredEventHandler; | |
| import com.google.devtools.build.lib.exec.util.FakeOwner; | |
| import com.google.devtools.build.lib.exec.util.SpawnBuilder; | |
| import com.google.devtools.build.lib.remote.RemoteExecutionService.RemoteActionResult; | |
| import com.google.devtools.build.lib.remote.RemoteScrubbing.Config; | |
| import com.google.devtools.build.lib.remote.common.BulkTransferException; | |
| import com.google.devtools.build.lib.remote.common.RemoteActionExecutionContext; | |
| import com.google.devtools.build.lib.remote.common.RemoteCacheClient.CachedActionResult; | |
| import com.google.devtools.build.lib.remote.common.RemoteExecutionClient; | |
| import com.google.devtools.build.lib.remote.common.RemotePathResolver; | |
| import com.google.devtools.build.lib.remote.common.RemotePathResolver.DefaultRemotePathResolver; | |
| import com.google.devtools.build.lib.remote.common.RemotePathResolver.SiblingRepositoryLayoutResolver; | |
| import com.google.devtools.build.lib.remote.merkletree.MerkleTree; | |
| import com.google.devtools.build.lib.remote.options.RemoteOptions; | |
| import com.google.devtools.build.lib.remote.salt.CacheSalt; | |
| import com.google.devtools.build.lib.remote.util.DigestUtil; | |
| import com.google.devtools.build.lib.remote.util.FakeSpawnExecutionContext; | |
| import com.google.devtools.build.lib.remote.util.InMemoryCacheClient; | |
| import com.google.devtools.build.lib.remote.util.RxNoGlobalErrorsRule; | |
| import com.google.devtools.build.lib.remote.util.TempPathGenerator; | |
| import com.google.devtools.build.lib.remote.util.TracingMetadataUtils; | |
| import com.google.devtools.build.lib.remote.util.Utils.InMemoryOutput; | |
| import com.google.devtools.build.lib.util.io.FileOutErr; | |
| import com.google.devtools.build.lib.vfs.DigestHashFunction; | |
| import com.google.devtools.build.lib.vfs.FileSystem; | |
| import com.google.devtools.build.lib.vfs.OutputPermissions; | |
| import com.google.devtools.build.lib.vfs.OutputService; | |
| import com.google.devtools.build.lib.vfs.Path; | |
| import com.google.devtools.build.lib.vfs.PathFragment; | |
| import com.google.devtools.build.lib.vfs.Symlinks; | |
| import com.google.devtools.build.lib.vfs.SyscallCache; | |
| import com.google.devtools.build.lib.vfs.inmemoryfs.InMemoryFileSystem; | |
| import com.google.devtools.common.options.Options; | |
| import com.google.protobuf.ByteString; | |
| import com.google.testing.junit.testparameterinjector.TestParameter; | |
| import com.google.testing.junit.testparameterinjector.TestParameterInjector; | |
| import java.io.IOException; | |
| import java.util.Collection; | |
| import java.util.Map; | |
| import java.util.Random; | |
| import java.util.concurrent.CountDownLatch; | |
| import java.util.concurrent.ExecutorService; | |
| import java.util.concurrent.Executors; | |
| import java.util.concurrent.Semaphore; | |
| import java.util.concurrent.atomic.AtomicReference; | |
| import org.junit.Before; | |
| import org.junit.Rule; | |
| import org.junit.Test; | |
| import org.junit.runner.RunWith; | |
| import org.mockito.ArgumentMatchers; | |
| import org.mockito.Mock; | |
| import org.mockito.junit.MockitoJUnit; | |
| import org.mockito.junit.MockitoRule; | |
| /** Tests for {@link RemoteExecutionService}. */ | |
| @RunWith(TestParameterInjector.class) | |
| public class RemoteExecutionServiceTest { | |
| @Rule public final MockitoRule mockito = MockitoJUnit.rule(); | |
| @Rule public final RxNoGlobalErrorsRule rxNoGlobalErrorsRule = new RxNoGlobalErrorsRule(); | |
| @Mock private RemoteOutputChecker remoteOutputChecker; // download nothing by default. | |
| @Mock private OutputService outputService; | |
| private final DigestUtil digestUtil = | |
| new DigestUtil(SyscallCache.NO_CACHE, DigestHashFunction.SHA256); | |
| private final Reporter reporter = new Reporter(new EventBus()); | |
| private final StoredEventHandler eventHandler = new StoredEventHandler(); | |
| RemoteOptions remoteOptions; | |
| private FileSystem fs; | |
| private Path execRoot; | |
| private ArtifactRoot artifactRoot; | |
| private ArtifactRoot middlemanRoot; | |
| private TempPathGenerator tempPathGenerator; | |
| private FakeActionInputFileCache fakeFileCache; | |
| private RemotePathResolver remotePathResolver; | |
| private FileOutErr outErr; | |
| private InMemoryRemoteCache cache; | |
| private RemoteExecutionClient executor; | |
| private RemoteActionExecutionContext remoteActionExecutionContext; | |
| @Before | |
| public final void setUp() throws Exception { | |
| reporter.addHandler(eventHandler); | |
| remoteOptions = Options.getDefaults(RemoteOptions.class); | |
| fs = new InMemoryFileSystem(new JavaClock(), DigestHashFunction.SHA256); | |
| execRoot = fs.getPath("/execroot"); | |
| execRoot.createDirectoryAndParents(); | |
| artifactRoot = ArtifactRoot.asDerivedRoot(execRoot, RootType.Output, "outputs"); | |
| middlemanRoot = | |
| ArtifactRoot.asDerivedRoot(execRoot, RootType.Middleman, PathFragment.create("out")); | |
| checkNotNull(artifactRoot.getRoot().asPath()).createDirectoryAndParents(); | |
| tempPathGenerator = new TempPathGenerator(fs.getPath("/execroot/_tmp/actions/remote")); | |
| fakeFileCache = new FakeActionInputFileCache(execRoot); | |
| remotePathResolver = new DefaultRemotePathResolver(execRoot); | |
| Path stdout = fs.getPath("/tmp/stdout"); | |
| Path stderr = fs.getPath("/tmp/stderr"); | |
| checkNotNull(stdout.getParentDirectory()).createDirectoryAndParents(); | |
| checkNotNull(stderr.getParentDirectory()).createDirectoryAndParents(); | |
| outErr = new FileOutErr(stdout, stderr); | |
| cache = spy(new InMemoryRemoteCache(spy(new InMemoryCacheClient()), remoteOptions, digestUtil)); | |
| executor = mock(RemoteExecutionClient.class); | |
| RequestMetadata metadata = | |
| TracingMetadataUtils.buildMetadata("none", "none", "action-id", null); | |
| remoteActionExecutionContext = RemoteActionExecutionContext.create(metadata); | |
| } | |
| @Test | |
| public void buildRemoteAction_withRegularFileAsOutput() throws Exception { | |
| PathFragment execPath = execRoot.getRelative("path/to/tree").asFragment(); | |
| Spawn spawn = | |
| new SpawnBuilder("dummy") | |
| .withOutput(ActionsTestUtil.createArtifactWithExecPath(artifactRoot, execPath)) | |
| .build(); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction remoteAction = service.buildRemoteAction(spawn, context); | |
| assertThat(remoteAction.getCommand().getOutputFilesList()).containsExactly(execPath.toString()); | |
| assertThat(remoteAction.getCommand().getOutputPathsList()).containsExactly(execPath.toString()); | |
| assertThat(remoteAction.getCommand().getOutputDirectoriesList()).isEmpty(); | |
| } | |
| @Test | |
| public void buildRemoteAction_withTreeArtifactAsOutput() throws Exception { | |
| Spawn spawn = | |
| new SpawnBuilder("dummy") | |
| .withOutput( | |
| ActionsTestUtil.createTreeArtifactWithGeneratingAction( | |
| artifactRoot, PathFragment.create("path/to/dir"))) | |
| .build(); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction remoteAction = service.buildRemoteAction(spawn, context); | |
| assertThat(remoteAction.getCommand().getOutputFilesList()).isEmpty(); | |
| assertThat(remoteAction.getCommand().getOutputDirectoriesList()).containsExactly("path/to/dir"); | |
| } | |
| @Test | |
| public void buildRemoteAction_withUnresolvedSymlinkAsOutput() throws Exception { | |
| Spawn spawn = | |
| new SpawnBuilder("dummy") | |
| .withOutput( | |
| ActionsTestUtil.createUnresolvedSymlinkArtifactWithExecPath( | |
| artifactRoot, PathFragment.create("path/to/link"))) | |
| .build(); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction remoteAction = service.buildRemoteAction(spawn, context); | |
| assertThat(remoteAction.getCommand().getOutputFilesList()).containsExactly("path/to/link"); | |
| assertThat(remoteAction.getCommand().getOutputDirectoriesList()).isEmpty(); | |
| assertThat(remoteAction.getCommand().getOutputPathsList()).containsExactly("path/to/link"); | |
| } | |
| @Test | |
| public void buildRemoteAction_withActionInputAsOutput() throws Exception { | |
| Spawn spawn = | |
| new SpawnBuilder("dummy") | |
| .withOutput(ActionInputHelper.fromPath(PathFragment.create("path/to/file"))) | |
| .build(); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction remoteAction = service.buildRemoteAction(spawn, context); | |
| assertThat(remoteAction.getCommand().getOutputFilesList()).containsExactly("path/to/file"); | |
| assertThat(remoteAction.getCommand().getOutputDirectoriesList()).isEmpty(); | |
| } | |
| @Test | |
| public void buildRemoteAction_generateActionSalt_differentiateWorkspaceCache() throws Exception { | |
| Spawn spawn = | |
| new SpawnBuilder("dummy") | |
| .withExecutionInfo(ExecutionRequirements.DIFFERENTIATE_WORKSPACE_CACHE, "aa") | |
| .build(); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction remoteAction = service.buildRemoteAction(spawn, context); | |
| CacheSalt expected = | |
| CacheSalt.newBuilder().setMayBeExecutedRemotely(true).setWorkspace("aa").build(); | |
| assertThat(remoteAction.getAction().getSalt()).isEqualTo(expected.toByteString()); | |
| } | |
| @Test | |
| public void buildRemoteAction_generateActionSalt_noRemoteExec() throws Exception { | |
| Spawn spawn = | |
| new SpawnBuilder("dummy") | |
| .withExecutionInfo(ExecutionRequirements.NO_REMOTE_EXEC, "") | |
| .build(); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction remoteAction = service.buildRemoteAction(spawn, context); | |
| CacheSalt expected = CacheSalt.newBuilder().setMayBeExecutedRemotely(false).build(); | |
| assertThat(remoteAction.getAction().getSalt()).isEqualTo(expected.toByteString()); | |
| } | |
| @Test | |
| public void downloadOutputs_executableBitIgnored() throws Exception { | |
| // Test that executable bit of downloaded output files are ignored since it will be chmod 555 | |
| // after action execution. | |
| // arrange | |
| Digest fooDigest = cache.addContents(remoteActionExecutionContext, "foo-contents"); | |
| Digest barDigest = cache.addContents(remoteActionExecutionContext, "bar-contents"); | |
| Tree tree = | |
| Tree.newBuilder() | |
| .setRoot( | |
| Directory.newBuilder() | |
| .addFiles( | |
| FileNode.newBuilder() | |
| .setName("bar") | |
| .setDigest(barDigest) | |
| .setIsExecutable(true))) | |
| .build(); | |
| Digest treeDigest = cache.addContents(remoteActionExecutionContext, tree.toByteArray()); | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputFilesBuilder().setPath("outputs/foo").setDigest(fooDigest); | |
| builder.addOutputDirectoriesBuilder().setPath("outputs/dir").setTreeDigest(treeDigest); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| // act | |
| service.downloadOutputs(action, result); | |
| // assert | |
| assertThat(execRoot.getRelative("outputs/foo").isExecutable()).isFalse(); | |
| assertThat(execRoot.getRelative("outputs/dir/bar").isExecutable()).isFalse(); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_siblingLayoutAndRelativeToInputRoot_works() throws Exception { | |
| // arrange | |
| remotePathResolver = new SiblingRepositoryLayoutResolver(execRoot, true); | |
| Digest fooDigest = cache.addContents(remoteActionExecutionContext, "foo-contents"); | |
| Digest barDigest = cache.addContents(remoteActionExecutionContext, "bar-contents"); | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputFilesBuilder().setPath("execroot/outputs/foo").setDigest(fooDigest); | |
| builder.addOutputFilesBuilder().setPath("execroot/outputs/bar").setDigest(barDigest); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| // act | |
| service.downloadOutputs(action, result); | |
| // assert | |
| assertThat(readContent(execRoot.getRelative("outputs/foo"), UTF_8)).isEqualTo("foo-contents"); | |
| assertThat(readContent(execRoot.getRelative("outputs/bar"), UTF_8)).isEqualTo("bar-contents"); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_outputFiles() throws Exception { | |
| // arrange | |
| Digest d1 = cache.addContents(remoteActionExecutionContext, "content1"); | |
| ActionResult r = | |
| ActionResult.newBuilder() | |
| .setExitCode(0) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file1").setDigest(d1)) | |
| .build(); | |
| RemoteActionResult result = RemoteActionResult.createFromCache(CachedActionResult.remote(r)); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| // act | |
| InMemoryOutput inMemoryOutput = service.downloadOutputs(action, result); | |
| // assert | |
| assertThat(inMemoryOutput).isNull(); | |
| RemoteActionFileSystem actionFs = context.getActionFileSystem(); | |
| assertThat(actionFs.getDigest(execRoot.asFragment().getRelative("outputs/file1"))) | |
| .isEqualTo(toBinaryDigest(d1)); | |
| assertThat(readContent(execRoot.getRelative("outputs/file1"), UTF_8)).isEqualTo("content1"); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_outputDirectories() throws Exception { | |
| // Test that downloading an output directory works. | |
| // arrange | |
| Digest fooDigest = cache.addContents(remoteActionExecutionContext, "foo-contents"); | |
| Digest barDigest = cache.addContents(remoteActionExecutionContext, "bar-contents"); | |
| Tree tree = | |
| Tree.newBuilder() | |
| .setRoot( | |
| Directory.newBuilder() | |
| .addFiles( | |
| FileNode.newBuilder() | |
| .setName("foo") | |
| .setDigest(fooDigest) | |
| .setIsExecutable(true)) | |
| .addFiles( | |
| FileNode.newBuilder() | |
| .setName("subdir/bar") | |
| .setDigest(barDigest) | |
| .setIsExecutable(true))) | |
| .build(); | |
| Digest treeDigest = cache.addContents(remoteActionExecutionContext, tree.toByteArray()); | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputDirectoriesBuilder().setPath("outputs/a/dir").setTreeDigest(treeDigest); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| // act | |
| service.downloadOutputs(action, result); | |
| // assert | |
| RemoteActionFileSystem actionFs = context.getActionFileSystem(); | |
| assertThat(actionFs.getDigest(execRoot.asFragment().getRelative("outputs/a/dir/foo"))) | |
| .isEqualTo(toBinaryDigest(fooDigest)); | |
| assertThat(actionFs.getDigest(execRoot.asFragment().getRelative("outputs/a/dir/subdir/bar"))) | |
| .isEqualTo(toBinaryDigest(barDigest)); | |
| assertThat(readContent(execRoot.getRelative("outputs/a/dir/foo"), UTF_8)) | |
| .isEqualTo("foo-contents"); | |
| assertThat(readContent(execRoot.getRelative("outputs/a/dir/subdir/bar"), UTF_8)) | |
| .isEqualTo("bar-contents"); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_emptyOutputDirectories_works() throws Exception { | |
| // Test that downloading an empty output directory works. | |
| // arrange | |
| Tree barTreeMessage = Tree.newBuilder().setRoot(Directory.getDefaultInstance()).build(); | |
| Digest barTreeDigest = | |
| cache.addContents(remoteActionExecutionContext, barTreeMessage.toByteArray()); | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputDirectoriesBuilder().setPath("outputs/a/bar").setTreeDigest(barTreeDigest); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| // act | |
| service.downloadOutputs(action, result); | |
| // assert | |
| assertThat(execRoot.getRelative("outputs/a/bar").isDirectory()).isTrue(); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_nestedOutputDirectories_works() throws Exception { | |
| // Test that downloading a nested output directory works. | |
| // arrange | |
| Digest fooDigest = cache.addContents(remoteActionExecutionContext, "foo-contents"); | |
| Digest quxDigest = cache.addContents(remoteActionExecutionContext, "qux-contents"); | |
| Directory wobbleDirMessage = | |
| Directory.newBuilder() | |
| .addFiles( | |
| FileNode.newBuilder().setName("qux").setDigest(quxDigest).setIsExecutable(true)) | |
| .build(); | |
| Digest wobbleDirDigest = | |
| cache.addContents(remoteActionExecutionContext, wobbleDirMessage.toByteArray()); | |
| Tree barTreeMessage = | |
| Tree.newBuilder() | |
| .setRoot( | |
| Directory.newBuilder() | |
| .addFiles( | |
| FileNode.newBuilder() | |
| .setName("qux") | |
| .setDigest(quxDigest) | |
| .setIsExecutable(true)) | |
| .addDirectories( | |
| DirectoryNode.newBuilder().setName("wobble").setDigest(wobbleDirDigest))) | |
| .addChildren(wobbleDirMessage) | |
| .build(); | |
| Digest barTreeDigest = | |
| cache.addContents(remoteActionExecutionContext, barTreeMessage.toByteArray()); | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputFilesBuilder().setPath("outputs/a/foo").setDigest(fooDigest); | |
| builder.addOutputDirectoriesBuilder().setPath("outputs/a/bar").setTreeDigest(barTreeDigest); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| // act | |
| service.downloadOutputs(action, result); | |
| // assert | |
| assertThat(readContent(execRoot.getRelative("outputs/a/foo"), UTF_8)).isEqualTo("foo-contents"); | |
| assertThat(readContent(execRoot.getRelative("outputs/a/bar/wobble/qux"), UTF_8)) | |
| .isEqualTo("qux-contents"); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_outputDirectoriesWithNestedFile_works() throws Exception { | |
| // Test that downloading an output directory containing a named output file works. | |
| // arrange | |
| Digest fooDigest = cache.addContents(remoteActionExecutionContext, "foo-contents"); | |
| Digest barDigest = cache.addContents(remoteActionExecutionContext, "bar-contents"); | |
| Tree subdirTreeMessage = | |
| Tree.newBuilder() | |
| .setRoot( | |
| Directory.newBuilder() | |
| .addFiles( | |
| FileNode.newBuilder() | |
| .setName("foo") | |
| .setDigest(fooDigest) | |
| .setIsExecutable(true)) | |
| .addFiles( | |
| FileNode.newBuilder() | |
| .setName("bar") | |
| .setDigest(barDigest) | |
| .setIsExecutable(true))) | |
| .build(); | |
| Digest subdirTreeDigest = | |
| cache.addContents(remoteActionExecutionContext, subdirTreeMessage.toByteArray()); | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputFilesBuilder().setPath("outputs/subdir/foo").setDigest(fooDigest); | |
| builder.addOutputDirectoriesBuilder().setPath("outputs/subdir").setTreeDigest(subdirTreeDigest); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| // act | |
| service.downloadOutputs(action, result); | |
| // assert | |
| assertThat(readContent(execRoot.getRelative("outputs/subdir/foo"), UTF_8)) | |
| .isEqualTo("foo-contents"); | |
| assertThat(readContent(execRoot.getRelative("outputs/subdir/bar"), UTF_8)) | |
| .isEqualTo("bar-contents"); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_outputDirectoriesWithSameHash_works() throws Exception { | |
| // Test that downloading an output directory works when two Directory | |
| // protos have the same hash i.e. because they have the same name and contents or are empty. | |
| /* | |
| * /bar/foo/file | |
| * /foo/file | |
| */ | |
| // arrange | |
| Digest fileDigest = cache.addContents(remoteActionExecutionContext, "file"); | |
| FileNode file = | |
| FileNode.newBuilder().setName("file").setDigest(fileDigest).setIsExecutable(true).build(); | |
| Directory fooDir = Directory.newBuilder().addFiles(file).build(); | |
| Digest fooDigest = cache.addContents(remoteActionExecutionContext, fooDir.toByteArray()); | |
| DirectoryNode fooDirNode = | |
| DirectoryNode.newBuilder().setName("foo").setDigest(fooDigest).build(); | |
| Directory barDir = Directory.newBuilder().addDirectories(fooDirNode).build(); | |
| Digest barDigest = cache.addContents(remoteActionExecutionContext, barDir.toByteArray()); | |
| DirectoryNode barDirNode = | |
| DirectoryNode.newBuilder().setName("bar").setDigest(barDigest).build(); | |
| Directory rootDir = | |
| Directory.newBuilder().addDirectories(fooDirNode).addDirectories(barDirNode).build(); | |
| Tree tree = | |
| Tree.newBuilder() | |
| .setRoot(rootDir) | |
| .addChildren(barDir) | |
| .addChildren(fooDir) | |
| .addChildren(fooDir) | |
| .build(); | |
| Digest treeDigest = cache.addContents(remoteActionExecutionContext, tree.toByteArray()); | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputDirectoriesBuilder().setPath("outputs/a").setTreeDigest(treeDigest); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| // act | |
| service.downloadOutputs(action, result); | |
| // assert | |
| assertThat(readContent(execRoot.getRelative("outputs/a/bar/foo/file"), UTF_8)) | |
| .isEqualTo("file"); | |
| assertThat(readContent(execRoot.getRelative("outputs/a/foo/file"), UTF_8)).isEqualTo("file"); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_relativeFileSymlink_success() throws Exception { | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputFileSymlinksBuilder().setPath("outputs/a/b/link").setTarget("../../foo"); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| // Doesn't check for dangling links, hence download succeeds. | |
| service.downloadOutputs(action, result); | |
| Path path = execRoot.getRelative("outputs/a/b/link"); | |
| assertThat(path.isSymbolicLink()).isTrue(); | |
| assertThat(path.readSymbolicLink()).isEqualTo(PathFragment.create("../../foo")); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_relativeDirectorySymlink_success() throws Exception { | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputDirectorySymlinksBuilder().setPath("outputs/a/b/link").setTarget("foo"); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| // Doesn't check for dangling links, hence download succeeds. | |
| service.downloadOutputs(action, result); | |
| Path path = execRoot.getRelative("outputs/a/b/link"); | |
| assertThat(path.isSymbolicLink()).isTrue(); | |
| assertThat(path.readSymbolicLink()).isEqualTo(PathFragment.create("foo")); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_relativeOutputSymlinks_success() throws Exception { | |
| // Test that download outputs works when the action result only contains output_symlinks | |
| // and not output_file_symlinks or output_directory_symlinks, which are deprecated. | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputSymlinksBuilder().setPath("outputs/a/b/link").setTarget("../../foo"); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| // Doesn't check for dangling links, hence download succeeds. | |
| service.downloadOutputs(action, result); | |
| Path path = execRoot.getRelative("outputs/a/b/link"); | |
| assertThat(path.isSymbolicLink()).isTrue(); | |
| assertThat(path.readSymbolicLink()).isEqualTo(PathFragment.create("../../foo")); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_outputSymlinksCompatibility_success() throws Exception { | |
| // Test that download outputs works when the action result contains both output_symlinks | |
| // and output_file_symlinks (or output_directory_symlinks). | |
| // | |
| // Remote Execution Server may set both fields to ensure backward compatibility with | |
| // clients that don't support output_symlinks. | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputFileSymlinksBuilder().setPath("outputs/a/b/link").setTarget("foo"); | |
| builder.addOutputSymlinksBuilder().setPath("outputs/a/b/link").setTarget("foo"); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| // Doesn't check for dangling links, hence download succeeds. | |
| service.downloadOutputs(action, result); | |
| Path path = execRoot.getRelative("outputs/a/b/link"); | |
| assertThat(path.isSymbolicLink()).isTrue(); | |
| assertThat(path.readSymbolicLink()).isEqualTo(PathFragment.create("foo")); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_symlinksInDirectory_success() throws Exception { | |
| Tree tree = | |
| Tree.newBuilder() | |
| .setRoot( | |
| Directory.newBuilder() | |
| .addSymlinks(SymlinkNode.newBuilder().setName("rel").setTarget("foo")) | |
| .addSymlinks(SymlinkNode.newBuilder().setName("abs").setTarget("/bar"))) | |
| .build(); | |
| Digest treeDigest = cache.addContents(remoteActionExecutionContext, tree.toByteArray()); | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputDirectoriesBuilder().setPath("outputs/dir").setTreeDigest(treeDigest); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(remoteOptions); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| // Doesn't check for dangling links, hence download succeeds. | |
| service.downloadOutputs(action, result); | |
| Path relPath = execRoot.getRelative("outputs/dir/rel"); | |
| assertThat(relPath.isSymbolicLink()).isTrue(); | |
| assertThat(relPath.readSymbolicLink()).isEqualTo(PathFragment.create("foo")); | |
| Path absPath = execRoot.getRelative("outputs/dir/abs"); | |
| assertThat(absPath.isSymbolicLink()).isTrue(); | |
| assertThat(absPath.readSymbolicLink()).isEqualTo(PathFragment.create("/bar")); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_absoluteFileSymlink_success() throws Exception { | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputFileSymlinksBuilder().setPath("outputs/foo").setTarget("/abs/link"); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| service.downloadOutputs(action, result); | |
| Path path = execRoot.getRelative("outputs/foo"); | |
| assertThat(path.isSymbolicLink()).isTrue(); | |
| assertThat(path.readSymbolicLink()).isEqualTo(PathFragment.create("/abs/link")); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_absoluteDirectorySymlink_success() throws Exception { | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputDirectorySymlinksBuilder().setPath("outputs/foo").setTarget("/abs/link"); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| service.downloadOutputs(action, result); | |
| Path path = execRoot.getRelative("outputs/foo"); | |
| assertThat(path.readSymbolicLink()).isEqualTo(PathFragment.create("/abs/link")); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_symlinkCollision_error() throws Exception { | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputDirectorySymlinksBuilder().setPath("outputs/foo").setTarget("foo1"); | |
| builder.addOutputSymlinksBuilder().setPath("outputs/foo").setTarget("foo2"); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| Spawn spawn = | |
| new SpawnBuilder("dummy") | |
| .withOutput( | |
| ActionsTestUtil.createArtifactWithRootRelativePath( | |
| artifactRoot, PathFragment.create("foo"))) | |
| .build(); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| IOException expected = | |
| assertThrows(IOException.class, () -> service.downloadOutputs(action, result)); | |
| assertThat(expected.getSuppressed()).isEmpty(); | |
| assertThat(expected).hasMessageThat().contains("Symlink path collision"); | |
| assertThat(expected).hasMessageThat().contains("outputs/foo"); | |
| assertThat(expected).hasMessageThat().contains("foo1"); | |
| assertThat(expected).hasMessageThat().contains("foo2"); | |
| } | |
| @Test | |
| public void downloadOutputs_onActionFailure_downloadEverything() throws Exception { | |
| // Test that all outputs are downloaded for a failed action, even if the outputs mode says | |
| // otherwise. | |
| // arrange | |
| Digest fooDigest = cache.addContents(remoteActionExecutionContext, "foo-contents"); | |
| Digest barDigest = cache.addContents(remoteActionExecutionContext, "bar-contents"); | |
| Tree tree = | |
| Tree.newBuilder() | |
| .setRoot( | |
| Directory.newBuilder() | |
| .addFiles( | |
| FileNode.newBuilder() | |
| .setName("bar") | |
| .setDigest(barDigest) | |
| .setIsExecutable(true))) | |
| .build(); | |
| Digest treeDigest = cache.addContents(remoteActionExecutionContext, tree.toByteArray()); | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputFilesBuilder().setPath("outputs/foo").setDigest(fooDigest); | |
| builder.addOutputDirectoriesBuilder().setPath("outputs/dir").setTreeDigest(treeDigest); | |
| builder.setExitCode(1); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| // act | |
| service.downloadOutputs(action, result); | |
| // assert | |
| assertThat(readContent(execRoot.getRelative("outputs/foo"), UTF_8)).isEqualTo("foo-contents"); | |
| assertThat(readContent(execRoot.getRelative("outputs/dir/bar"), UTF_8)) | |
| .isEqualTo("bar-contents"); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_onDownloadFailure_maintainDirectories() throws Exception { | |
| // Test that output directories created prior to spawn execution are not deleted on failure. | |
| Digest treeFileDigest = | |
| cache.addException("outputs/outputdir/outputfile", new IOException("download failed")); | |
| Tree tree = | |
| Tree.newBuilder() | |
| .setRoot( | |
| Directory.newBuilder() | |
| .addFiles( | |
| FileNode.newBuilder() | |
| .setName("outputfile") | |
| .setDigest(treeFileDigest) | |
| .setIsExecutable(true))) | |
| .build(); | |
| Digest treeDigest = cache.addContents(remoteActionExecutionContext, tree.toByteArray()); | |
| Digest otherFileDigest = | |
| cache.addException("outputs/otherdir/otherfile", new IOException("download failed")); | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputDirectoriesBuilder().setPath("outputs/outputdir").setTreeDigest(treeDigest); | |
| builder.addOutputFiles( | |
| OutputFile.newBuilder().setPath("outputs/otherdir/otherfile").setDigest(otherFileDigest)); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| assertThrows(BulkTransferException.class, () -> service.downloadOutputs(action, result)); | |
| assertThat(cache.getNumFailedDownloads()).isEqualTo(2); | |
| assertThat(execRoot.getRelative("outputs/outputdir").exists()).isTrue(); | |
| assertThat(execRoot.getRelative("outputs/outputdir/outputfile").exists()).isFalse(); | |
| assertThat(execRoot.getRelative("outputs/otherdir").exists()).isTrue(); | |
| assertThat(execRoot.getRelative("outputs/otherdir/otherfile").exists()).isFalse(); | |
| assertThat(context.isLockOutputFilesCalled()).isFalse(); | |
| } | |
| @Test | |
| public void downloadOutputs_onError_waitForRemainingDownloadsToComplete() throws Exception { | |
| // If one or more downloads of output files / directories fail then the code should | |
| // wait for all downloads to have been completed before it tries to clean up partially | |
| // downloaded files. | |
| Digest digest1 = cache.addContents(remoteActionExecutionContext, "file1"); | |
| Digest digest2 = cache.addException("file2", new IOException("download failed")); | |
| Digest digest3 = cache.addContents(remoteActionExecutionContext, "file3"); | |
| ActionResult actionResult = | |
| ActionResult.newBuilder() | |
| .setExitCode(0) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file1").setDigest(digest1)) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file2").setDigest(digest2)) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file3").setDigest(digest3)) | |
| .build(); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(actionResult)); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| BulkTransferException downloadException = | |
| assertThrows(BulkTransferException.class, () -> service.downloadOutputs(action, result)); | |
| assertThat(downloadException.getSuppressed()).hasLength(1); | |
| assertThat(cache.getNumSuccessfulDownloads()).isEqualTo(2); | |
| assertThat(cache.getNumFailedDownloads()).isEqualTo(1); | |
| assertThat(downloadException.getSuppressed()[0]).isInstanceOf(IOException.class); | |
| IOException e = (IOException) downloadException.getSuppressed()[0]; | |
| assertThat(Throwables.getRootCause(e)).hasMessageThat().isEqualTo("download failed"); | |
| assertThat(context.isLockOutputFilesCalled()).isFalse(); | |
| } | |
| @Test | |
| public void downloadOutputs_withMultipleErrors_addsThemAsSuppressed() throws Exception { | |
| Digest digest1 = cache.addContents(remoteActionExecutionContext, "file1"); | |
| Digest digest2 = cache.addException("file2", new IOException("file2 failed")); | |
| Digest digest3 = cache.addException("file3", new IOException("file3 failed")); | |
| ActionResult actionResult = | |
| ActionResult.newBuilder() | |
| .setExitCode(0) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file1").setDigest(digest1)) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file2").setDigest(digest2)) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file3").setDigest(digest3)) | |
| .build(); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(actionResult)); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| BulkTransferException e = | |
| assertThrows(BulkTransferException.class, () -> service.downloadOutputs(action, result)); | |
| assertThat(e.getSuppressed()).hasLength(2); | |
| assertThat(e.getSuppressed()[0]).isInstanceOf(IOException.class); | |
| assertThat(e.getSuppressed()[0]).hasMessageThat().isAnyOf("file2 failed", "file3 failed"); | |
| assertThat(e.getSuppressed()[1]).isInstanceOf(IOException.class); | |
| assertThat(e.getSuppressed()[1]).hasMessageThat().isAnyOf("file2 failed", "file3 failed"); | |
| } | |
| @Test | |
| public void downloadOutputs_withDuplicateIOErrors_doesNotSuppress() throws Exception { | |
| Digest digest1 = cache.addContents(remoteActionExecutionContext, "file1"); | |
| IOException reusedException = new IOException("reused io exception"); | |
| Digest digest2 = cache.addException("file2", reusedException); | |
| Digest digest3 = cache.addException("file3", reusedException); | |
| ActionResult actionResult = | |
| ActionResult.newBuilder() | |
| .setExitCode(0) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file1").setDigest(digest1)) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file2").setDigest(digest2)) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file3").setDigest(digest3)) | |
| .build(); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(actionResult)); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| BulkTransferException downloadException = | |
| assertThrows(BulkTransferException.class, () -> service.downloadOutputs(action, result)); | |
| for (Throwable t : downloadException.getSuppressed()) { | |
| assertThat(t).isInstanceOf(IOException.class); | |
| IOException e = (IOException) t; | |
| assertThat(Throwables.getRootCause(e)).hasMessageThat().isEqualTo("reused io exception"); | |
| } | |
| } | |
| @Test | |
| public void downloadOutputs_withDuplicateInterruptions_doesNotSuppress() throws Exception { | |
| Digest digest1 = cache.addContents(remoteActionExecutionContext, "file1"); | |
| InterruptedException reusedInterruption = new InterruptedException("reused interruption"); | |
| Digest digest2 = cache.addException("file2", reusedInterruption); | |
| Digest digest3 = cache.addException("file3", reusedInterruption); | |
| ActionResult actionResult = | |
| ActionResult.newBuilder() | |
| .setExitCode(0) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file1").setDigest(digest1)) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file2").setDigest(digest2)) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file3").setDigest(digest3)) | |
| .build(); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(actionResult)); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| InterruptedException e = | |
| assertThrows(InterruptedException.class, () -> service.downloadOutputs(action, result)); | |
| assertThat(e.getSuppressed()).isEmpty(); | |
| assertThat(Throwables.getRootCause(e)).hasMessageThat().isEqualTo("reused interruption"); | |
| } | |
| @Test | |
| public void downloadOutputs_withStdoutStderrOnSuccess_writable() throws Exception { | |
| // Tests that fetching stdout/stderr as a digest works and that OutErr is still | |
| // writable afterwards. | |
| FileOutErr childOutErr = outErr.childOutErr(); | |
| FileOutErr spyOutErr = spy(outErr); | |
| FileOutErr spyChildOutErr = spy(childOutErr); | |
| when(spyOutErr.childOutErr()).thenReturn(spyChildOutErr); | |
| Digest digestStdout = cache.addContents(remoteActionExecutionContext, "stdout"); | |
| Digest digestStderr = cache.addContents(remoteActionExecutionContext, "stderr"); | |
| ActionResult actionResult = | |
| ActionResult.newBuilder() | |
| .setExitCode(0) | |
| .setStdoutDigest(digestStdout) | |
| .setStderrDigest(digestStderr) | |
| .build(); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(actionResult)); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn, spyOutErr); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| service.downloadOutputs(action, result); | |
| verify(spyOutErr, times(2)).childOutErr(); | |
| verify(spyChildOutErr).clearOut(); | |
| verify(spyChildOutErr).clearErr(); | |
| assertThat(outErr.getOutputPath().exists()).isTrue(); | |
| assertThat(outErr.getErrorPath().exists()).isTrue(); | |
| try { | |
| outErr.getOutputStream().write(0); | |
| outErr.getErrorStream().write(0); | |
| } catch (IOException err) { | |
| throw new AssertionError("outErr should still be writable after download finished.", err); | |
| } | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_withStdoutStderrOnFailure_writableAndEmpty() throws Exception { | |
| // Test that when downloading stdout/stderr fails the OutErr is still writable | |
| // and empty. | |
| FileOutErr childOutErr = outErr.childOutErr(); | |
| FileOutErr spyOutErr = spy(outErr); | |
| FileOutErr spyChildOutErr = spy(childOutErr); | |
| when(spyOutErr.childOutErr()).thenReturn(spyChildOutErr); | |
| // Don't add stdout/stderr as a known blob to the remote cache so that downloading it will fail | |
| Digest digestStdout = digestUtil.computeAsUtf8("stdout"); | |
| Digest digestStderr = digestUtil.computeAsUtf8("stderr"); | |
| ActionResult actionResult = | |
| ActionResult.newBuilder() | |
| .setExitCode(0) | |
| .setStdoutDigest(digestStdout) | |
| .setStderrDigest(digestStderr) | |
| .build(); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(actionResult)); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn, spyOutErr); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| assertThrows(BulkTransferException.class, () -> service.downloadOutputs(action, result)); | |
| verify(spyOutErr, times(2)).childOutErr(); | |
| verify(spyChildOutErr).clearOut(); | |
| verify(spyChildOutErr).clearErr(); | |
| assertThat(outErr.getOutputPath().exists()).isFalse(); | |
| assertThat(outErr.getErrorPath().exists()).isFalse(); | |
| try { | |
| outErr.getOutputStream().write(0); | |
| outErr.getErrorStream().write(0); | |
| } catch (IOException err) { | |
| throw new AssertionError("outErr should still be writable after download failed.", err); | |
| } | |
| assertThat(context.isLockOutputFilesCalled()).isFalse(); | |
| } | |
| @Test | |
| public void downloadOutputs_outputNameClashesWithTempName_success() throws Exception { | |
| Digest d1 = cache.addContents(remoteActionExecutionContext, "content1"); | |
| Digest d2 = cache.addContents(remoteActionExecutionContext, "content2"); | |
| ActionResult r = | |
| ActionResult.newBuilder() | |
| .setExitCode(0) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/foo.tmp").setDigest(d1)) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/foo").setDigest(d2)) | |
| .build(); | |
| RemoteActionResult result = RemoteActionResult.createFromCache(CachedActionResult.remote(r)); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(ArgumentMatchers.<PathFragment>any())) | |
| .thenReturn(true); | |
| service.downloadOutputs(action, result); | |
| assertThat(readContent(execRoot.getRelative("outputs/foo.tmp"), UTF_8)).isEqualTo("content1"); | |
| assertThat(readContent(execRoot.getRelative("outputs/foo"), UTF_8)).isEqualTo("content2"); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_outputFiles_partialDownload() throws Exception { | |
| // arrange | |
| Digest d1 = cache.addContents(remoteActionExecutionContext, "content1"); | |
| Digest d2 = cache.addContents(remoteActionExecutionContext, "content2"); | |
| ActionResult r = | |
| ActionResult.newBuilder() | |
| .setExitCode(0) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file1").setDigest(d1)) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file2").setDigest(d2)) | |
| .build(); | |
| RemoteActionResult result = RemoteActionResult.createFromCache(CachedActionResult.remote(r)); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(PathFragment.create("outputs/file1"))) | |
| .thenReturn(true); | |
| // act | |
| InMemoryOutput inMemoryOutput = service.downloadOutputs(action, result); | |
| // assert | |
| assertThat(inMemoryOutput).isNull(); | |
| RemoteActionFileSystem actionFs = context.getActionFileSystem(); | |
| assertThat(actionFs.getDigest(execRoot.asFragment().getRelative("outputs/file1"))) | |
| .isEqualTo(toBinaryDigest(d1)); | |
| assertThat(actionFs.getDigest(execRoot.asFragment().getRelative("outputs/file2"))) | |
| .isEqualTo(toBinaryDigest(d2)); | |
| assertThat(execRoot.getRelative("outputs/file1").exists()).isTrue(); | |
| assertThat(execRoot.getRelative("outputs/file2").exists()).isFalse(); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_outputFiles_noDownload() throws Exception { | |
| // arrange | |
| Digest d1 = cache.addContents(remoteActionExecutionContext, "content1"); | |
| Digest d2 = cache.addContents(remoteActionExecutionContext, "content2"); | |
| ActionResult r = | |
| ActionResult.newBuilder() | |
| .setExitCode(0) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file1").setDigest(d1)) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file2").setDigest(d2)) | |
| .build(); | |
| RemoteActionResult result = RemoteActionResult.createFromCache(CachedActionResult.remote(r)); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| // act | |
| InMemoryOutput inMemoryOutput = service.downloadOutputs(action, result); | |
| // assert | |
| assertThat(inMemoryOutput).isNull(); | |
| RemoteActionFileSystem actionFs = context.getActionFileSystem(); | |
| assertThat(actionFs.getDigest(execRoot.asFragment().getRelative("outputs/file1"))) | |
| .isEqualTo(toBinaryDigest(d1)); | |
| assertThat(actionFs.getDigest(execRoot.asFragment().getRelative("outputs/file2"))) | |
| .isEqualTo(toBinaryDigest(d2)); | |
| assertThat(execRoot.getRelative("outputs/file1").exists()).isFalse(); | |
| assertThat(execRoot.getRelative("outputs/file2").exists()).isFalse(); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_outputDirectories_partialDownload() throws Exception { | |
| // arrange | |
| // Output Directory: | |
| // dir/file1 | |
| // dir/a/file2 | |
| Digest d1 = cache.addContents(remoteActionExecutionContext, "content1"); | |
| Digest d2 = cache.addContents(remoteActionExecutionContext, "content2"); | |
| FileNode file1 = | |
| FileNode.newBuilder().setName("file1").setDigest(d1).setIsExecutable(true).build(); | |
| FileNode file2 = | |
| FileNode.newBuilder().setName("file2").setDigest(d2).setIsExecutable(true).build(); | |
| Directory a = Directory.newBuilder().addFiles(file2).build(); | |
| Digest da = cache.addContents(remoteActionExecutionContext, a); | |
| Directory root = | |
| Directory.newBuilder() | |
| .addFiles(file1) | |
| .addDirectories(DirectoryNode.newBuilder().setName("a").setDigest(da)) | |
| .build(); | |
| Tree t = Tree.newBuilder().setRoot(root).addChildren(a).build(); | |
| Digest dt = cache.addContents(remoteActionExecutionContext, t); | |
| ActionResult r = | |
| ActionResult.newBuilder() | |
| .setExitCode(0) | |
| .addOutputDirectories( | |
| OutputDirectory.newBuilder().setPath("outputs/dir").setTreeDigest(dt)) | |
| .build(); | |
| RemoteActionResult result = RemoteActionResult.createFromCache(CachedActionResult.remote(r)); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(PathFragment.create("outputs/dir/file1"))) | |
| .thenReturn(true); | |
| // act | |
| InMemoryOutput inMemoryOutput = service.downloadOutputs(action, result); | |
| // assert | |
| assertThat(inMemoryOutput).isNull(); | |
| RemoteActionFileSystem actionFs = context.getActionFileSystem(); | |
| assertThat(actionFs.getDigest(execRoot.asFragment().getRelative("outputs/dir/file1"))) | |
| .isEqualTo(toBinaryDigest(d1)); | |
| assertThat(actionFs.getDigest(execRoot.asFragment().getRelative("outputs/dir/a/file2"))) | |
| .isEqualTo(toBinaryDigest(d2)); | |
| assertThat(execRoot.getRelative("outputs/dir/file1").exists()).isTrue(); | |
| assertThat(execRoot.getRelative("outputs/dir/a").exists()).isFalse(); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_outputDirectories_noDownload() throws Exception { | |
| // arrange | |
| // Output Directory: | |
| // dir/file1 | |
| // dir/a/file2 | |
| Digest d1 = cache.addContents(remoteActionExecutionContext, "content1"); | |
| Digest d2 = cache.addContents(remoteActionExecutionContext, "content2"); | |
| FileNode file1 = | |
| FileNode.newBuilder().setName("file1").setDigest(d1).setIsExecutable(true).build(); | |
| FileNode file2 = | |
| FileNode.newBuilder().setName("file2").setDigest(d2).setIsExecutable(true).build(); | |
| Directory a = Directory.newBuilder().addFiles(file2).build(); | |
| Digest da = cache.addContents(remoteActionExecutionContext, a); | |
| Directory root = | |
| Directory.newBuilder() | |
| .addFiles(file1) | |
| .addDirectories(DirectoryNode.newBuilder().setName("a").setDigest(da)) | |
| .build(); | |
| Tree t = Tree.newBuilder().setRoot(root).addChildren(a).build(); | |
| Digest dt = cache.addContents(remoteActionExecutionContext, t); | |
| ActionResult r = | |
| ActionResult.newBuilder() | |
| .setExitCode(0) | |
| .addOutputDirectories( | |
| OutputDirectory.newBuilder().setPath("outputs/dir").setTreeDigest(dt)) | |
| .build(); | |
| RemoteActionResult result = RemoteActionResult.createFromCache(CachedActionResult.remote(r)); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| // act | |
| InMemoryOutput inMemoryOutput = service.downloadOutputs(action, result); | |
| // assert | |
| assertThat(inMemoryOutput).isNull(); | |
| RemoteActionFileSystem actionFs = context.getActionFileSystem(); | |
| assertThat(actionFs.getDigest(execRoot.asFragment().getRelative("outputs/dir/file1"))) | |
| .isEqualTo(toBinaryDigest(d1)); | |
| assertThat(actionFs.getDigest(execRoot.asFragment().getRelative("outputs/dir/a/file2"))) | |
| .isEqualTo(toBinaryDigest(d2)); | |
| assertThat(execRoot.getRelative("outputs/dir/file1").exists()).isFalse(); | |
| assertThat(execRoot.getRelative("outputs/dir/a").exists()).isFalse(); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_outputDirectories_doNotDownload_failProperly() throws Exception { | |
| // Test that we properly fail when downloading the metadata of an output | |
| // directory fails | |
| // arrange | |
| // Output Directory: | |
| // dir/file1 | |
| // dir/a/file2 | |
| Digest d1 = cache.addContents(remoteActionExecutionContext, "content1"); | |
| Digest d2 = cache.addContents(remoteActionExecutionContext, "content2"); | |
| FileNode file1 = | |
| FileNode.newBuilder().setName("file1").setDigest(d1).setIsExecutable(true).build(); | |
| FileNode file2 = | |
| FileNode.newBuilder().setName("file2").setDigest(d2).setIsExecutable(true).build(); | |
| Directory a = Directory.newBuilder().addFiles(file2).build(); | |
| Digest da = cache.addContents(remoteActionExecutionContext, a); | |
| Directory root = | |
| Directory.newBuilder() | |
| .addFiles(file1) | |
| .addDirectories(DirectoryNode.newBuilder().setName("a").setDigest(da)) | |
| .build(); | |
| Tree t = Tree.newBuilder().setRoot(root).addChildren(a).build(); | |
| // Downloading the tree will fail | |
| IOException downloadTreeException = new IOException("entry not found"); | |
| Digest dt = cache.addException(t, downloadTreeException); | |
| ActionResult r = | |
| ActionResult.newBuilder() | |
| .setExitCode(0) | |
| .addOutputDirectories( | |
| OutputDirectory.newBuilder().setPath("outputs/dir").setTreeDigest(dt)) | |
| .build(); | |
| RemoteActionResult result = RemoteActionResult.createFromCache(CachedActionResult.remote(r)); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| // act | |
| BulkTransferException e = | |
| assertThrows(BulkTransferException.class, () -> service.downloadOutputs(action, result)); | |
| // assert | |
| assertThat(e.getSuppressed()).hasLength(1); | |
| assertThat(e.getSuppressed()[0]).isEqualTo(downloadTreeException); | |
| assertThat(context.isLockOutputFilesCalled()).isFalse(); | |
| } | |
| @Test | |
| public void downloadOutputs_nonInlinedStdoutAndStderr_alwaysDownload() throws Exception { | |
| // arrange | |
| Digest dOut = cache.addContents(remoteActionExecutionContext, "stdout"); | |
| Digest dErr = cache.addContents(remoteActionExecutionContext, "stderr"); | |
| ActionResult r = | |
| ActionResult.newBuilder() | |
| .setExitCode(0) | |
| .setStdoutDigest(dOut) | |
| .setStderrDigest(dErr) | |
| .build(); | |
| RemoteActionResult result = RemoteActionResult.createFromCache(CachedActionResult.remote(r)); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| // act | |
| InMemoryOutput inMemoryOutput = service.downloadOutputs(action, result); | |
| // assert | |
| assertThat(inMemoryOutput).isNull(); | |
| RemoteActionFileSystem actionFs = context.getActionFileSystem(); | |
| assertThat(actionFs.getDigest(outErr.getOutputPathFragment())).isEqualTo(toBinaryDigest(dOut)); | |
| assertThat(actionFs.getDigest(outErr.getErrorPathFragment())).isEqualTo(toBinaryDigest(dErr)); | |
| assertThat(outErr.outAsLatin1()).isEqualTo("stdout"); | |
| assertThat(outErr.errAsLatin1()).isEqualTo("stderr"); | |
| Path outputBase = checkNotNull(artifactRoot.getRoot().asPath()); | |
| assertThat(outputBase.readdir(Symlinks.NOFOLLOW)).isEmpty(); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_inlinedStdoutAndStderr_alwaysDownload() throws Exception { | |
| // arrange | |
| Digest dOut = digestUtil.compute("stdout".getBytes(UTF_8)); | |
| Digest dErr = digestUtil.compute("stderr".getBytes(UTF_8)); | |
| ActionResult r = | |
| ActionResult.newBuilder() | |
| .setExitCode(0) | |
| .setStdoutRaw(ByteString.copyFromUtf8("stdout")) | |
| .setStderrRaw(ByteString.copyFromUtf8("stderr")) | |
| .build(); | |
| RemoteActionResult result = RemoteActionResult.createFromCache(CachedActionResult.remote(r)); | |
| Spawn spawn = newSpawnFromResult(result); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| // act | |
| InMemoryOutput inMemoryOutput = service.downloadOutputs(action, result); | |
| // assert | |
| assertThat(inMemoryOutput).isNull(); | |
| RemoteActionFileSystem actionFs = context.getActionFileSystem(); | |
| assertThat(actionFs.getDigest(outErr.getOutputPathFragment())).isEqualTo(toBinaryDigest(dOut)); | |
| assertThat(actionFs.getDigest(outErr.getErrorPathFragment())).isEqualTo(toBinaryDigest(dErr)); | |
| assertThat(inMemoryOutput).isNull(); | |
| assertThat(outErr.outAsLatin1()).isEqualTo("stdout"); | |
| assertThat(outErr.errAsLatin1()).isEqualTo("stderr"); | |
| Path outputBase = checkNotNull(artifactRoot.getRoot().asPath()); | |
| assertThat(outputBase.readdir(Symlinks.NOFOLLOW)).isEmpty(); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_inMemoryOutput_doNotDownload() throws Exception { | |
| // Test that downloading an in memory output works | |
| // arrange | |
| Digest d1 = cache.addContents(remoteActionExecutionContext, "content1"); | |
| Digest d2 = cache.addContents(remoteActionExecutionContext, "content2"); | |
| ActionResult r = | |
| ActionResult.newBuilder() | |
| .setExitCode(0) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file1").setDigest(d1)) | |
| .addOutputFiles(OutputFile.newBuilder().setPath("outputs/file2").setDigest(d2)) | |
| .build(); | |
| RemoteActionResult result = RemoteActionResult.createFromCache(CachedActionResult.remote(r)); | |
| // a1 should be provided as an InMemoryOutput | |
| PathFragment inMemoryOutputPathFragment = PathFragment.create("outputs/file1"); | |
| Spawn spawn = newSpawnFromResultWithInMemoryOutput(result, inMemoryOutputPathFragment); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| // act | |
| InMemoryOutput inMemoryOutput = service.downloadOutputs(action, result); | |
| // assert | |
| assertThat(inMemoryOutput).isNotNull(); | |
| ByteString expectedContents = ByteString.copyFrom("content1", UTF_8); | |
| assertThat(inMemoryOutput.getContents()).isEqualTo(expectedContents); | |
| assertThat(inMemoryOutput.getOutput()) | |
| .isEqualTo(ActionsTestUtil.createArtifact(artifactRoot, "file1")); | |
| RemoteActionFileSystem actionFs = context.getActionFileSystem(); | |
| assertThat(actionFs.getDigest(execRoot.asFragment().getRelative("outputs/file1"))) | |
| .isEqualTo(toBinaryDigest(d1)); | |
| assertThat(actionFs.getDigest(execRoot.asFragment().getRelative("outputs/file2"))) | |
| .isEqualTo(toBinaryDigest(d2)); | |
| assertThat(execRoot.getRelative("outputs/file1").exists()).isFalse(); | |
| assertThat(execRoot.getRelative("outputs/file2").exists()).isFalse(); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void downloadOutputs_missingInMemoryOutput_returnsNull() throws Exception { | |
| // Test that downloadOutputs returns null if a declared in-memory output is missing from action | |
| // result. | |
| // arrange | |
| ActionResult r = ActionResult.newBuilder().setExitCode(0).build(); | |
| RemoteActionResult result = RemoteActionResult.createFromCache(CachedActionResult.remote(r)); | |
| Artifact a1 = ActionsTestUtil.createArtifact(artifactRoot, "file1"); | |
| // set file1 as declared output but not mandatory output | |
| Spawn spawn = | |
| new SimpleSpawn( | |
| new FakeOwner("foo", "bar", "//dummy:label"), | |
| /* arguments= */ ImmutableList.of(), | |
| /* environment= */ ImmutableMap.of(), | |
| /* executionInfo= */ ImmutableMap.of(REMOTE_EXECUTION_INLINE_OUTPUTS, "outputs/file1"), | |
| /* filesetMappings= */ ImmutableMap.of(), | |
| /* inputs= */ NestedSetBuilder.emptySet(Order.STABLE_ORDER), | |
| /* tools= */ NestedSetBuilder.emptySet(Order.STABLE_ORDER), | |
| /* outputs= */ ImmutableSet.of(a1), | |
| /* mandatoryOutputs= */ ImmutableSet.of(), | |
| ResourceSet.ZERO); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| // act | |
| InMemoryOutput inMemoryOutput = service.downloadOutputs(action, result); | |
| // assert | |
| assertThat(inMemoryOutput).isNull(); | |
| // The in memory file metadata also should not have been injected. | |
| RemoteActionFileSystem actionFs = context.getActionFileSystem(); | |
| assertThat(actionFs.exists(execRoot.asFragment().getRelative(a1.getExecPath()))).isFalse(); | |
| } | |
| @Test | |
| public void downloadOutputs_missingMandatoryOutputs_reportError() throws Exception { | |
| // Test that an AC which misses mandatory outputs is correctly ignored. | |
| Digest fooDigest = cache.addContents(remoteActionExecutionContext, "foo-contents"); | |
| ActionResult.Builder builder = ActionResult.newBuilder(); | |
| builder.addOutputFilesBuilder().setPath("outputs/foo").setDigest(fooDigest); | |
| RemoteActionResult result = | |
| RemoteActionResult.createFromCache(CachedActionResult.remote(builder.build())); | |
| ImmutableSet.Builder<Artifact> outputs = ImmutableSet.builder(); | |
| ImmutableList<String> expectedOutputFiles = ImmutableList.of("outputs/foo", "outputs/bar"); | |
| for (String outputFile : expectedOutputFiles) { | |
| Path path = remotePathResolver.outputPathToLocalPath(outputFile); | |
| Artifact output = ActionsTestUtil.createArtifact(artifactRoot, path); | |
| outputs.add(output); | |
| } | |
| Spawn spawn = newSpawn(ImmutableMap.of(), outputs.build()); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| createOutputDirectories(spawn); | |
| IOException error = | |
| assertThrows(IOException.class, () -> service.downloadOutputs(action, result)); | |
| assertThat(error).hasMessageThat().containsMatch("mandatory output .+ was not created"); | |
| } | |
| @Test | |
| public void downloadOutputs_pathUnmapped() throws Exception { | |
| // Test that the output of a remote action with path mapping applied is downloaded into the | |
| // correct unmapped local path. | |
| Digest d1 = cache.addContents(remoteActionExecutionContext, "content1"); | |
| Digest d2 = cache.addContents(remoteActionExecutionContext, "content2"); | |
| Artifact output1 = ActionsTestUtil.createArtifact(artifactRoot, "bin/config/dir/output1"); | |
| Artifact output2 = ActionsTestUtil.createArtifact(artifactRoot, "bin/other_dir/output2"); | |
| ActionResult r = | |
| ActionResult.newBuilder() | |
| .setExitCode(0) | |
| // The action result includes the mapped paths. | |
| .addOutputFiles( | |
| OutputFile.newBuilder().setPath("outputs/bin/dir/output1").setDigest(d1)) | |
| .addOutputFiles( | |
| OutputFile.newBuilder().setPath("outputs/bin/other_dir/output2").setDigest(d2)) | |
| .build(); | |
| PathMapper pathMapper = | |
| execPath -> PathFragment.create(execPath.getPathString().replaceAll("config/", "")); | |
| Spawn spawn = | |
| new SpawnBuilder("unused") | |
| .withOutput(output1) | |
| .withOutput(output2) | |
| .setPathMapper(pathMapper) | |
| .build(); | |
| RemoteActionResult result = RemoteActionResult.createFromCache(CachedActionResult.remote(r)); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| when(remoteOutputChecker.shouldDownloadOutput(output1.getExecPath())).thenReturn(true); | |
| when(remoteOutputChecker.shouldDownloadOutput(output2.getExecPath())).thenReturn(true); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| InMemoryOutput inMemoryOutput = service.downloadOutputs(action, result); | |
| assertThat(inMemoryOutput).isNull(); | |
| RemoteActionFileSystem actionFs = context.getActionFileSystem(); | |
| assertThat(actionFs.getDigest(output1.getPath().asFragment())).isEqualTo(toBinaryDigest(d1)); | |
| assertThat(readContent(output1.getPath(), UTF_8)).isEqualTo("content1"); | |
| assertThat(actionFs.getDigest(output2.getPath().asFragment())).isEqualTo(toBinaryDigest(d2)); | |
| assertThat(readContent(output2.getPath(), UTF_8)).isEqualTo("content2"); | |
| assertThat(context.isLockOutputFilesCalled()).isTrue(); | |
| } | |
| @Test | |
| public void uploadOutputs_uploadDirectory_works() throws Exception { | |
| // Test that uploading a directory works. | |
| // arrange | |
| Digest fooDigest = | |
| fakeFileCache.createScratchInput(ActionInputHelper.fromPath("outputs/a/foo"), "xyz"); | |
| Digest quxDigest = | |
| fakeFileCache.createScratchInput(ActionInputHelper.fromPath("outputs/bar/qux"), "abc"); | |
| Digest barDigest = | |
| fakeFileCache.createScratchInputDirectory( | |
| ActionInputHelper.fromPath("outputs/bar"), | |
| Tree.newBuilder() | |
| .setRoot( | |
| Directory.newBuilder() | |
| .addFiles( | |
| FileNode.newBuilder() | |
| .setName("qux") | |
| .setDigest(quxDigest) | |
| .setIsExecutable(true) | |
| .build()) | |
| .build()) | |
| .build()); | |
| Path fooFile = execRoot.getRelative("outputs/a/foo"); | |
| Path quxFile = execRoot.getRelative("outputs/bar/qux"); | |
| quxFile.setExecutable(true); | |
| Path barDir = execRoot.getRelative("outputs/bar"); | |
| Artifact outputFile = ActionsTestUtil.createArtifact(artifactRoot, fooFile); | |
| Artifact outputDirectory = | |
| ActionsTestUtil.createTreeArtifactWithGeneratingAction( | |
| artifactRoot, barDir.relativeTo(execRoot)); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| Spawn spawn = newSpawn(ImmutableMap.of(), ImmutableSet.of(outputFile, outputDirectory)); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| SpawnResult spawnResult = | |
| new SpawnResult.Builder() | |
| .setExitCode(0) | |
| .setStatus(SpawnResult.Status.SUCCESS) | |
| .setRunnerName("test") | |
| .build(); | |
| // act | |
| UploadManifest manifest = service.buildUploadManifest(action, spawnResult); | |
| service.uploadOutputs(action, spawnResult); | |
| // assert | |
| ActionResult.Builder expectedResult = ActionResult.newBuilder(); | |
| expectedResult | |
| .addOutputFilesBuilder() | |
| .setPath("outputs/a/foo") | |
| .setDigest(fooDigest) | |
| .setIsExecutable(true); | |
| expectedResult | |
| .addOutputDirectoriesBuilder() | |
| .setPath("outputs/bar") | |
| .setTreeDigest(barDigest) | |
| .setIsTopologicallySorted(true); | |
| assertThat(manifest.getActionResult()).isEqualTo(expectedResult.build()); | |
| ImmutableList<Digest> toQuery = ImmutableList.of(fooDigest, quxDigest, barDigest); | |
| assertThat(getFromFuture(cache.findMissingDigests(remoteActionExecutionContext, toQuery))) | |
| .isEmpty(); | |
| } | |
| @Test | |
| public void uploadOutputs_uploadEmptyDirectory_works() throws Exception { | |
| // Test that uploading an empty directory works. | |
| // arrange | |
| Digest barDigest = | |
| fakeFileCache.createScratchInputDirectory( | |
| ActionInputHelper.fromPath("outputs/bar"), | |
| Tree.newBuilder().setRoot(Directory.getDefaultInstance()).build()); | |
| Path barDir = execRoot.getRelative("outputs/bar"); | |
| Artifact outputDirectory = | |
| ActionsTestUtil.createTreeArtifactWithGeneratingAction( | |
| artifactRoot, barDir.relativeTo(execRoot)); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| Spawn spawn = newSpawn(ImmutableMap.of(), ImmutableSet.of(outputDirectory)); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| SpawnResult spawnResult = | |
| new SpawnResult.Builder() | |
| .setExitCode(0) | |
| .setStatus(SpawnResult.Status.SUCCESS) | |
| .setRunnerName("test") | |
| .build(); | |
| // act | |
| UploadManifest manifest = service.buildUploadManifest(action, spawnResult); | |
| service.uploadOutputs(action, spawnResult); | |
| // assert | |
| ActionResult.Builder expectedResult = ActionResult.newBuilder(); | |
| expectedResult | |
| .addOutputDirectoriesBuilder() | |
| .setPath("outputs/bar") | |
| .setTreeDigest(barDigest) | |
| .setIsTopologicallySorted(true); | |
| assertThat(manifest.getActionResult()).isEqualTo(expectedResult.build()); | |
| assertThat( | |
| getFromFuture( | |
| cache.findMissingDigests( | |
| remoteActionExecutionContext, ImmutableList.of(barDigest)))) | |
| .isEmpty(); | |
| } | |
| @Test | |
| public void uploadOutputs_uploadNestedDirectory_works() throws Exception { | |
| // Test that uploading a nested directory works. | |
| // arrange | |
| final Digest wobbleDigest = | |
| fakeFileCache.createScratchInput( | |
| ActionInputHelper.fromPath("outputs/bar/test/wobble"), "xyz"); | |
| final Digest quxDigest = | |
| fakeFileCache.createScratchInput(ActionInputHelper.fromPath("outputs/bar/qux"), "abc"); | |
| final Directory testDirMessage = | |
| Directory.newBuilder() | |
| .addFiles( | |
| FileNode.newBuilder() | |
| .setName("wobble") | |
| .setDigest(wobbleDigest) | |
| .setIsExecutable(true) | |
| .build()) | |
| .build(); | |
| final Digest testDigest = digestUtil.compute(testDirMessage); | |
| final Tree barTree = | |
| Tree.newBuilder() | |
| .setRoot( | |
| Directory.newBuilder() | |
| .addFiles( | |
| FileNode.newBuilder() | |
| .setName("qux") | |
| .setDigest(quxDigest) | |
| .setIsExecutable(true)) | |
| .addDirectories( | |
| DirectoryNode.newBuilder().setName("test").setDigest(testDigest))) | |
| .addChildren(testDirMessage) | |
| .build(); | |
| final Digest barDigest = | |
| fakeFileCache.createScratchInputDirectory( | |
| ActionInputHelper.fromPath("outputs/bar"), barTree); | |
| final Path quxFile = execRoot.getRelative("outputs/bar/qux"); | |
| quxFile.setExecutable(true); | |
| final Path barDir = execRoot.getRelative("outputs/bar"); | |
| Artifact outputDirectory = | |
| ActionsTestUtil.createTreeArtifactWithGeneratingAction( | |
| artifactRoot, barDir.relativeTo(execRoot)); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| Spawn spawn = newSpawn(ImmutableMap.of(), ImmutableSet.of(outputDirectory)); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| SpawnResult spawnResult = | |
| new SpawnResult.Builder() | |
| .setExitCode(0) | |
| .setStatus(SpawnResult.Status.SUCCESS) | |
| .setRunnerName("test") | |
| .build(); | |
| // act | |
| UploadManifest manifest = service.buildUploadManifest(action, spawnResult); | |
| service.uploadOutputs(action, spawnResult); | |
| // assert | |
| ActionResult.Builder expectedResult = ActionResult.newBuilder(); | |
| expectedResult | |
| .addOutputDirectoriesBuilder() | |
| .setPath("outputs/bar") | |
| .setTreeDigest(barDigest) | |
| .setIsTopologicallySorted(true); | |
| assertThat(manifest.getActionResult()).isEqualTo(expectedResult.build()); | |
| ImmutableList<Digest> toQuery = ImmutableList.of(wobbleDigest, quxDigest, barDigest); | |
| assertThat(getFromFuture(cache.findMissingDigests(remoteActionExecutionContext, toQuery))) | |
| .isEmpty(); | |
| } | |
| private void doUploadDanglingSymlink(PathFragment targetPath) throws Exception { | |
| // arrange | |
| Path linkPath = execRoot.getRelative("outputs/link"); | |
| linkPath.createSymbolicLink(targetPath); | |
| Artifact outputSymlink = | |
| ActionsTestUtil.createUnresolvedSymlinkArtifactWithExecPath( | |
| artifactRoot, linkPath.relativeTo(execRoot)); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| Spawn spawn = newSpawn(ImmutableMap.of(), ImmutableSet.of(outputSymlink)); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| SpawnResult spawnResult = | |
| new SpawnResult.Builder() | |
| .setExitCode(0) | |
| .setStatus(SpawnResult.Status.SUCCESS) | |
| .setRunnerName("test") | |
| .build(); | |
| // act | |
| UploadManifest manifest = service.buildUploadManifest(action, spawnResult); | |
| service.uploadOutputs(action, spawnResult); | |
| // assert | |
| ActionResult.Builder expectedResult = ActionResult.newBuilder(); | |
| expectedResult | |
| .addOutputFileSymlinksBuilder() | |
| .setPath("outputs/link") | |
| .setTarget(targetPath.toString()); | |
| expectedResult | |
| .addOutputSymlinksBuilder() | |
| .setPath("outputs/link") | |
| .setTarget(targetPath.toString()); | |
| assertThat(manifest.getActionResult()).isEqualTo(expectedResult.build()); | |
| } | |
| @Test | |
| public void uploadOutputs_uploadRelativeDanglingSymlink() throws Exception { | |
| doUploadDanglingSymlink(PathFragment.create("some/path")); | |
| } | |
| @Test | |
| public void uploadOutputs_uploadAbsoluteDanglingSymlink() throws Exception { | |
| when(cache.getCacheCapabilities()) | |
| .thenReturn( | |
| CacheCapabilities.newBuilder() | |
| .setSymlinkAbsolutePathStrategy(SymlinkAbsolutePathStrategy.Value.ALLOWED) | |
| .build()); | |
| doUploadDanglingSymlink(PathFragment.create("/some/path")); | |
| } | |
| @Test | |
| public void uploadOutputs_emptyOutputs_doNotPerformUpload() throws Exception { | |
| // Test that uploading an empty output does not try to perform an upload. | |
| // arrange | |
| Digest emptyDigest = | |
| fakeFileCache.createScratchInput(ActionInputHelper.fromPath("outputs/bar/test/wobble"), ""); | |
| Path file = execRoot.getRelative("outputs/bar/test/wobble"); | |
| Artifact outputFile = ActionsTestUtil.createArtifact(artifactRoot, file); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| Spawn spawn = newSpawn(ImmutableMap.of(), ImmutableSet.of(outputFile)); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| SpawnResult spawnResult = | |
| new SpawnResult.Builder() | |
| .setExitCode(0) | |
| .setStatus(SpawnResult.Status.SUCCESS) | |
| .setRunnerName("test") | |
| .build(); | |
| // act | |
| service.uploadOutputs(action, spawnResult); | |
| // assert | |
| assertThat( | |
| getFromFuture( | |
| cache.findMissingDigests( | |
| remoteActionExecutionContext, ImmutableSet.of(emptyDigest)))) | |
| .containsExactly(emptyDigest); | |
| } | |
| @Test | |
| public void uploadOutputs_uploadFails_printWarning() throws Exception { | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| Spawn spawn = newSpawn(ImmutableMap.of(), ImmutableSet.of()); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| SpawnResult spawnResult = | |
| new SpawnResult.Builder() | |
| .setExitCode(0) | |
| .setStatus(Status.SUCCESS) | |
| .setRunnerName("test") | |
| .build(); | |
| doReturn(Futures.immediateFailedFuture(new IOException("cache down"))) | |
| .when(cache) | |
| .uploadActionResult(any(), any(), any()); | |
| service.uploadOutputs(action, spawnResult); | |
| assertThat(eventHandler.getEvents()).hasSize(1); | |
| Event evt = eventHandler.getEvents().get(0); | |
| assertThat(evt.getKind()).isEqualTo(EventKind.WARNING); | |
| assertThat(evt.getMessage()).contains("cache down"); | |
| } | |
| @Test | |
| public void uploadOutputs_firesUploadEvents() throws Exception { | |
| Digest digest = | |
| fakeFileCache.createScratchInput(ActionInputHelper.fromPath("outputs/file"), "content"); | |
| Path file = execRoot.getRelative("outputs/file"); | |
| Artifact outputFile = ActionsTestUtil.createArtifact(artifactRoot, file); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| Spawn spawn = newSpawn(ImmutableMap.of(), ImmutableSet.of(outputFile)); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| SpawnResult spawnResult = | |
| new SpawnResult.Builder() | |
| .setExitCode(0) | |
| .setStatus(SpawnResult.Status.SUCCESS) | |
| .setRunnerName("test") | |
| .build(); | |
| service.uploadOutputs(action, spawnResult); | |
| assertThat(eventHandler.getPosts()) | |
| .containsAtLeast( | |
| ActionUploadStartedEvent.create(spawn.getResourceOwner(), Store.CAS, digest), | |
| ActionUploadFinishedEvent.create(spawn.getResourceOwner(), Store.CAS, digest), | |
| ActionUploadStartedEvent.create( | |
| spawn.getResourceOwner(), Store.AC, action.getActionKey().getDigest()), | |
| ActionUploadFinishedEvent.create( | |
| spawn.getResourceOwner(), Store.AC, action.getActionKey().getDigest())); | |
| } | |
| @Test | |
| public void uploadOutputs_missingMandatoryOutputs_dontUpload() throws Exception { | |
| Path file = execRoot.getRelative("outputs/file"); | |
| Artifact outputFile = ActionsTestUtil.createArtifact(artifactRoot, file); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| Spawn spawn = newSpawn(ImmutableMap.of(), ImmutableSet.of(outputFile)); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| SpawnResult spawnResult = | |
| new SpawnResult.Builder() | |
| .setExitCode(0) | |
| .setStatus(SpawnResult.Status.SUCCESS) | |
| .setRunnerName("test") | |
| .build(); | |
| service.uploadOutputs(action, spawnResult); | |
| // assert | |
| assertThat(cache.getNumFindMissingDigests()).isEmpty(); | |
| } | |
| @Test | |
| public void uploadInputsIfNotPresent_deduplicateFindMissingBlobCalls() throws Exception { | |
| int taskCount = 100; | |
| ExecutorService executorService = Executors.newFixedThreadPool(taskCount); | |
| AtomicReference<Throwable> error = new AtomicReference<>(null); | |
| Semaphore semaphore = new Semaphore(0); | |
| ActionInput input = ActionInputHelper.fromPath("inputs/foo"); | |
| Digest inputDigest = fakeFileCache.createScratchInput(input, "input-foo"); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| Spawn spawn = | |
| newSpawn( | |
| ImmutableMap.of(), | |
| ImmutableSet.of(), | |
| NestedSetBuilder.create(Order.STABLE_ORDER, input)); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| for (int i = 0; i < taskCount; ++i) { | |
| executorService.execute( | |
| () -> { | |
| try { | |
| service.uploadInputsIfNotPresent(action, /* force= */ false); | |
| } catch (Throwable e) { | |
| if (e instanceof InterruptedException) { | |
| Thread.currentThread().interrupt(); | |
| } | |
| error.set(e); | |
| } finally { | |
| semaphore.release(); | |
| } | |
| }); | |
| } | |
| semaphore.acquire(taskCount); | |
| assertThat(error.get()).isNull(); | |
| assertThat(cache.getNumFindMissingDigests()).containsEntry(inputDigest, 1); | |
| for (Integer num : cache.getNumFindMissingDigests().values()) { | |
| assertThat(num).isEqualTo(1); | |
| } | |
| } | |
| @Test | |
| public void uploadInputsIfNotPresent_sameInputs_interruptOne_keepOthers() throws Exception { | |
| int taskCount = 100; | |
| ExecutorService executorService = Executors.newFixedThreadPool(taskCount); | |
| AtomicReference<Throwable> error = new AtomicReference<>(null); | |
| Semaphore semaphore = new Semaphore(0); | |
| ActionInput input = ActionInputHelper.fromPath("inputs/foo"); | |
| fakeFileCache.createScratchInput(input, "input-foo"); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| Spawn spawn = | |
| newSpawn( | |
| ImmutableMap.of(), | |
| ImmutableSet.of(), | |
| NestedSetBuilder.create(Order.STABLE_ORDER, input)); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| Random random = new Random(); | |
| for (int i = 0; i < taskCount; ++i) { | |
| boolean shouldInterrupt = random.nextBoolean(); | |
| executorService.execute( | |
| () -> { | |
| try { | |
| if (shouldInterrupt) { | |
| Thread.currentThread().interrupt(); | |
| } | |
| service.uploadInputsIfNotPresent(action, /* force= */ false); | |
| } catch (Throwable e) { | |
| if (!(shouldInterrupt && e instanceof InterruptedException)) { | |
| error.set(e); | |
| } | |
| } finally { | |
| semaphore.release(); | |
| } | |
| }); | |
| } | |
| semaphore.acquire(taskCount); | |
| assertThat(error.get()).isNull(); | |
| } | |
| @Test | |
| public void uploadInputsIfNotPresent_interrupted_requestCancelled() throws Exception { | |
| CountDownLatch uploadBlobCalled = new CountDownLatch(1); | |
| CountDownLatch interrupted = new CountDownLatch(1); | |
| CountDownLatch futureDone = new CountDownLatch(1); | |
| SettableFuture<ImmutableSet<Digest>> future = SettableFuture.create(); | |
| future.addListener(futureDone::countDown, directExecutor()); | |
| doAnswer( | |
| invocationOnMock -> { | |
| uploadBlobCalled.countDown(); | |
| return future; | |
| }) | |
| .when(cache.cacheProtocol) | |
| .uploadBlob(any(), any(), any()); | |
| ActionInput input = ActionInputHelper.fromPath("inputs/foo"); | |
| fakeFileCache.createScratchInput(input, "input-foo"); | |
| RemoteExecutionService service = newRemoteExecutionService(); | |
| Spawn spawn = | |
| newSpawn( | |
| ImmutableMap.of(), | |
| ImmutableSet.of(), | |
| NestedSetBuilder.create(Order.STABLE_ORDER, input)); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| RemoteAction action = service.buildRemoteAction(spawn, context); | |
| Thread thread = | |
| new Thread( | |
| () -> { | |
| try { | |
| service.uploadInputsIfNotPresent(action, /* force= */ false); | |
| } catch (InterruptedException ignored) { | |
| interrupted.countDown(); | |
| } catch (Exception ignored) { | |
| // intentionally ignored | |
| } | |
| }); | |
| thread.start(); | |
| uploadBlobCalled.await(); | |
| thread.interrupt(); | |
| interrupted.await(); | |
| futureDone.await(); | |
| assertThat(future.isCancelled()).isTrue(); | |
| } | |
| @Test | |
| public void buildMerkleTree_withMemoization_works() throws Exception { | |
| // Test that Merkle tree building can be memoized. | |
| // TODO: Would like to check that NestedSet.getNonLeaves() is only called once per node, but | |
| // cannot Mockito.spy on NestedSet as it is final. | |
| // arrange | |
| // Single node NestedSets are folded, so always add a dummy file everywhere. | |
| ActionInput dummyFile = ActionInputHelper.fromPath("file"); | |
| fakeFileCache.createScratchInput(dummyFile, "file"); | |
| ActionInput tree = ActionsTestUtil.createTreeArtifactWithGeneratingAction(artifactRoot, "tree"); | |
| ActionInput barFile = ActionInputHelper.fromPath("bar/file"); | |
| NestedSet<ActionInput> nodeBar = | |
| NestedSetBuilder.create(Order.STABLE_ORDER, dummyFile, barFile); | |
| fakeFileCache.createScratchInput(barFile, "bar"); | |
| ActionInput foo1File = ActionInputHelper.fromPath("foo1/file"); | |
| NestedSet<ActionInput> nodeFoo1 = | |
| NestedSetBuilder.create(Order.STABLE_ORDER, dummyFile, foo1File); | |
| fakeFileCache.createScratchInput(foo1File, "foo1"); | |
| ActionInput foo2File = ActionInputHelper.fromPath("foo2/file"); | |
| NestedSet<ActionInput> nodeFoo2 = | |
| NestedSetBuilder.create(Order.STABLE_ORDER, dummyFile, foo2File); | |
| fakeFileCache.createScratchInput(foo2File, "foo2"); | |
| ActionInput runfilesMiddleman = ActionsTestUtil.createArtifact(middlemanRoot, "runfiles"); | |
| NestedSet<ActionInput> nodeRoot1 = | |
| new NestedSetBuilder<ActionInput>(Order.STABLE_ORDER) | |
| .add(dummyFile) | |
| .add(runfilesMiddleman) | |
| .add(tree) | |
| .addTransitive(nodeBar) | |
| .addTransitive(nodeFoo1) | |
| .build(); | |
| NestedSet<ActionInput> nodeRoot2 = | |
| new NestedSetBuilder<ActionInput>(Order.STABLE_ORDER) | |
| .add(dummyFile) | |
| .add(runfilesMiddleman) | |
| .add(tree) | |
| .addTransitive(nodeBar) | |
| .addTransitive(nodeFoo2) | |
| .build(); | |
| Artifact toolDat = ActionsTestUtil.createArtifact(artifactRoot, "tool.dat"); | |
| fakeFileCache.createScratchInput(toolDat, "tool.dat"); | |
| RunfilesTree runfilesTree = | |
| createRunfilesTree("tools/tool.runfiles", ImmutableList.of(toolDat)); | |
| fakeFileCache.addRunfilesTree(runfilesMiddleman, runfilesTree); | |
| Spawn spawn1 = | |
| new SimpleSpawn( | |
| new FakeOwner("foo", "bar", "//dummy:label"), | |
| /* arguments= */ ImmutableList.of(), | |
| /* environment= */ ImmutableMap.of(), | |
| /* executionInfo= */ ImmutableMap.of(), | |
| /* inputs= */ nodeRoot1, | |
| /* outputs= */ ImmutableSet.of(), | |
| ResourceSet.ZERO); | |
| Spawn spawn2 = | |
| new SimpleSpawn( | |
| new FakeOwner("foo", "bar", "//dummy:label"), | |
| /* arguments= */ ImmutableList.of(), | |
| /* environment= */ ImmutableMap.of(), | |
| /* executionInfo= */ ImmutableMap.of(), | |
| /* inputs= */ nodeRoot2, | |
| /* outputs= */ ImmutableSet.of(), | |
| ResourceSet.ZERO); | |
| FakeSpawnExecutionContext context1 = newSpawnExecutionContext(spawn1); | |
| FakeSpawnExecutionContext context2 = newSpawnExecutionContext(spawn2); | |
| remoteOptions.remoteMerkleTreeCache = true; | |
| remoteOptions.remoteMerkleTreeCacheSize = 0; | |
| RemoteExecutionService service = spy(newRemoteExecutionService(remoteOptions)); | |
| // act first time | |
| service.buildRemoteAction(spawn1, context1); | |
| // assert first time | |
| verify(service, times(6)).uncachedBuildMerkleTreeVisitor(any(), any(), any(), any()); | |
| assertThat(service.getMerkleTreeCache().asMap().keySet()) | |
| .containsExactly( | |
| ImmutableList.of( | |
| ImmutableMap.of(), | |
| PathFragment.EMPTY_FRAGMENT, | |
| PathMapper.NOOP.getClass()), // fileset mapping | |
| ImmutableList.of( | |
| PathFragment.create("tools/tool.runfiles"), | |
| PathFragment.EMPTY_FRAGMENT, | |
| PathMapper.NOOP.getClass()), | |
| ImmutableList.of(tree, PathFragment.EMPTY_FRAGMENT, PathMapper.NOOP.getClass()), | |
| ImmutableList.of( | |
| nodeRoot1.toNode(), PathFragment.EMPTY_FRAGMENT, PathMapper.NOOP.getClass()), | |
| ImmutableList.of( | |
| nodeFoo1.toNode(), PathFragment.EMPTY_FRAGMENT, PathMapper.NOOP.getClass()), | |
| ImmutableList.of( | |
| nodeBar.toNode(), PathFragment.EMPTY_FRAGMENT, PathMapper.NOOP.getClass())); | |
| // act second time | |
| service.buildRemoteAction(spawn2, context2); | |
| // assert second time | |
| verify(service, times(6 + 2)).uncachedBuildMerkleTreeVisitor(any(), any(), any(), any()); | |
| assertThat(service.getMerkleTreeCache().asMap().keySet()) | |
| .containsExactly( | |
| ImmutableList.of( | |
| ImmutableMap.of(), | |
| PathFragment.EMPTY_FRAGMENT, | |
| PathMapper.NOOP.getClass()), // fileset mapping | |
| ImmutableList.of( | |
| PathFragment.create("tools/tool.runfiles"), | |
| PathFragment.EMPTY_FRAGMENT, | |
| PathMapper.NOOP.getClass()), | |
| ImmutableList.of(tree, PathFragment.EMPTY_FRAGMENT, PathMapper.NOOP.getClass()), | |
| ImmutableList.of( | |
| nodeRoot1.toNode(), PathFragment.EMPTY_FRAGMENT, PathMapper.NOOP.getClass()), | |
| ImmutableList.of( | |
| nodeRoot2.toNode(), PathFragment.EMPTY_FRAGMENT, PathMapper.NOOP.getClass()), | |
| ImmutableList.of( | |
| nodeFoo1.toNode(), PathFragment.EMPTY_FRAGMENT, PathMapper.NOOP.getClass()), | |
| ImmutableList.of( | |
| nodeFoo2.toNode(), PathFragment.EMPTY_FRAGMENT, PathMapper.NOOP.getClass()), | |
| ImmutableList.of( | |
| nodeBar.toNode(), PathFragment.EMPTY_FRAGMENT, PathMapper.NOOP.getClass())); | |
| } | |
| @Test | |
| public void buildRemoteActionForRemotePersistentWorkers() throws Exception { | |
| var input = ActionsTestUtil.createArtifact(artifactRoot, "input"); | |
| fakeFileCache.createScratchInput(input, "value"); | |
| var toolInput = ActionsTestUtil.createArtifact(artifactRoot, "worker_input"); | |
| fakeFileCache.createScratchInput(toolInput, "worker value"); | |
| Spawn spawn = | |
| new SpawnBuilder("@flagfile") | |
| .withExecutionInfo(ExecutionRequirements.SUPPORTS_WORKERS, "1") | |
| .withInputs(input, toolInput) | |
| .withTool(toolInput) | |
| .build(); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| remoteOptions.markToolInputs = true; | |
| remoteOptions.remoteDiscardMerkleTrees = false; | |
| RemoteExecutionService service = newRemoteExecutionService(remoteOptions); | |
| // Check that worker files are properly marked in the merkle tree. | |
| var remoteAction = service.buildRemoteAction(spawn, context); | |
| assertThat(remoteAction.getAction().getPlatform()) | |
| .isEqualTo( | |
| Platform.newBuilder() | |
| .addProperties( | |
| Platform.Property.newBuilder() | |
| .setName("persistentWorkerKey") | |
| .setValue( | |
| "b22d48cd55755474eae27e63a79306a64146bd5947d5bd3423d78f001cf7b3de")) | |
| .build()); | |
| var merkleTree = remoteAction.getMerkleTree(); | |
| var outputDirectory = | |
| merkleTree.getDirectoryByDigest(merkleTree.getRootProto().getDirectories(0).getDigest()); | |
| var inputFile = | |
| FileNode.newBuilder() | |
| .setName("input") | |
| .setDigest( | |
| Digest.newBuilder() | |
| .setHash("cd42404d52ad55ccfa9aca4adc828aa5800ad9d385a0671fbcbf724118320619") | |
| .setSizeBytes(5)) | |
| .setIsExecutable(true); | |
| var toolFile = | |
| FileNode.newBuilder() | |
| .setName("worker_input") | |
| .setDigest( | |
| Digest.newBuilder() | |
| .setHash("bbd21d9e9b2bbadb2bb67202833df0edc8d14baf38be49388ffc71831eb88ac4") | |
| .setSizeBytes(12)) | |
| .setIsExecutable(true) | |
| .setNodeProperties( | |
| NodeProperties.newBuilder() | |
| .addProperties(NodeProperty.newBuilder().setName("bazel_tool_input"))); | |
| assertThat(outputDirectory) | |
| .isEqualTo(Directory.newBuilder().addFiles(inputFile).addFiles(toolFile).build()); | |
| // Check that if an non-tool input changes, the persistent worker key does not change. | |
| fakeFileCache.createScratchInput(input, "value2"); | |
| assertThat(service.buildRemoteAction(spawn, context).getAction().getPlatform()) | |
| .isEqualTo( | |
| Platform.newBuilder() | |
| .addProperties( | |
| Platform.Property.newBuilder() | |
| .setName("persistentWorkerKey") | |
| .setValue( | |
| "b22d48cd55755474eae27e63a79306a64146bd5947d5bd3423d78f001cf7b3de")) | |
| .build()); | |
| // Check that if a tool input changes, the persistent worker key changes. | |
| fakeFileCache.createScratchInput(toolInput, "worker value2"); | |
| assertThat(service.buildRemoteAction(spawn, context).getAction().getPlatform()) | |
| .isEqualTo( | |
| Platform.newBuilder() | |
| .addProperties( | |
| Platform.Property.newBuilder() | |
| .setName("persistentWorkerKey") | |
| .setValue( | |
| "997337de8dc20123cd7c8fcaed2c9c79cd8138831f9fbbf119f37d0859c9e83a")) | |
| .build()); | |
| } | |
| @Test | |
| public void buildRemoteActionWithScrubbing() throws Exception { | |
| var keptInput = ActionsTestUtil.createArtifact(artifactRoot, "kept_input"); | |
| fakeFileCache.createScratchInput(keptInput, "kept"); | |
| var scrubbedInput = ActionsTestUtil.createArtifact(artifactRoot, "scrubbed_input"); | |
| fakeFileCache.createScratchInput(scrubbedInput, "scrubbed"); | |
| Spawn spawn = | |
| new SpawnBuilder("some/path/cmd") | |
| .withInputs(keptInput, scrubbedInput) | |
| .withExecutionInfo(ExecutionRequirements.NO_REMOTE_EXEC, "") | |
| .build(); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| remoteOptions.scrubber = | |
| new Scrubber( | |
| Config.newBuilder() | |
| .addRules( | |
| Config.Rule.newBuilder() | |
| .setTransform( | |
| Config.Transform.newBuilder() | |
| .setSalt("NaCl") | |
| .addOmittedInputs(".*scrubbed.*") | |
| .addArgReplacements( | |
| Config.Replacement.newBuilder() | |
| .setSource("some/path") | |
| .setTarget("another/dir")))) | |
| .build()); | |
| remoteOptions.remoteDiscardMerkleTrees = false; | |
| RemoteExecutionService service = newRemoteExecutionService(remoteOptions); | |
| RemoteAction remoteAction = service.buildRemoteAction(spawn, context); | |
| MerkleTree merkleTree = remoteAction.getMerkleTree(); | |
| Directory actualRootDir = | |
| merkleTree.getDirectoryByDigest(merkleTree.getRootProto().getDirectories(0).getDigest()); | |
| Directory expectedRootDir = | |
| Directory.newBuilder() | |
| .addFiles( | |
| FileNode.newBuilder() | |
| .setName("kept_input") | |
| .setDigest( | |
| Digest.newBuilder() | |
| .setHash( | |
| "79f076abdd19a752db7267bfff2f9022161d120dea919fdaca2ffdfc24ca8c96") | |
| .setSizeBytes(4)) | |
| .setIsExecutable(true)) | |
| .build(); | |
| assertThat(actualRootDir).isEqualTo(expectedRootDir); | |
| assertThat(remoteAction.getCommand().getArgumentsList()).containsExactly("another/dir/cmd"); | |
| assertThat(remoteAction.getAction().getSalt()) | |
| .isEqualTo( | |
| CacheSalt.newBuilder() | |
| .setScrubSalt(CacheSalt.ScrubSalt.newBuilder().setSalt("NaCl")) | |
| .build() | |
| .toByteString()); | |
| } | |
| @Test | |
| public void buildRemoteActionWithPathMapping(@TestParameter boolean remoteMerkleTreeCache) | |
| throws Exception { | |
| remoteOptions.remoteMerkleTreeCache = remoteMerkleTreeCache; | |
| var mappedInput = ActionsTestUtil.createArtifact(artifactRoot, "bin/config/input1"); | |
| fakeFileCache.createScratchInput(mappedInput, "value1"); | |
| var unmappedInput = ActionsTestUtil.createArtifact(artifactRoot, "bin/input2"); | |
| fakeFileCache.createScratchInput(unmappedInput, "value2"); | |
| var outputDir = | |
| ActionsTestUtil.createTreeArtifactWithGeneratingAction( | |
| artifactRoot, "bin/config/output_dir"); | |
| PathMapper pathMapper = | |
| execPath -> PathFragment.create(execPath.getPathString().replaceAll("config/", "")); | |
| Spawn spawn = | |
| new SpawnBuilder("unused") | |
| .withInputs(mappedInput, unmappedInput) | |
| .withOutputs("outputs/bin/config/dir/output1", "outputs/bin/other_dir/output2") | |
| .withOutputs(outputDir) | |
| .setPathMapper(pathMapper) | |
| .build(); | |
| FakeSpawnExecutionContext context = newSpawnExecutionContext(spawn); | |
| remoteOptions.remoteDiscardMerkleTrees = false; | |
| RemoteExecutionService service = newRemoteExecutionService(remoteOptions); | |
| // Check that inputs and outputs of the remote action are mapped correctly. | |
| var remoteAction = service.buildRemoteAction(spawn, context); | |
| assertThat(remoteAction.getInputMap(false)) | |
| .containsExactly( | |
| PathFragment.create("outputs/bin/input1"), mappedInput, | |
| PathFragment.create("outputs/bin/input2"), unmappedInput); | |
| assertThat(remoteAction.getCommand().getOutputFilesList()) | |
| .containsExactly("outputs/bin/dir/output1", "outputs/bin/other_dir/output2"); | |
| assertThat(remoteAction.getCommand().getOutputDirectoriesList()) | |
| .containsExactly("outputs/bin/output_dir"); | |
| assertThat(remoteAction.getCommand().getOutputPathsList()) | |
| .containsExactly( | |
| "outputs/bin/dir/output1", "outputs/bin/other_dir/output2", "outputs/bin/output_dir"); | |
| // Check that the Merkle tree nodes are mapped correctly, including the output directory. | |
| var merkleTree = remoteAction.getMerkleTree(); | |
| var outputsDirectory = | |
| merkleTree.getDirectoryByDigest(merkleTree.getRootProto().getDirectories(0).getDigest()); | |
| assertThat(outputsDirectory.getDirectoriesCount()).isEqualTo(1); | |
| var binDirectory = | |
| merkleTree.getDirectoryByDigest(outputsDirectory.getDirectories(0).getDigest()); | |
| assertThat( | |
| binDirectory.getFilesList().stream().map(FileNode::getName).collect(toImmutableList())) | |
| .containsExactly("input1", "input2"); | |
| assertThat( | |
| binDirectory.getDirectoriesList().stream() | |
| .map(DirectoryNode::getName) | |
| .collect(toImmutableList())) | |
| .containsExactly("output_dir"); | |
| } | |
| private Spawn newSpawnFromResult(RemoteActionResult result) { | |
| return newSpawnFromResult(ImmutableMap.of(), result); | |
| } | |
| private Spawn newSpawnFromResult( | |
| ImmutableMap<String, String> executionInfo, RemoteActionResult result) { | |
| ImmutableSet.Builder<Artifact> outputs = ImmutableSet.builder(); | |
| for (OutputFile file : result.getOutputFiles()) { | |
| Path path = remotePathResolver.outputPathToLocalPath(file.getPath()); | |
| Artifact output = ActionsTestUtil.createArtifact(artifactRoot, path); | |
| outputs.add(output); | |
| } | |
| for (OutputDirectory directory : result.getOutputDirectories()) { | |
| Path path = remotePathResolver.outputPathToLocalPath(directory.getPath()); | |
| Artifact output = | |
| ActionsTestUtil.createTreeArtifactWithGeneratingAction( | |
| artifactRoot, path.relativeTo(execRoot)); | |
| outputs.add(output); | |
| } | |
| for (OutputSymlink fileSymlink : result.getOutputFileSymlinks()) { | |
| Path path = remotePathResolver.outputPathToLocalPath(fileSymlink.getPath()); | |
| Artifact output = ActionsTestUtil.createArtifact(artifactRoot, path); | |
| outputs.add(output); | |
| } | |
| for (OutputSymlink directorySymlink : result.getOutputDirectorySymlinks()) { | |
| Path path = remotePathResolver.outputPathToLocalPath(directorySymlink.getPath()); | |
| Artifact output = | |
| ActionsTestUtil.createTreeArtifactWithGeneratingAction( | |
| artifactRoot, path.relativeTo(execRoot)); | |
| outputs.add(output); | |
| } | |
| for (OutputSymlink symlink : result.getOutputSymlinks()) { | |
| Path path = remotePathResolver.outputPathToLocalPath(symlink.getPath()); | |
| Artifact output = ActionsTestUtil.createArtifact(artifactRoot, path); | |
| outputs.add(output); | |
| } | |
| return newSpawn(executionInfo, outputs.build()); | |
| } | |
| private Spawn newSpawnFromResultWithInMemoryOutput( | |
| RemoteActionResult result, PathFragment inMemoryOutput) { | |
| return newSpawnFromResult( | |
| ImmutableMap.of(REMOTE_EXECUTION_INLINE_OUTPUTS, inMemoryOutput.getPathString()), result); | |
| } | |
| private Spawn newSpawn( | |
| ImmutableMap<String, String> executionInfo, ImmutableSet<Artifact> outputs) { | |
| return newSpawn(executionInfo, outputs, NestedSetBuilder.emptySet(Order.STABLE_ORDER)); | |
| } | |
| private Spawn newSpawn( | |
| ImmutableMap<String, String> executionInfo, | |
| ImmutableSet<Artifact> outputs, | |
| NestedSet<? extends ActionInput> inputs) { | |
| return new SimpleSpawn( | |
| new FakeOwner("foo", "bar", "//dummy:label"), | |
| /* arguments= */ ImmutableList.of(), | |
| /* environment= */ ImmutableMap.of(), | |
| /* executionInfo= */ executionInfo, | |
| /* inputs= */ inputs, | |
| /* outputs= */ outputs, | |
| ResourceSet.ZERO); | |
| } | |
| private FakeSpawnExecutionContext newSpawnExecutionContext(Spawn spawn) { | |
| return newSpawnExecutionContext(spawn, outErr); | |
| } | |
| private FakeSpawnExecutionContext newSpawnExecutionContext(Spawn spawn, FileOutErr outErr) { | |
| ImmutableList<Artifact> actionOutputs = | |
| spawn.getOutputFiles().stream() | |
| .filter(i -> i instanceof Artifact) | |
| .map(i -> (Artifact) i) | |
| .collect(toImmutableList()); | |
| var actionInputFetcher = | |
| new RemoteActionInputFetcher( | |
| new Reporter(new EventBus()), | |
| "none", | |
| "none", | |
| cache, | |
| execRoot, | |
| tempPathGenerator, | |
| remoteOutputChecker, | |
| ActionOutputDirectoryHelper.createForTesting(), | |
| OutputPermissions.READONLY); | |
| var actionFileSystem = | |
| new RemoteActionFileSystem( | |
| fs, | |
| execRoot.asFragment(), | |
| artifactRoot.getRoot().asPath().relativeTo(execRoot).getPathString(), | |
| new ActionInputMap(0), | |
| actionOutputs, | |
| StaticInputMetadataProvider.empty(), | |
| actionInputFetcher); | |
| return new FakeSpawnExecutionContext( | |
| spawn, fakeFileCache, execRoot, outErr, ImmutableClassToInstanceMap.of(), actionFileSystem); | |
| } | |
| private RemoteExecutionService newRemoteExecutionService() { | |
| return newRemoteExecutionService(remoteOptions); | |
| } | |
| private RemoteExecutionService newRemoteExecutionService(RemoteOptions remoteOptions) { | |
| return new RemoteExecutionService( | |
| directExecutor(), | |
| reporter, | |
| /* verboseFailures= */ true, | |
| execRoot, | |
| remotePathResolver, | |
| "none", | |
| "none", | |
| digestUtil, | |
| remoteOptions, | |
| cache, | |
| executor, | |
| tempPathGenerator, | |
| null, | |
| remoteOutputChecker, | |
| outputService); | |
| } | |
| private RunfilesTree createRunfilesTree(String root, Collection<Artifact> artifacts) { | |
| return new RunfilesTree() { | |
| @Override | |
| public PathFragment getExecPath() { | |
| return PathFragment.create(root); | |
| } | |
| @Override | |
| public Map<PathFragment, Artifact> getMapping() { | |
| return artifacts.stream().collect(toImmutableMap(Artifact::getExecPath, a -> a)); | |
| } | |
| @Override | |
| public NestedSet<Artifact> getArtifacts() { | |
| return NestedSetBuilder.wrap(Order.STABLE_ORDER, artifacts); | |
| } | |
| @Override | |
| public RunfileSymlinksMode getSymlinksMode() { | |
| return RunfileSymlinksMode.SKIP; | |
| } | |
| @Override | |
| public boolean isBuildRunfileLinks() { | |
| return false; | |
| } | |
| @Override | |
| public String getWorkspaceName() { | |
| return "__main__"; | |
| } | |
| }; | |
| } | |
| private void createOutputDirectories(Spawn spawn) throws IOException { | |
| for (ActionInput input : spawn.getOutputFiles()) { | |
| Path dir = execRoot.getRelative(input.getExecPath()); | |
| if (!input.isDirectory()) { | |
| dir = dir.getParentDirectory(); | |
| } | |
| dir.createDirectoryAndParents(); | |
| } | |
| } | |
| } |