commit | 26be41a5f4ef2b3812665b36f136d2e44ae12688 | [log] [tgz] |
---|---|---|
author | Googler <ilist@google.com> | Thu Oct 06 09:54:44 2022 -0700 |
committer | Copybara-Service <copybara-worker@google.com> | Thu Oct 06 09:56:11 2022 -0700 |
tree | 817cc7c546e54e273870542858207fbe0204000c | |
parent | dbcf260e0318ef553d606b0510832cfe8a5b14eb [diff] |
Fix a NPE in compatible target skipping Under a complex set of conditions a NPE is triggered. It was caused by IncompatibleTargetChecker constructing a RuleConfiguredTarget without adding a VisibilityProviderImpl to it. All other locations where RuleConfiguredTarget is constructed add the provider, namely RuleConfiguredTargetBuilder. When the set of conditions is met, code path checking the visibility retrieves the provider without checking if it's available. The data in VisibilityProvider is duplicated with the data already in RuleConfiguredTarget. Fix by removing the provider and retrieving the data directly. Add the regression test with description how it happens. PiperOrigin-RevId: 479339612 Change-Id: I8e29a9882de87d884f53e104ae14d6a126a8096b
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md